big batch of changes

[chaz/yoink] / src / Moof / Sound.hh

diff --git a/src/Moof/Sound.hh b/src/Moof/Sound.hh
index c9929cedeae2169b4c61bedf7d557802395f47ba..982e9b4065eeca659601fd9015846407a2936fab 100644 (file)
--- a/src/Moof/Sound.hh
+++ b/src/Moof/Sound.hh
@@ -50,9 +50,6 @@ typedef boost::shared_ptr<Sound> SoundP;
 
 class Sound : public Resource
 {
-       class Impl;
-       boost::shared_ptr<Impl> impl_;
-
 public:
 
        static SoundP alloc(const std::string& name)
@@ -60,15 +57,14 @@ public:
                return SoundP(new Sound(name));
        }
 
+       Sound();
        explicit Sound(const std::string& name);
 
 
        void play();
        void stream();
 
-       // TODO - i don't like how there are two different methods that essentially
-       // do the same thing; the API should be exactly the same for both types of
-       // sounds; need a different way to distinguish how to handle the sound
+       // TODO this API sucks...  refactor me!!
 
        void stop();
        void pause();
@@ -80,40 +76,23 @@ public:
 
        bool isPlaying() const;
 
-       void setPosition(Vector3 position);
-       void setVelocity(Vector3 velocity);
+       void setPosition(const Vector3& position);
+       void setVelocity(const Vector3& velocity);
        void setGain(Scalar gain);
        void setPitch(Scalar pitch);
        void setLooping(bool looping);
 
+       static void setListenerPosition(const Vector3& position);
+       static void setListenerVelocity(const Vector3& velocity);
+       static void setListenerOrientation(const Vector3& forward,
+                       const Vector3& up);
+
        static std::string getPath(const std::string& name);
 
+private:
 
-       struct Exception : public Mf::Exception
-       {
-               enum
-               {
-                       BAD_AUDIO_FORMAT        = 1024
-               };
-
-               explicit Exception(unsigned error) :
-                       Mf::Exception(error) {}
-
-               void raise()
-               {
-                       throw *this;
-               }
-
-               const char* what() const throw()
-               {
-                       switch (code)
-                       {
-                               case BAD_AUDIO_FORMAT:
-                                       return "unknown audio format";
-                       }
-                       return Mf::Exception::what();
-               }
-       };
+       class Impl;
+       boost::shared_ptr<Impl> mImpl;
 };