fixed updating of nullable has_many rels (RT#65561)

[chaz/p5-DBIx-Class-ResultSet-RecursiveUpdate] / lib / DBIx / Class / ResultSet / RecursiveUpdate.pm

diff --git a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm
index f70e4fbc63ef126a52a91b1457ce5c27a9f4f2cf..c0db8b415ebac682e0a1bad8fe19b18722fb0604 100644 (file)
--- a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm
+++ b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm
@@ -79,14 +79,12 @@ sub recursive_update {
 
     my %fixed_fields = map { $_ => 1 } @$fixed_fields
         if $fixed_fields;
+
     # the updates hashref might contain the pk columns
     # but with an undefined value
     my @missing =
-        grep {
-        ( !exists $updates->{$_}
-                || ( exists $updates->{$_} && !defined $updates->{$_} ) )
-            && !exists $fixed_fields{$_}
-        } $source->primary_columns;
+        grep { !defined $updates->{$_} && !exists $fixed_fields{$_} }
+        $source->primary_columns;
 
     # warn "MISSING: " . join(', ', @missing) . "\n";
     if ( !defined $object && scalar @missing == 0 ) {
@@ -97,12 +95,10 @@ sub recursive_update {
 
     # add the resolved columns to the updates hashref
     $updates = { %$updates, %$resolved };
+
     # the resolved hashref might contain the pk columns
     # but with an undefined value
-    @missing = grep {
-        !exists $resolved->{$_}
-            || ( exists $resolved->{$_} && !defined $resolved->{$_} )
-    } @missing;
+    @missing = grep { !defined $resolved->{$_} } @missing;
 
     #warn "MISSING2: " . join( ', ', @missing ) . "\n";
     if ( !defined $object && scalar @missing == 0 ) {
@@ -330,7 +326,7 @@ sub _update_relation {
                 ->{is_nullable};
     }
 
-    $if_not_submitted = $all_fks_nullable ? 'nullify' : 'delete'
+    $if_not_submitted = $all_fks_nullable ? 'set_to_null' : 'delete'
         unless defined $if_not_submitted;
 
     #warn "\tNULLABLE: $all_fks_nullable ACTION: $if_not_submitted\n";
@@ -391,9 +387,9 @@ sub _update_relation {
                 $rs_rel_delist =
                     $rs_rel_delist->search_rs( { -not => [@cond] } );
             }
+            #warn "\tCOND: " . Dumper(\@cond);
         }
 
-        #warn "\tCOND: " . Dumper(\%cond);
         #my $rel_delist_cnt = $rs_rel_delist->count;
         if ( $if_not_submitted eq 'delete' ) {