{
enum read_header status = HEADER_STILL_UNREAD;
enum read_header prev_status;
- char save_typeflag;
base64_init ();
name_gather ();
|| current_stat.st_mtime < newer_mtime_option
|| excluded_name (current_file_name))
{
- int isextended = 0;
+ char save_typeflag;
if (current_header->header.typeflag == GNUTYPE_VOLHDR
|| current_header->header.typeflag == GNUTYPE_MULTIVOL
/* Skip past it in the archive. */
- if (current_header->oldgnu_header.isextended)
- isextended = 1;
save_typeflag = current_header->header.typeflag;
set_next_block_after (current_header);
- if (isextended)
- {
-#if 0
- union block *exhdr;
-
- while (1)
- {
- exhdr = find_next_block ();
- if (!exhdr->sparse_header.isextended)
- {
- set_next_block_after (exhdr);
- break;
- }
- }
- set_next_block_after (exhdr);
-#endif
- skip_extended_headers ();
- }
+ if (current_header->oldgnu_header.isextended)
+ skip_extended_headers ();
/* Skip to the next header on the archive. */
void
list_archive (void)
{
- int isextended = 0; /* to remember if current_header is extended */
-
/* Print the header block. */
if (verbose_option)
}
- /* Check to see if we have an extended header to skip over also. */
-
- if (current_header->oldgnu_header.isextended)
- isextended = 1;
-
- /* Skip past the header in the archive. */
+ /* Skip past the header in the archive, and past any extended headers. */
set_next_block_after (current_header);
-
- /* If we needed to skip any extended headers, do so now, by reading
- extended headers and skipping past them in the archive. */
-
- if (isextended)
- {
-#if 0
- union block *exhdr;
-
- while (1)
- {
- exhdr = find_next_block ();
-
- if (!exhdr->sparse_header.isextended)
- {
- set_next_block_after (exhdr);
- break;
- }
- set_next_block_after (exhdr);
- }
-#endif
- skip_extended_headers ();
- }
+ if (current_header->oldgnu_header.isextended)
+ skip_extended_headers ();
if (multi_volume_option)
assign_string (&save_name, current_file_name);
a name containing characters with the high bit set. So read_header
computes two checksums -- signed and unsigned. */
-/* FIXME: The signed checksum computation is broken on machines where char's
- are unsigned. It's uneasy to handle all cases correctly... */
-
enum read_header
read_header (void)
{
size_t i;
- long unsigned_sum; /* the POSIX one :-) */
- long signed_sum; /* the Sun one :-( */
- long recorded_sum;
+ int unsigned_sum; /* the POSIX one :-) */
+ int signed_sum; /* the Sun one :-( */
+ int recorded_sum;
uintmax_t parsed_sum;
char *p;
union block *header;
if (!header)
return HEADER_END_OF_FILE;
- parsed_sum = from_chars (header->header.chksum,
- sizeof header->header.chksum,
- (char *) 0, (uintmax_t) 0,
- (uintmax_t) TYPE_MAXIMUM (long));
- if (parsed_sum == (uintmax_t) -1)
- return HEADER_FAILURE;
-
- recorded_sum = parsed_sum;
unsigned_sum = 0;
signed_sum = 0;
p = header->buffer;
for (i = sizeof (*header); i-- != 0;)
{
- /* We can't use unsigned char here because of old compilers,
- e.g. V7. */
-
- unsigned_sum += 0xFF & *p;
- signed_sum += *p++;
+ unsigned_sum += (unsigned char) *p;
+ signed_sum += signed_char (*p++);
}
+ if (unsigned_sum == 0)
+ return HEADER_ZERO_BLOCK;
+
/* Adjust checksum to count the "chksum" field as blanks. */
for (i = sizeof (header->header.chksum); i-- != 0;)
{
- unsigned_sum -= 0xFF & header->header.chksum[i];
- signed_sum -= header->header.chksum[i];
+ unsigned_sum -= (unsigned char) header->header.chksum[i];
+ signed_sum -= signed_char (header->header.chksum[i]);
}
unsigned_sum += ' ' * sizeof header->header.chksum;
signed_sum += ' ' * sizeof header->header.chksum;
- if (unsigned_sum == sizeof header->header.chksum * ' ')
- {
- /* This is a zeroed block...whole block is 0's except for the
- blanks we faked for the checksum field. */
+ parsed_sum = from_chars (header->header.chksum,
+ sizeof header->header.chksum,
+ (char *) 0, (uintmax_t) 0,
+ (uintmax_t) TYPE_MAXIMUM (int));
+ if (parsed_sum == (uintmax_t) -1)
+ return HEADER_FAILURE;
- return HEADER_ZERO_BLOCK;
- }
+ recorded_sum = parsed_sum;
if (unsigned_sum != recorded_sum && signed_sum != recorded_sum)
return HEADER_FAILURE;
else
current_stat.st_size = OFF_FROM_CHARS (header->header.size);
- header->header.name[NAME_FIELD_SIZE - 1] = '\0';
if (header->header.typeflag == GNUTYPE_LONGNAME
|| header->header.typeflag == GNUTYPE_LONGLINK)
{
}
else
{
- char *name = next_long_name;
+ char *name;
struct posix_header *h = ¤t_header->header;
- char namebuf[sizeof h->prefix + 1 + sizeof h->name + 1];
+ char namebuf[sizeof h->prefix + 1 + NAME_FIELD_SIZE + 1];
+ name = next_long_name;
if (! name)
{
/* Accept file names as specified by POSIX.1-1996
section 10.1.1. */
- int is_posix = (strcmp (h->magic, TMAGIC) == 0);
+ int posix_header = strcmp (h->magic, TMAGIC) == 0;
char *np = namebuf;
- if (is_posix && h->prefix[0])
+ if (posix_header && h->prefix[0])
{
memcpy (np, h->prefix, sizeof h->prefix);
np[sizeof h->prefix] = '\0';
np[sizeof h->name] = '\0';
name = namebuf;
}
-
assign_string (¤t_file_name, name);
- assign_string (¤t_link_name,
- (next_long_link ? next_long_link
- : current_header->header.linkname));
- next_long_link = next_long_name = 0;
+ if (next_long_name)
+ {
+ free (next_long_name);
+ next_long_name = 0;
+ }
+
+ name = next_long_link;
+ if (! name)
+ {
+ memcpy (namebuf, h->linkname, sizeof h->linkname);
+ namebuf[sizeof h->linkname] = '\0';
+ name = namebuf;
+ }
+ assign_string (¤t_link_name, name);
+ if (next_long_link)
+ {
+ free (next_long_link);
+ next_long_link = 0;
+ }
+
return HEADER_SUCCESS;
}
}
char const *lim = where + digs;
int negative = 0;
+ /* Accommodate older tars, which output leading spaces, and at least one
+ buggy tar, which outputs leading NUL if the previous field overflows. */
for (;;)
{
if (where == lim)
{
if (type)
ERROR ((0, 0,
- _("Blanks in header where numeric %s value expected"),
+ _("Empty header where numeric %s value expected"),
type));
return -1;
}
- if (!ISSPACE ((unsigned char) *where))
+ if (!ISSPACE ((unsigned char) *where) && *where)
break;
where++;
}
static char *
isotime (const time_t *time)
{
- static char buffer[21];
- struct tm *tm;
+ static char buffer[INT_STRLEN_BOUND (int) + 16];
+ struct tm *tm = localtime (time);
+ if (tm)
+ sprintf (buffer, "%04d-%02d-%02d %02d:%02d:%02d",
+ tm->tm_year + 1900, tm->tm_mon + 1, tm->tm_mday,
+ tm->tm_hour, tm->tm_min, tm->tm_sec);
+ else
+ /* Interpose %s between ?? and - to avoid ANSI C trigraph brain damage. */
+ sprintf (buffer, "????%s-??%s-?? ??:??:??", "", "");
- tm = localtime (time);
- sprintf (buffer, "%4d-%02d-%02d %02d:%02d:%02d\n",
- tm->tm_year + 1900, tm->tm_mon + 1, tm->tm_mday,
- tm->tm_hour, tm->tm_min, tm->tm_sec);
return buffer;
}
print_header (void)
{
char modes[11];
- char *timestamp;
+ char const *timestamp;
/* These hold formatted ints. */
char uform[UINTMAX_STRSIZE_BOUND], gform[UINTMAX_STRSIZE_BOUND];
char *user, *group;
longie = current_stat.st_mtime;
#if USE_OLD_CTIME
- timestamp = ctime (&longie);
- timestamp[16] = '\0';
- timestamp[24] = '\0';
+ {
+ char *ct = ctime (&longie);
+ if (ct)
+ {
+ timestamp = ct + 4;
+ for (ct += 16; ct[4] != '\n'; ct++)
+ ct[0] = ct[4];
+ ct[0] = '\0';
+ }
+ else
+ timestamp = "??? ?? ??:?? ????";
+ }
#else
timestamp = isotime (&longie);
- timestamp[16] = '\0';
#endif
/* User and group names. */
if (pad > ugswidth)
ugswidth = pad;
-#if USE_OLD_CTIME
- fprintf (stdlis, "%s %s/%s %*s%s %s %s",
- modes, user, group, ugswidth - pad, "",
- size, timestamp + 4, timestamp + 20);
-#else
fprintf (stdlis, "%s %s/%s %*s%s %s",
modes, user, group, ugswidth - pad, "", size, timestamp);
-#endif
name = quote_copy_string (current_file_name);
if (name)
{
union block *exhdr;
- while (1)
+ do
{
exhdr = find_next_block ();
- if (!exhdr->sparse_header.isextended)
- {
- set_next_block_after (exhdr);
- break;
- }
+ if (!exhdr)
+ FATAL_ERROR ((0, 0, _("Unexpected EOF on archive file")));
set_next_block_after (exhdr);
}
+ while (exhdr->sparse_header.isextended);
}
projects / chaz / tar / blobdiff