Fix bug in sparse file listing

[chaz/tar] / src / misc.c

diff --git a/src/misc.c b/src/misc.c
index 0424ea7cc2f9a582805a99e6463ce042cf68d626..8e66643829d46fd894a3defd0e52c19de12386a2 100644 (file)
--- a/src/misc.c
+++ b/src/misc.c
@@ -1,7 +1,7 @@
 /* Miscellaneous functions, not really specific to GNU tar.
 
    Copyright 1988, 1992, 1994-1997, 1999-2001, 2003-2007, 2009-2010,
 /* Miscellaneous functions, not really specific to GNU tar.
 
    Copyright 1988, 1992, 1994-1997, 1999-2001, 2003-2007, 2009-2010,

-   2012-2013 Free Software Foundation, Inc.
+   2012-2014 Free Software Foundation, Inc.

 
    This program is free software; you can redistribute it and/or modify it
    under the terms of the GNU General Public License as published by the
 
    This program is free software; you can redistribute it and/or modify it
    under the terms of the GNU General Public License as published by the


@@ -29,6 +29,8 @@
 # define DOUBLE_SLASH_IS_DISTINCT_ROOT 0
 #endif
 
 # define DOUBLE_SLASH_IS_DISTINCT_ROOT 0
 #endif
 

+static const char *tar_getcdpath (int);
+

 \f
 /* Handling strings.  */
 
 \f
 /* Handling strings.  */
 


@@ -230,7 +232,7 @@ zap_slashes (char *name)
 
 /* Normalize FILE_NAME by removing redundant slashes and "."
    components, including redundant trailing slashes.
 
 /* Normalize FILE_NAME by removing redundant slashes and "."
    components, including redundant trailing slashes.

-   Leave ".." alone, as it may be significant in the presence 
+   Leave ".." alone, as it may be significant in the presence

    of symlinks and on platforms where "/.." != "/".
 
    Destructive version: modifies its argument. */
    of symlinks and on platforms where "/.." != "/".
 
    Destructive version: modifies its argument. */


@@ -286,11 +288,14 @@ normalize_filename (int cdidx, const char *name)
          this following approach may lead to situations where the same
          file or directory is processed twice under different absolute
          paths without that duplication being detected.  Perhaps we
          this following approach may lead to situations where the same
          file or directory is processed twice under different absolute
          paths without that duplication being detected.  Perhaps we

-         should use dev+ino pairs instead of names?  */
+         should use dev+ino pairs instead of names?  (See listed03.at for
+         a related test case.) */

       const char *cdpath = tar_getcdpath (cdidx);
       size_t copylen;
       bool need_separator;
       const char *cdpath = tar_getcdpath (cdidx);
       size_t copylen;
       bool need_separator;

-      
+
+      if (!cdpath)
+       call_arg_fatal ("getcwd", ".");

       copylen = strlen (cdpath);
       need_separator = ! (DOUBLE_SLASH_IS_DISTINCT_ROOT
                          && copylen == 2 && ISSLASH (cdpath[1]));
       copylen = strlen (cdpath);
       need_separator = ! (DOUBLE_SLASH_IS_DISTINCT_ROOT
                          && copylen == 2 && ISSLASH (cdpath[1]));


@@ -834,10 +839,11 @@ struct wd
 {
   /* The directory's name.  */
   char const *name;
 {
   /* The directory's name.  */
   char const *name;

-  /* "absolute" path representing this directory; in the contrast to
+  /* "Absolute" path representing this directory; in the contrast to

      the real absolute pathname, it can contain /../ components (see
      the real absolute pathname, it can contain /../ components (see

-     normalize_filename_x for the reason of it). */
-  char *abspath; 
+     normalize_filename_x for the reason of it).  It is NULL if the
+     absolute path could not be determined.  */
+  char *abspath;

   /* If nonzero, the file descriptor of the directory, or AT_FDCWD if
      the working directory.  If zero, the directory needs to be opened
      to be used.  */
   /* If nonzero, the file descriptor of the directory, or AT_FDCWD if
      the working directory.  If zero, the directory needs to be opened
      to be used.  */


@@ -879,15 +885,13 @@ chdir_count (void)
 int
 chdir_arg (char const *dir)
 {
 int
 chdir_arg (char const *dir)
 {

+  char *absdir;
+

   if (wd_count == wd_alloc)
     {
       if (wd_alloc == 0)
   if (wd_count == wd_alloc)
     {
       if (wd_alloc == 0)

-       {
-         wd_alloc = 2;
-         wd = xmalloc (sizeof *wd * wd_alloc);
-       }
-      else
-       wd = x2nrealloc (wd, &wd_alloc, sizeof *wd);
+       wd_alloc = 2;
+      wd = x2nrealloc (wd, &wd_alloc, sizeof *wd);

 
       if (! wd_count)
        {
 
       if (! wd_count)
        {


@@ -909,18 +913,22 @@ chdir_arg (char const *dir)
        return wd_count - 1;
     }
 
        return wd_count - 1;
     }
 

-  wd[wd_count].name = dir;
-  /* if the given name is an absolute path, then use that path
-     to represent this working directory; otherwise, construct
-     a path based on the previous -C option's absolute path */
-  if (IS_ABSOLUTE_FILE_NAME (wd[wd_count].name))
-    wd[wd_count].abspath = xstrdup (wd[wd_count].name);
-  else
+
+  /* If the given name is absolute, use it to represent this directory;
+     otherwise, construct a name based on the previous -C option.  */
+  if (IS_ABSOLUTE_FILE_NAME (dir))
+    absdir = xstrdup (dir);
+  else if (wd[wd_count - 1].abspath)

     {
       namebuf_t nbuf = namebuf_create (wd[wd_count - 1].abspath);
     {
       namebuf_t nbuf = namebuf_create (wd[wd_count - 1].abspath);

-      namebuf_add_dir (nbuf, wd[wd_count].name);
-      wd[wd_count].abspath = namebuf_finish (nbuf);
+      namebuf_add_dir (nbuf, dir);
+      absdir = namebuf_finish (nbuf);

     }
     }

+  else
+    absdir = 0;
+
+  wd[wd_count].name = dir;
+  wd[wd_count].abspath = absdir;

   wd[wd_count].fd = 0;
   return wd_count++;
 }
   wd[wd_count].fd = 0;
   return wd_count++;
 }


@@ -1007,7 +1015,7 @@ tar_dirname (void)
    chdir_args() has never been called, so we simply return the
    process's actual cwd.  (Note that in this case IDX is ignored,
    since it should always be 0.) */
    chdir_args() has never been called, so we simply return the
    process's actual cwd.  (Note that in this case IDX is ignored,
    since it should always be 0.) */

-const char *
+static const char *

 tar_getcdpath (int idx)
 {
   if (!wd)
 tar_getcdpath (int idx)
 {
   if (!wd)


@@ -1206,7 +1214,7 @@ char *
 namebuf_finish (namebuf_t buf)
 {
   char *res = buf->buffer;
 namebuf_finish (namebuf_t buf)
 {
   char *res = buf->buffer;

-  
+

   if (ISSLASH (buf->buffer[buf->dir_length - 1]))
     buf->buffer[buf->dir_length] = 0;
   free (buf);
   if (ISSLASH (buf->buffer[buf->dir_length - 1]))
     buf->buffer[buf->dir_length] = 0;
   free (buf);


@@ -1232,7 +1240,7 @@ tar_savedir (const char *name, int must_exist)
       open_error (name);
     }
   else if (! ((dir = fdopendir (fd))
       open_error (name);
     }
   else if (! ((dir = fdopendir (fd))

-             && (ret = streamsavedir (dir))))
+             && (ret = streamsavedir (dir, savedir_sort_order))))

     savedir_error (name);
 
   if (dir ? closedir (dir) != 0 : 0 <= fd && close (fd) != 0)
     savedir_error (name);
 
   if (dir ? closedir (dir) != 0 : 0 <= fd && close (fd) != 0)