tar: use ctime, not mtime, when checking placeholders

[chaz/tar] / src / list.c

diff --git a/src/list.c b/src/list.c
index 5a341aad2c81d5deb1505ff7f48cf2d515443749..f0d3d5a5a3fe09e4828b0b6e5c64de30ea66caa0 100644 (file)
--- a/src/list.c
+++ b/src/list.c
@@ -35,6 +35,20 @@ size_t recent_long_name_blocks;      /* number of blocks in recent_long_name */
 size_t recent_long_link_blocks;        /* likewise, for long link */
 union block *recent_global_header; /* Recent global header block */
 
 size_t recent_long_link_blocks;        /* likewise, for long link */
 union block *recent_global_header; /* Recent global header block */
 

+#define GID_FROM_HEADER(where) gid_from_header (where, sizeof (where))
+#define MAJOR_FROM_HEADER(where) major_from_header (where, sizeof (where))
+#define MINOR_FROM_HEADER(where) minor_from_header (where, sizeof (where))
+#define MODE_FROM_HEADER(where, hbits) \
+  mode_from_header (where, sizeof (where), hbits)
+#define TIME_FROM_HEADER(where) time_from_header (where, sizeof (where))
+#define UID_FROM_HEADER(where) uid_from_header (where, sizeof (where))
+
+static gid_t gid_from_header (const char *buf, size_t size);
+static major_t major_from_header (const char *buf, size_t size);
+static minor_t minor_from_header (const char *buf, size_t size);
+static mode_t mode_from_header (const char *buf, size_t size, unsigned *hbits);
+static time_t time_from_header (const char *buf, size_t size);
+static uid_t uid_from_header (const char *buf, size_t size);

 static uintmax_t from_header (const char *, size_t, const char *,
                              uintmax_t, uintmax_t, bool, bool);
 
 static uintmax_t from_header (const char *, size_t, const char *,
                              uintmax_t, uintmax_t, bool, bool);
 


@@ -78,7 +92,8 @@ read_and (void (*do_something) (void))
       prev_status = status;
       tar_stat_destroy (&current_stat_info);
 
       prev_status = status;
       tar_stat_destroy (&current_stat_info);
 

-      status = read_header (&current_header, &current_stat_info, false);
+      status = read_header (&current_header, &current_stat_info,
+                            read_header_auto);

       switch (status)
        {
        case HEADER_STILL_UNREAD:
       switch (status)
        {
        case HEADER_STILL_UNREAD:


@@ -89,7 +104,8 @@ read_and (void (*do_something) (void))
 
          /* Valid header.  We should decode next field (mode) first.
             Ensure incoming names are null terminated.  */
 
          /* Valid header.  We should decode next field (mode) first.
             Ensure incoming names are null terminated.  */

-
+         decode_header (current_header, &current_stat_info,
+                        &current_format, 1);

          if (! name_match (current_stat_info.file_name)
              || (NEWER_OPTION_INITIALIZED (newer_mtime_option)
                  /* FIXME: We get mtime now, and again later; this causes
          if (! name_match (current_stat_info.file_name)
              || (NEWER_OPTION_INITIALIZED (newer_mtime_option)
                  /* FIXME: We get mtime now, and again later; this causes


@@ -115,8 +131,6 @@ read_and (void (*do_something) (void))
                           quotearg_colon (current_stat_info.file_name)));
                  /* Fall through.  */
                default:
                           quotearg_colon (current_stat_info.file_name)));
                  /* Fall through.  */
                default:

-                 decode_header (current_header,
-                                &current_stat_info, &current_format, 0);

                  skip_member ();
                  continue;
                }
                  skip_member ();
                  continue;
                }


@@ -139,7 +153,8 @@ read_and (void (*do_something) (void))
            {
              char buf[UINTMAX_STRSIZE_BOUND];
 
            {
              char buf[UINTMAX_STRSIZE_BOUND];
 

-             status = read_header (&current_header, &current_stat_info, false);
+             status = read_header (&current_header, &current_stat_info,
+                                   read_header_auto);

              if (status == HEADER_ZERO_BLOCK)
                break;
              WARNOPT (WARN_ALONE_ZERO_BLOCK,
              if (status == HEADER_ZERO_BLOCK)
                break;
              WARNOPT (WARN_ALONE_ZERO_BLOCK,


@@ -208,8 +223,6 @@ list_archive (void)
   off_t block_ordinal = current_block_ordinal ();
 
   /* Print the header block.  */
   off_t block_ordinal = current_block_ordinal ();
 
   /* Print the header block.  */

-  
-  decode_header (current_header, &current_stat_info, &current_format, 0);

   if (verbose_option)
     print_header (&current_stat_info, current_header, block_ordinal);
 
   if (verbose_option)
     print_header (&current_stat_info, current_header, block_ordinal);
 


@@ -282,21 +295,29 @@ tar_checksum (union block *header, bool silent)
 }
 
 /* Read a block that's supposed to be a header block.  Return its
 }
 
 /* Read a block that's supposed to be a header block.  Return its

-   address in "current_header", and if it is good, the file's size
-   and names (file name, link name) in *info.
+   address in *RETURN_BLOCK, and if it is good, the file's size
+   and names (file name, link name) in *INFO.
+
+   Return one of enum read_header describing the status of the
+   operation.

 
 

-   Return 1 for success, 0 if the checksum is bad, EOF on eof, 2 for a
-   block full of zeros (EOF marker).
+   The MODE parameter instructs read_header what to do with special
+   header blocks, i.e.: extended POSIX, GNU long name or long link,
+   etc.:

 
 

-   If RAW_EXTENDED_HEADERS is nonzero, do not automagically fold the
-   GNU long name and link headers into later headers.
+     read_header_auto        process them automatically,
+     read_header_x_raw       when a special header is read, return
+                             HEADER_SUCCESS_EXTENDED without actually
+                            processing the header,
+     read_header_x_global    when a POSIX global header is read,
+                             decode it and return HEADER_SUCCESS_EXTENDED.

 
 

-   You must always set_next_block_after(current_header) to skip past
+   You must always set_next_block_after(*return_block) to skip past

    the header which this routine reads.  */
 
 enum read_header
 read_header (union block **return_block, struct tar_stat_info *info,
    the header which this routine reads.  */
 
 enum read_header
 read_header (union block **return_block, struct tar_stat_info *info,

-            bool raw_extended_headers)
+            enum read_header_mode mode)

 {
   union block *header;
   union block *header_copy;
 {
   union block *header;
   union block *header_copy;


@@ -333,7 +354,7 @@ read_header (union block **return_block, struct tar_stat_info *info,
          || header->header.typeflag == XGLTYPE
          || header->header.typeflag == SOLARIS_XHDTYPE)
        {
          || header->header.typeflag == XGLTYPE
          || header->header.typeflag == SOLARIS_XHDTYPE)
        {

-         if (raw_extended_headers)
+         if (mode == read_header_x_raw)

            return HEADER_SUCCESS_EXTENDED;
          else if (header->header.typeflag == GNUTYPE_LONGNAME
                   || header->header.typeflag == GNUTYPE_LONGLINK)
            return HEADER_SUCCESS_EXTENDED;
          else if (header->header.typeflag == GNUTYPE_LONGNAME
                   || header->header.typeflag == GNUTYPE_LONGLINK)


@@ -405,6 +426,8 @@ read_header (union block **return_block, struct tar_stat_info *info,
                            OFF_FROM_HEADER (header->header.size));
              xheader_decode_global (&xhdr);
              xheader_destroy (&xhdr);
                            OFF_FROM_HEADER (header->header.size));
              xheader_decode_global (&xhdr);
              xheader_destroy (&xhdr);

+             if (mode == read_header_x_global)
+               return HEADER_SUCCESS_EXTENDED;

            }
 
          /* Loop!  */
            }
 
          /* Loop!  */


@@ -484,18 +507,18 @@ decode_xform (char *file_name, void *data)
         links subject to filename transformation.  In the absence of another
         solution, symbolic links are exempt from component stripping and
         name suffix normalization, but subject to filename transformation
         links subject to filename transformation.  In the absence of another
         solution, symbolic links are exempt from component stripping and
         name suffix normalization, but subject to filename transformation

-        proper. */ 
+        proper. */

       return file_name;
       return file_name;

-      
+

     case XFORM_LINK:
       file_name = safer_name_suffix (file_name, true, absolute_names_option);
       break;
     case XFORM_LINK:
       file_name = safer_name_suffix (file_name, true, absolute_names_option);
       break;

-      
+

     case XFORM_REGFILE:
       file_name = safer_name_suffix (file_name, false, absolute_names_option);
       break;
     }
     case XFORM_REGFILE:
       file_name = safer_name_suffix (file_name, false, absolute_names_option);
       break;
     }

-  
+

   if (strip_name_components)
     {
       size_t prefix_len = stripped_prefix_len (file_name,
   if (strip_name_components)
     {
       size_t prefix_len = stripped_prefix_len (file_name,


@@ -507,7 +530,7 @@ decode_xform (char *file_name, void *data)
   return file_name;
 }
 
   return file_name;
 }
 

-bool
+static bool

 transform_member_name (char **pinput, int type)
 {
   return transform_name_fp (pinput, type, decode_xform, &type);
 transform_member_name (char **pinput, int type)
 {
   return transform_name_fp (pinput, type, decode_xform, &type);


@@ -535,7 +558,7 @@ decode_header (union block *header, struct tar_stat_info *stat_info,
   enum archive_format format;
   unsigned hbits; /* high bits of the file mode. */
   mode_t mode = MODE_FROM_HEADER (header->header.mode, &hbits);
   enum archive_format format;
   unsigned hbits; /* high bits of the file mode. */
   mode_t mode = MODE_FROM_HEADER (header->header.mode, &hbits);

-  
+

   if (strcmp (header->header.magic, TMAGIC) == 0)
     {
       if (header->star_header.prefix[130] == 0
   if (strcmp (header->header.magic, TMAGIC) == 0)
     {
       if (header->star_header.prefix[130] == 0


@@ -639,7 +662,7 @@ decode_header (union block *header, struct tar_stat_info *stat_info,
     case SYMTYPE:
       transform_member_name (&stat_info->link_name, XFORM_SYMLINK);
       break;
     case SYMTYPE:
       transform_member_name (&stat_info->link_name, XFORM_SYMLINK);
       break;

-      
+

     case LNKTYPE:
       transform_member_name (&stat_info->link_name, XFORM_LINK);
     }
     case LNKTYPE:
       transform_member_name (&stat_info->link_name, XFORM_LINK);
     }


@@ -865,7 +888,7 @@ from_header (char const *where0, size_t digs, char const *type,
   return -1;
 }
 
   return -1;
 }
 

-gid_t
+static gid_t

 gid_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "gid_t",
 gid_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "gid_t",


@@ -874,7 +897,7 @@ gid_from_header (const char *p, size_t s)
                      false, false);
 }
 
                      false, false);
 }
 

-major_t
+static major_t

 major_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "major_t",
 major_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "major_t",


@@ -882,7 +905,7 @@ major_from_header (const char *p, size_t s)
                      (uintmax_t) TYPE_MAXIMUM (major_t), false, false);
 }
 
                      (uintmax_t) TYPE_MAXIMUM (major_t), false, false);
 }
 

-minor_t
+static minor_t

 minor_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "minor_t",
 minor_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "minor_t",


@@ -892,7 +915,7 @@ minor_from_header (const char *p, size_t s)
 
 /* Convert P to the file mode, as understood by tar.
    Store unrecognized mode bits (from 10th up) in HBITS. */
 
 /* Convert P to the file mode, as understood by tar.
    Store unrecognized mode bits (from 10th up) in HBITS. */

-mode_t
+static mode_t

 mode_from_header (const char *p, size_t s, unsigned *hbits)
 {
   unsigned u = from_header (p, s, "mode_t",
 mode_from_header (const char *p, size_t s, unsigned *hbits)
 {
   unsigned u = from_header (p, s, "mode_t",


@@ -930,7 +953,7 @@ size_from_header (const char *p, size_t s)
                      (uintmax_t) TYPE_MAXIMUM (size_t), false, false);
 }
 
                      (uintmax_t) TYPE_MAXIMUM (size_t), false, false);
 }
 

-time_t
+static time_t

 time_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "time_t",
 time_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "time_t",


@@ -938,7 +961,7 @@ time_from_header (const char *p, size_t s)
                      (uintmax_t) TYPE_MAXIMUM (time_t), false, false);
 }
 
                      (uintmax_t) TYPE_MAXIMUM (time_t), false, false);
 }
 

-uid_t
+static uid_t

 uid_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "uid_t",
 uid_from_header (const char *p, size_t s)
 {
   return from_header (p, s, "uid_t",


@@ -1134,7 +1157,7 @@ simple_print_header (struct tar_stat_info *st, union block *blk,
 
       /* Time stamp.  */
 
 
       /* Time stamp.  */
 

-      time_stamp = tartime (st->mtime, false);
+      time_stamp = tartime (st->mtime, full_time_option);

       time_stamp_len = strlen (time_stamp);
       if (datewidth < time_stamp_len)
        datewidth = time_stamp_len;
       time_stamp_len = strlen (time_stamp);
       if (datewidth < time_stamp_len)
        datewidth = time_stamp_len;


@@ -1280,8 +1303,8 @@ simple_print_header (struct tar_stat_info *st, union block *blk,
 }
 
 
 }
 
 

-void
-print_volume_label ()
+static void
+print_volume_label (void)

 {
   struct tar_stat_info vstat;
   union block vblk;
 {
   struct tar_stat_info vstat;
   union block vblk;


@@ -1344,7 +1367,7 @@ skip_file (off_t size)
 {
   union block *x;
 
 {
   union block *x;
 

-  /* FIXME: Make sure mv_begin is always called before it */
+  /* FIXME: Make sure mv_begin_read is always called before it */

 
   if (seekable_archive)
     {
 
   if (seekable_archive)
     {


@@ -1379,7 +1402,7 @@ skip_member (void)
       char save_typeflag = current_header->header.typeflag;
       set_next_block_after (current_header);
 
       char save_typeflag = current_header->header.typeflag;
       set_next_block_after (current_header);
 

-      mv_begin (&current_stat_info);
+      mv_begin_read (&current_stat_info);

 
       if (current_stat_info.is_sparse)
        sparse_skip_file (&current_stat_info);
 
       if (current_stat_info.is_sparse)
        sparse_skip_file (&current_stat_info);


@@ -1397,25 +1420,26 @@ test_archive_label ()
   name_gather ();
 
   open_archive (ACCESS_READ);
   name_gather ();
 
   open_archive (ACCESS_READ);

-  if (read_header (&current_header, &current_stat_info, false)
+  if (read_header (&current_header, &current_stat_info, read_header_auto)

       == HEADER_SUCCESS)
     {
       == HEADER_SUCCESS)
     {

-      char *s = NULL;
-       

       decode_header (current_header,
                     &current_stat_info, &current_format, 0);
       if (current_header->header.typeflag == GNUTYPE_VOLHDR)
        assign_string (&volume_label, current_header->header.name);
 
       decode_header (current_header,
                     &current_stat_info, &current_format, 0);
       if (current_header->header.typeflag == GNUTYPE_VOLHDR)
        assign_string (&volume_label, current_header->header.name);
 

-      if (volume_label
-         && (name_match (volume_label)
-             || (multi_volume_option
-                 && (s = drop_volume_label_suffix (volume_label))
-                 && name_match (s))))
-       if (verbose_option)
-         print_volume_label ();
-      free (s);
+      if (volume_label)
+       {
+         if (verbose_option)
+           print_volume_label ();
+         if (!name_match (volume_label) && multi_volume_option)
+           {
+             char *s = drop_volume_label_suffix (volume_label);
+             name_match (s);
+             free (s);
+           }
+       }

     }
   close_archive ();
     }
   close_archive ();

-  names_notfound ();
+  label_notfound ();

 }
 }