Make transform_rounds work with Argon KDF

[chaz/p5-File-KDBX] / t / kdbx4.t

diff --git a/t/kdbx4.t b/t/kdbx4.t
index 5fee0868d52b195aefc18cfcb3025fc833a901cf..b14ddcf2d4042eb57fb572d3cfbf4359dd8898de 100644 (file)
--- a/t/kdbx4.t
+++ b/t/kdbx4.t
@@ -10,7 +10,7 @@ use TestCommon;
 use File::KDBX;
 use File::KDBX::Constants qw(:version :kdf);
 use Test::Deep;
-use Test::More;
+use Test::More 1.001004_001;
 use boolean qw(:all);
 
 subtest 'Verify Format400' => sub {
@@ -25,20 +25,25 @@ subtest 'Verify Format400' => sub {
         encryption_iv => "3?\207P\233or\220\215h\2240",
         kdf_parameters => {
             "\$UUID" => "\357cm\337\214)DK\221\367\251\244\3\343\n\f",
-            I => 2,
-            M => 1048576,
-            P => 2,
+            I => num(2),
+            M => num(1048576),
+            P => num(2),
             S => "V\254\6m-\206*\260\305\f\0\366\24:4\235\364A\362\346\221\13)}\250\217P\303\303\2\331\245",
-            V => 19,
+            V => num(19),
         },
         master_seed => ";\372y\300yS%\3331\177\231\364u\265Y\361\225\3273h\332R,\22\240a\240\302\271\357\313\23",
     }, 'Extract headers' or diag explain $kdbx->headers;
 
+    is $kdbx->transform_seed,
+        "V\254\6m-\206*\260\305\f\0\366\24:4\235\364A\362\346\221\13)}\250\217P\303\303\2\331\245",
+        'Get the correct transform seed';
+    cmp_ok $kdbx->transform_rounds, '==', 2, 'Get the correct transform rounds';
+
     is $kdbx->meta->{database_name}, 'Format400', 'Extract database name from meta';
     is $kdbx->root->name, 'Format400', 'Extract name of root group';
 
-    my ($entry, @other) = $kdbx->find_entries([\'400', 'title']);
-    is @other, 0, 'Database has one entry';
+    my ($entry, @other) = $kdbx->entries->grep(\'400', 'title')->each;
+    is scalar @other, 0, 'Database has one entry';
 
     is $entry->title, 'Format400', 'Entry is titled';
     is $entry->username, 'Format400', 'Entry has a username set';
@@ -81,9 +86,9 @@ subtest 'KDBX4 upgrade' => sub {
 subtest 'KDBX4.1 upgrade' => sub {
     my $kdbx = File::KDBX->new;
 
-    my $group1 = $kdbx->add_group;
-    my $group2 = $kdbx->add_group;
-    my $entry1 = $kdbx->add_entry;
+    my $group1 = $kdbx->add_group(label => 'One');
+    my $group2 = $kdbx->add_group(label => 'Two');
+    my $entry1 = $kdbx->add_entry(label => 'Meh');
 
     $group1->tags('hi');
     is $kdbx->minimum_version, KDBX_VERSION_4_1, 'Groups with tags requires upgrade';
@@ -111,7 +116,7 @@ subtest 'KDBX4.1 upgrade' => sub {
     is $kdbx->minimum_version, KDBX_VERSION_4_1, 'Icon with name requires upgrade';
     $kdbx->remove_custom_icon($icon_uuid);
     is $kdbx->minimum_version, KDBX_VERSION_3_1, 'Reset upgrade requirement';
-    $icon_uuid = $kdbx->add_custom_icon('data2', last_modification_time => gmtime);
+    $icon_uuid = $kdbx->add_custom_icon('data2', last_modification_time => scalar gmtime);
     is $kdbx->minimum_version, KDBX_VERSION_4_1, 'Icon with modtime requires upgrade';
     $kdbx->remove_custom_icon($icon_uuid);
     is $kdbx->minimum_version, KDBX_VERSION_3_1, 'Reset upgrade requirement';
@@ -132,10 +137,10 @@ sub test_upgrade_master_key_integrity {
     plan tests => $expected_version >= KDBX_VERSION_4_0 ? 6 : 5;
 
     my $kdbx = File::KDBX->new;
-    $kdbx->kdf_parameters(fast_kdf);
-
     is $kdbx->kdf->uuid, KDF_UUID_AES, 'Default KDF is AES';
 
+    $kdbx->kdf_parameters(fast_kdf);
+
     {
         local $_ = $kdbx;
         $modifier->($kdbx);
@@ -205,15 +210,39 @@ subtest 'Custom data' => sub {
     ok isBoolean($kdbx2->public_custom_data->{bool}), 'Boolean is indeed a boolean';
     is $kdbx2->public_custom_data->{bytes}, "\1\2\3\4", 'Store some bytes in public custom data';
 
-    my ($group2) = $kdbx2->find_groups({label => 'Group'});
+    my $group2 = $kdbx2->groups->grep(label => 'Group')->next;
     is_deeply $group2->custom_data_value('str'), '你好', 'Store a string in group custom data';
     is_deeply $group2->custom_data_value('num'), '42', 'Store a number in group custom data';
     is_deeply $group2->custom_data_value('bool'), '1', 'Store a boolean in group custom data';
 
-    my ($entry2) = $kdbx2->find_entries({label => 'Entry'});
+    my $entry2 = $kdbx2->entries->grep(label => 'Entry')->next;
     is_deeply $entry2->custom_data_value('str'), '你好', 'Store a string in entry custom data';
     is_deeply $entry2->custom_data_value('num'), '42', 'Store a number in entry custom data';
     is_deeply $entry2->custom_data_value('bool'), '0', 'Store a boolean in entry custom data';
 };
 
+subtest 'KDF parameters' => sub {
+    my $kdbx = File::KDBX->new;
+    $kdbx->version(KDBX_VERSION_4_0);
+
+    is $kdbx->kdf_parameters->{+KDF_PARAM_UUID}, KDF_UUID_AES, 'Default KDF type is correct';
+    cmp_ok $kdbx->transform_rounds, '==', 100_000, 'Default transform rounds is correct';
+
+    $kdbx->transform_rounds(17);
+    cmp_deeply $kdbx->kdf_parameters, {
+        "\$UUID" => "\311\331\363\232b\212D`\277t\r\b\301\212O\352",
+        R => num(17),
+        S => ignore(),
+    }, 'Set transform rounds for AES KDF';
+
+    $kdbx->kdf_parameters({KDF_PARAM_UUID() => KDF_UUID_ARGON2D});
+    cmp_ok $kdbx->transform_rounds, '==', 10, 'Default Argon2D transform rounds is correct';
+
+    $kdbx->transform_rounds(17);
+    cmp_deeply $kdbx->kdf_parameters, {
+        "\$UUID" => "\357cm\337\214)DK\221\367\251\244\3\343\n\f",
+        I => num(17),
+    }, 'Set transform rounds for Argon KDF';
+};
+
 done_testing;