]> Dogcows Code - chaz/tint2/blobdiff - src/systray/systraybar.c
*fix* wrong XClearArea usage
[chaz/tint2] / src / systray / systraybar.c
index 02ed1b4ed20440b212fe422550be4399a363b210..b92f38b10008cf9176b2880534c0a8fbd489e324 100644 (file)
@@ -25,6 +25,8 @@
 #include <string.h>
 #include <glib.h>
 #include <Imlib2.h>
+#include <X11/extensions/Xdamage.h>
+#include <X11/extensions/Xcomposite.h>
 
 #include "systraybar.h"
 #include "server.h"
@@ -38,12 +40,16 @@ GSList *icons;
 #define SYSTEM_TRAY_CANCEL_MESSAGE  2
 
 // selection window
-Window net_sel_win = None, hint_win = None;
+Window net_sel_win = None;
 
 // freedesktop specification doesn't allow multi systray
 Systraybar systray;
 int refresh_systray;
 int systray_enabled;
+int systray_max_icon_size = 0;
+
+// background pixmap if we render ourselves the icons
+static Pixmap render_background = 0;
 
 
 void init_systray()
@@ -84,12 +90,19 @@ void cleanup_systray()
        systray_enabled = 0;
        systray.area.on_screen = 0;
        free_area(&systray.area);
+       if (render_background) XFreePixmap(server.dsp, render_background);
 }
 
 
 void draw_systray(void *obj, cairo_t *c, int active)
 {
-       // tint2 don't draw systray icons. just the background.
+       if (real_transparency || systray.alpha != 100 || systray.brightness != 0 || systray.saturation != 0) {
+               if (render_background) XFreePixmap(server.dsp, render_background);
+               render_background = XCreatePixmap(server.dsp, server.root_win, systray.area.width, systray.area.height, server.depth);
+               XCopyArea(server.dsp, systray.area.pix.pmap, render_background, server.gc, 0, 0, systray.area.width, systray.area.height, 0, 0);
+       }
+
+               // tint2 don't draw systray icons. just the background.
        refresh_systray = 1;
 }
 
@@ -108,6 +121,8 @@ void resize_systray(void *obj)
        else
                icon_size = sysbar->area.width;
        icon_size = icon_size - (2 * sysbar->area.pix.border.width) - (2 * sysbar->area.paddingy);
+       if (systray_max_icon_size > 0 && icon_size > systray_max_icon_size)
+               icon_size = systray_max_icon_size;
        count = 0;
        for (l = systray.list_icons; l ; l = l->next) {
                if (!((TrayWindow*)l->data)->hide)
@@ -117,7 +132,11 @@ void resize_systray(void *obj)
 
        if (panel_horizontal) {
                if (!count) systray.area.width = 0;
-               else systray.area.width = (2 * systray.area.pix.border.width) + (2 * systray.area.paddingxlr) + (icon_size * count) + ((count-1) * systray.area.paddingx);
+               else {
+                       int icons_per_column = (sysbar->area.height - 2*sysbar->area.pix.border.width - 2*sysbar->area.paddingy + sysbar->area.paddingx) / (icon_size+sysbar->area.paddingx);
+                       int row_count = count / icons_per_column + (count%icons_per_column != 0);
+                       systray.area.width = (2 * systray.area.pix.border.width) + (2 * systray.area.paddingxlr) + (icon_size * row_count) + ((row_count-1) * systray.area.paddingx);
+               }
 
                systray.area.posx = panel->area.width - panel->area.pix.border.width - panel->area.paddingxlr - systray.area.width;
                if (panel->clock.area.on_screen)
@@ -129,7 +148,11 @@ void resize_systray(void *obj)
        }
        else {
                if (!count) systray.area.height = 0;
-               else systray.area.height = (2 * systray.area.pix.border.width) + (2 * systray.area.paddingxlr) + (icon_size * count) + ((count-1) * systray.area.paddingx);
+               else {
+                       int icons_per_row = (sysbar->area.width - 2*sysbar->area.pix.border.width - 2*sysbar->area.paddingy + sysbar->area.paddingx) / (icon_size+sysbar->area.paddingx);
+                       int column_count = count / icons_per_row+ (count%icons_per_row != 0);
+                       systray.area.height = (2 * systray.area.pix.border.width) + (2 * systray.area.paddingxlr) + (icon_size * column_count) + ((column_count-1) * systray.area.paddingx);
+               }
 
                systray.area.posy = panel->area.pix.border.width + panel->area.paddingxlr;
                if (panel->clock.area.on_screen)
@@ -140,14 +163,18 @@ void resize_systray(void *obj)
 #endif
        }
 
+       int max_line_pos;
        if (panel_horizontal) {
+               max_line_pos = sysbar->area.posy+sysbar->area.height - sysbar->area.pix.border.width - sysbar->area.paddingy - icon_size;
                posy = panel->area.pix.border.width + panel->area.paddingy + systray.area.pix.border.width + systray.area.paddingy;
                posx = systray.area.posx + systray.area.pix.border.width + systray.area.paddingxlr;
        }
        else {
+               max_line_pos = sysbar->area.posx+sysbar->area.width - sysbar->area.pix.border.width - sysbar->area.paddingy - icon_size;
                posx = panel->area.pix.border.width + panel->area.paddingy + systray.area.pix.border.width + systray.area.paddingy;
                posy = systray.area.posy + systray.area.pix.border.width + systray.area.paddingxlr;
        }
+
        for (l = systray.list_icons; l ; l = l->next) {
                traywin = (TrayWindow*)l->data;
                if (traywin->hide) continue;
@@ -156,13 +183,26 @@ void resize_systray(void *obj)
                traywin->x = posx;
                traywin->width = icon_size;
                traywin->height = icon_size;
-               if (panel_horizontal)
-                       posx += (icon_size + systray.area.paddingx);
-               else
-                       posy += (icon_size + systray.area.paddingx);
+               if (panel_horizontal) {
+                       if (posy + icon_size + sysbar->area.paddingxlr < max_line_pos)
+                               posy += icon_size + sysbar->area.paddingx;
+                       else {
+                               posx += (icon_size + systray.area.paddingx);
+                               posy = panel->area.pix.border.width + panel->area.paddingy + systray.area.pix.border.width + systray.area.paddingy;
+                       }
+               }
+               else {
+                       if (posx + icon_size + sysbar->area.paddingxlr < max_line_pos)
+                               posx += icon_size + systray.area.paddingx;
+                       else {
+                               posy += (icon_size + systray.area.paddingx);
+                               posx = panel->area.pix.border.width + panel->area.paddingy + systray.area.pix.border.width + systray.area.paddingy;
+                       }
+               }
 
                // position and size the icon window
                XMoveResizeWindow(server.dsp, traywin->id, traywin->x, traywin->y, icon_size, icon_size);
+               XResizeWindow(server.dsp, traywin->tray_id, icon_size, icon_size);
        }
 }
 
@@ -210,7 +250,7 @@ void start_net()
        // init systray protocol
        net_sel_win = XCreateSimpleWindow(server.dsp, server.root_win, -1, -1, 1, 1, 0, 0, 0);
 
-       // v0.2 trayer specification. tint2 always horizontal.
+       // v0.3 trayer specification. tint2 always horizontal.
        // Vertical panel will draw the systray horizontal.
        int orient = 0;
        XChangeProperty(server.dsp, net_sel_win, server.atom._NET_SYSTEM_TRAY_ORIENTATION, XA_CARDINAL, 32, PropModeReplace, (unsigned char *) &orient, 1);
@@ -276,10 +316,10 @@ static gint compare_traywindows(gconstpointer a, gconstpointer b)
        const TrayWindow * traywin_b = (TrayWindow*)b;
        XTextProperty name_a, name_b;
 
-       if(XGetWMName(server.dsp, traywin_a->id, &name_a) == 0) {
+       if(XGetWMName(server.dsp, traywin_a->tray_id, &name_a) == 0) {
                return -1;
        }
-       else if(XGetWMName(server.dsp, traywin_b->id, &name_b) == 0) {
+       else if(XGetWMName(server.dsp, traywin_b->tray_id, &name_b) == 0) {
                XFree(name_a.value);
                return 1;
        }
@@ -300,17 +340,24 @@ gboolean add_icon(Window id)
        int hide = 0;
 
        error = FALSE;
-       old = XSetErrorHandler(window_error_handler);
        XWindowAttributes attr;
        XGetWindowAttributes(server.dsp, id, &attr);
-       if ( attr.depth != server.depth ) {
-               XSetWindowAttributes a;
-               a.background_pixmap = None;  // set to none, otherwise XReparentWindow fails...
-               a.background_pixel = 0;      // set background pixel to 0. Looks ugly, but at least the icon appears
-               // TODO: maybe the XShape extension can be used, to clip the icon
-               XChangeWindowAttributes(server.dsp, id, CWBackPixmap|CWBackPixel, &a);
+       unsigned long mask = 0;
+       XSetWindowAttributes set_attr;
+       if (attr.depth != server.depth || systray.alpha != 100 || systray.brightness != 0 || systray.saturation != 0 ) {
+               set_attr.colormap = attr.colormap;
+               set_attr.background_pixel = 0;
+               set_attr.border_pixel = 0;
+               mask = CWColormap|CWBackPixel|CWBorderPixel;
        }
-       XReparentWindow(server.dsp, id, panel->main_win, 0, 0);
+       else {
+               set_attr.background_pixmap = ParentRelative;
+               mask = CWBackPixmap;
+       }
+       Window parent_window;
+       parent_window = XCreateWindow(server.dsp, panel->main_win, 0, 0, 30, 30, 0, attr.depth, InputOutput, attr.visual, mask, &set_attr);
+       old = XSetErrorHandler(window_error_handler);
+       XReparentWindow(server.dsp, id, parent_window, 0, 0);
        XSync(server.dsp, False);
        XSetErrorHandler(old);
        if (error != FALSE) {
@@ -351,14 +398,17 @@ gboolean add_icon(Window id)
                e.xclient.data.l[0] = CurrentTime;
                e.xclient.data.l[1] = XEMBED_EMBEDDED_NOTIFY;
                e.xclient.data.l[2] = 0;
-               e.xclient.data.l[3] = panel->main_win;
+               e.xclient.data.l[3] = parent_window;
                e.xclient.data.l[4] = 0;
                XSendEvent(server.dsp, id, False, 0xFFFFFF, &e);
        }
 
        traywin = g_new0(TrayWindow, 1);
-       traywin->id = id;
+       traywin->id = parent_window;
+       traywin->tray_id = id;
        traywin->hide = hide;
+       traywin->depth = attr.depth;
+       traywin->damage = 0;
 
        if (systray.sort == 3)
                systray.list_icons = g_slist_prepend(systray.list_icons, traywin);
@@ -371,11 +421,17 @@ gboolean add_icon(Window id)
        //printf("add_icon id %lx, %d\n", id, g_slist_length(systray.list_icons));
 
        // watch for the icon trying to resize itself!
-       XSelectInput(server.dsp, traywin->id, StructureNotifyMask);
+       XSelectInput(server.dsp, traywin->tray_id, StructureNotifyMask);
+       if (real_transparency || systray.alpha != 100 || systray.brightness != 0 || systray.saturation != 0) {
+               traywin->damage = XDamageCreate(server.dsp, traywin->id, XDamageReportNonEmpty);
+               XCompositeRedirectWindow(server.dsp, traywin->id, CompositeRedirectManual);
+       }
 
        // show the window
-       if (!traywin->hide)
+       if (!traywin->hide) {
+               XMapRaised(server.dsp, traywin->tray_id);
                XMapRaised(server.dsp, traywin->id);
+       }
 
        // changed in systray force resize on panel
        panel->area.resize = 1;
@@ -394,14 +450,17 @@ void remove_icon(TrayWindow *traywin)
        systray.area.redraw = 1;
        //printf("remove_icon id %lx, %d\n", traywin->id);
 
-       XSelectInput(server.dsp, traywin->id, NoEventMask);
+       XSelectInput(server.dsp, traywin->tray_id, NoEventMask);
+       if (traywin->damage)
+               XDamageDestroy(server.dsp, traywin->damage);
 
        // reparent to root
        error = FALSE;
        old = XSetErrorHandler(window_error_handler);
        if (!traywin->hide)
                XUnmapWindow(server.dsp, traywin->id);
-       XReparentWindow(server.dsp, traywin->id, server.root_win, 0, 0);
+       XReparentWindow(server.dsp, traywin->tray_id, server.root_win, 0, 0);
+       XDestroyWindow(server.dsp, traywin->id);
        XSync(server.dsp, False);
        XSetErrorHandler(old);
        g_free(traywin);
@@ -439,6 +498,52 @@ void net_message(XClientMessageEvent *e)
        }
 }
 
+void systray_render_icon_now(void* t)
+{
+       TrayWindow* traywin = t;
+       traywin->render_timeout = 0;
+
+       // good systray icons support 32 bit depth, but some icons are still 24 bit.
+       // We create a heuristic mask for these icons, i.e. we get the rgb value in the top left corner, and
+       // mask out all pixel with the same rgb value
+       Panel* panel = systray.area.panel;
+       imlib_context_set_drawable(traywin->id);
+       Imlib_Image image = imlib_create_image_from_drawable(0, 0, 0, traywin->width, traywin->height, 0);
+       if (image == 0)
+               return;
+
+       imlib_context_set_image(image);
+       imlib_image_set_has_alpha(1);
+       DATA32* data = imlib_image_get_data();
+       if (traywin->depth == 24) {
+               createHeuristicMask(data, traywin->width, traywin->height);
+       }
+       if (systray.alpha != 100 || systray.brightness != 0 || systray.saturation != 0)
+               adjust_asb(data, traywin->width, traywin->height, systray.alpha, (float)systray.saturation/100, (float)systray.brightness/100);
+       imlib_image_put_back_data(data);
+       XCopyArea(server.dsp, render_background, systray.area.pix.pmap, server.gc, traywin->x-systray.area.posx, traywin->y-systray.area.posy, traywin->width, traywin->height, traywin->x-systray.area.posx, traywin->y-systray.area.posy);
+       if ( !real_transparency ) {
+               imlib_context_set_drawable(systray.area.pix.pmap);
+               imlib_render_image_on_drawable(traywin->x-systray.area.posx, traywin->y-systray.area.posy);
+       }
+       else {
+               render_image(systray.area.pix.pmap, traywin->x-systray.area.posx, traywin->y-systray.area.posy, traywin->width, traywin->height);
+       }
+       XCopyArea(server.dsp, systray.area.pix.pmap, panel->main_win, server.gc, traywin->x-systray.area.posx, traywin->y-systray.area.posy, traywin->width, traywin->height, traywin->x, traywin->y);
+       imlib_free_image_and_decache();
+
+       XDamageSubtract(server.dsp, traywin->damage, None, None);
+       XFlush(server.dsp);
+}
+
+
+void systray_render_icon(TrayWindow* traywin)
+{
+       // wine tray icons update whenever mouse is over them, so we limit the updates to 50 ms
+       if (traywin->render_timeout == 0)
+               traywin->render_timeout = add_timeout(50, 0, systray_render_icon_now, traywin);
+}
+
 
 void refresh_systray_icon()
 {
@@ -447,8 +552,9 @@ void refresh_systray_icon()
        for (l = systray.list_icons; l ; l = l->next) {
                traywin = (TrayWindow*)l->data;
                if (traywin->hide) continue;
-               XClearArea(server.dsp, traywin->id, 0, 0, traywin->width, traywin->height, True);
+               if (real_transparency || systray.alpha != 100 || systray.brightness != 0 || systray.saturation != 0)
+                       systray_render_icon(traywin);
+               else
+                       XClearArea(server.dsp, traywin->tray_id, 0, 0, traywin->width, traywin->height, True);
        }
 }
-
-
This page took 0.031065 seconds and 4 git commands to generate.