NULL ic when we failed to load an image

[chaz/openbox] / openbox / menu.c

diff --git a/openbox/menu.c b/openbox/menu.c
index 524220c0af14325eb691924ff1ea640928d44bf6..6dd6d072d797ccb59548e29eb43f8fc0ec754840 100644 (file)
--- a/openbox/menu.c
+++ b/openbox/menu.c
@@ -299,8 +299,10 @@ static void parse_menu_item(xmlNodePtr node,  gpointer data)
                     RrImageRef(ic);
                 else {
                     ic = RrImageNew(ob_rr_icons);
-                    if (!RrImageAddPictureName(ic, icon))
+                    if (!RrImageAddPictureName(ic, icon)) {
                         RrImageUnref(ic); /* no need to keep it around */
+                        ic = NULL;
+                    }
                 }
                 e->data.normal.icon = ic;