more using g_slice_new() instead of g_new()

[chaz/openbox] / openbox / actions / layer.c

diff --git a/openbox/actions/layer.c b/openbox/actions/layer.c
index 4a1cf651901d6023d3e3c745e9409b1f8cbea804..ed1eeedc0462c26ed22557edbeb39ef028b4c61e 100644 (file)
--- a/openbox/actions/layer.c
+++ b/openbox/actions/layer.c
@@ -6,49 +6,58 @@ typedef struct {
     gboolean toggle;
 } Options;
 
-static gpointer setup_func_top(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node);
-static gpointer setup_func_bottom(ObParseInst *i, xmlDocPtr doc,
-                                  xmlNodePtr node);
-static gpointer setup_func_send(ObParseInst *i, xmlDocPtr doc,
-                                xmlNodePtr node);
+static gpointer setup_func_top(xmlNodePtr node);
+static gpointer setup_func_bottom(xmlNodePtr node);
+static gpointer setup_func_send(xmlNodePtr node);
+static void free_func(gpointer o);
 static gboolean run_func(ObActionsData *data, gpointer options);
+/* 3.4-compatibility */
+static gpointer setup_sendtop_func(xmlNodePtr node);
+static gpointer setup_sendbottom_func(xmlNodePtr node);
+static gpointer setup_sendnormal_func(xmlNodePtr node);
 
-void action_layer_startup()
+void action_layer_startup(void)
 {
-    actions_register("ToggleAlwaysOnTop", setup_func_top, g_free,
-                     run_func_toggle, NULL, NULL);
-    actions_register("ToggleAlwaysOnBottom", setup_func_bottom, g_free,
-                     run_func_toggle, NULL, NULL);
-    actions_register("SendToLayer", setup_func_send, g_free,
-                     run_func_send, NULL, NULL);
+    actions_register("ToggleAlwaysOnTop", setup_func_top, free_func,
+                     run_func);
+    actions_register("ToggleAlwaysOnBottom", setup_func_bottom, free_func,
+                     run_func);
+    actions_register("SendToLayer", setup_func_send, free_func,
+                     run_func);
+    /* 3.4-compatibility */
+    actions_register("SendToTopLayer", setup_sendtop_func, free_func,
+                     run_func);
+    actions_register("SendToBottomLayer", setup_sendbottom_func, free_func,
+                     run_func);
+    actions_register("SendToNormalLayer", setup_sendnormal_func, free_func,
+                     run_func);
 }
 
-static gpointer setup_func_top(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node)
+static gpointer setup_func_top(xmlNodePtr node)
 {
-    Options *o = g_new0(Options, 1);
+    Options *o = g_slice_new0(Options);
     o->layer = 1;
+    o->toggle = TRUE;
     return o;
 }
 
-static gpointer setup_func_bottom(ObParseInst *i, xmlDocPtr doc,
-                                  xmlNodePtr node)
+static gpointer setup_func_bottom(xmlNodePtr node)
 {
-    Options *o = g_new0(Options, 1);
+    Options *o = g_slice_new0(Options);
     o->layer = -1;
+    o->toggle = TRUE;
     return o;
 }
 
-static gpointer setup_func_send(ObParseInst *i, xmlDocPtr doc,
-                                xmlNodePtr node)
+static gpointer setup_func_send(xmlNodePtr node)
 {
     xmlNodePtr n;
     Options *o;
 
-    o = g_new0(Options, 1);
-    o->toggle = TRUE;
+    o = g_slice_new0(Options);
 
-    if ((n = parse_find_node("layer", node))) {
-        gchar *s = parse_string(doc, n);
+    if ((n = obt_xml_find_node(node, "layer"))) {
+        gchar *s = obt_xml_node_string(n);
         if (!g_ascii_strcasecmp(s, "above") ||
             !g_ascii_strcasecmp(s, "top"))
             o->layer = 1;
@@ -64,6 +73,11 @@ static gpointer setup_func_send(ObParseInst *i, xmlDocPtr doc,
     return o;
 }
 
+static void free_func(gpointer o)
+{
+    g_slice_free(Options, o);
+}
+
 /* Always return FALSE because its not interactive */
 static gboolean run_func(ObActionsData *data, gpointer options)
 {
@@ -90,3 +104,29 @@ static gboolean run_func(ObActionsData *data, gpointer options)
 
     return FALSE;
 }
+
+/* 3.4-compatibility */
+static gpointer setup_sendtop_func(xmlNodePtr node)
+{
+    Options *o = g_slice_new0(Options);
+    o->layer = 1;
+    o->toggle = FALSE;
+    return o;
+}
+
+static gpointer setup_sendbottom_func(xmlNodePtr node)
+{
+    Options *o = g_slice_new0(Options);
+    o->layer = -1;
+    o->toggle = FALSE;
+    return o;
+}
+
+static gpointer setup_sendnormal_func(xmlNodePtr node)
+{
+    Options *o = g_slice_new0(Options);
+    o->layer = 0;
+    o->toggle = FALSE;
+    return o;
+}
+