#include <stdio.h>
#endif
+typedef void (*ObtDDParseGroupFunc)(const gchar *group,
+ GHashTable *key_hash);
+
+typedef struct _ObtDDParseGroup {
+ gchar *name;
+ gboolean seen;
+ ObtDDParseGroupFunc func;
+ /* the key is a string (a key in the .desktop).
+ the value is a strings (a value in the .desktop) */
+ GHashTable *key_hash;
+} ObtDDParseGroup;
+
typedef struct _ObtDDParse {
gchar *filename;
gulong lineno;
+ ObtDDParseGroup *group;
+ /* the key is a group name, the value is a ObtDDParseGroup */
+ GHashTable *group_hash;
} ObtDDParse;
typedef enum {
} d;
};
+static void group_free(ObtDDParseGroup *g)
+{
+ g_free(g->name);
+ g_hash_table_destroy(g->key_hash);
+ g_slice_free(ObtDDParseGroup, g);
+}
+
+/* Displays a warning message including the file name and line number, and
+ sets the boolean @error to true if it points to a non-NULL address.
+*/
static void parse_error(const gchar *m, const ObtDDParse *const parse,
gboolean *error)
{
if (!parse->filename)
- g_warning("%s at line %lu of input\n", m, parse->lineno);
+ g_warning("%s at line %lu of input", m, parse->lineno);
else
- g_warning("%s at line %lu of file %s\n",
+ g_warning("%s at line %lu of file %s",
m, parse->lineno, parse->filename);
if (error) *error = TRUE;
}
if (!locale) {
end = in + bytes;
for (i = in; i < end; ++i) {
- if (*i > 127) {
+ if ((guchar)*i > 126 || (guchar)*i < 32) {
+ /* non-control character ascii */
end = i;
parse_error("Invalid bytes in string", parse, error);
break;
}
else if (*i == '\\')
backslash = TRUE;
+ else if ((guchar)*i >= 127 || (guchar)*i < 32) {
+ /* avoid ascii control characters */
+ parse_error("Found control character in string", parse, error);
+ break;
+ }
else {
memcpy(o, i, next-i);
o += next-i;
return *read > 0;
}
+static void parse_group(const gchar *buf, gulong len,
+ ObtDDParse *parse, gboolean *error)
+{
+ ObtDDParseGroup *g;
+ gchar *group;
+ gulong i;
+
+ /* get the group name */
+ group = g_strndup(buf+1, len-2);
+ for (i = 0; i < len-2; ++i)
+ if ((guchar)group[i] < 32 || (guchar)group[i] >= 127) {
+ /* valid ASCII only */
+ parse_error("Invalid character found", parse, NULL);
+ group[i] = '\0'; /* stopping before this character */
+ break;
+ }
+
+ /* make sure it's a new group */
+ g = g_hash_table_lookup(parse->group_hash, group);
+ if (g && g->seen) {
+ parse_error("Duplicate group found", parse, error);
+ g_free(group);
+ return;
+ }
+ /* if it's the first group, make sure it's named Desktop Entry */
+ else if (!parse->group && strcmp(group, "Desktop Entry") != 0)
+ {
+ parse_error("Incorrect group found, "
+ "expected [Desktop Entry]",
+ parse, error);
+ g_free(group);
+ return;
+ }
+ else {
+ if (!g) {
+ g = g_slice_new(ObtDDParseGroup);
+ g->name = group;
+ g->func = NULL;
+ g->key_hash = g_hash_table_new_full(g_str_hash, g_str_equal,
+ g_free, g_free);
+ g_hash_table_insert(parse->group_hash, group, g);
+ }
+ else
+ g_free(group);
+
+ g->seen = TRUE;
+ parse->group = g;
+ g_print("Found group %s\n", g->name);
+ }
+}
+
+static void parse_key_value(const gchar *buf, gulong len,
+ ObtDDParse *parse, gboolean *error)
+{
+ gulong i, keyend, valstart, eq;
+ char *key, *val;
+
+ /* find the end of the key */
+ for (i = 0; i < len; ++i)
+ if (!(((guchar)buf[i] >= 'A' && (guchar)buf[i] <= 'Z') ||
+ ((guchar)buf[i] >= 'a' && (guchar)buf[i] <= 'z') ||
+ ((guchar)buf[i] >= '0' && (guchar)buf[i] <= '9') ||
+ ((guchar)buf[i] == '-'))) {
+ /* not part of the key */
+ keyend = i;
+ break;
+ }
+ if (keyend < 1) {
+ parse_error("Empty key", parse, error);
+ return;
+ }
+ /* find the = character */
+ for (i = keyend; i < len; ++i) {
+ if (buf[i] == '=') {
+ eq = i;
+ break;
+ }
+ else if (buf[i] != ' ') {
+ parse_error("Invalid character in key name", parse, error);
+ return ;
+ }
+ }
+ if (i == len) {
+ parse_error("Key without value found", parse, error);
+ return;
+ }
+ /* find the start of the value */
+ for (i = eq+1; i < len; ++i)
+ if (buf[i] != ' ') {
+ valstart = i;
+ break;
+ }
+ if (i == len) {
+ parse_error("Empty value found", parse, error);
+ return;
+ }
+
+ key = g_strndup(buf, keyend);
+ val = g_strndup(buf+valstart, len-valstart);
+ if (g_hash_table_lookup(parse->group->key_hash, key)) {
+ parse_error("Duplicate key found", parse, error);
+ g_free(key);
+ g_free(val);
+ return;
+ }
+ g_hash_table_insert(parse->group->key_hash, key, val);
+ g_print("Found key/value %s=%s.\n", key, val);
+}
+
static gboolean parse_file(ObtDDFile *dd, FILE *f, ObtDDParse *parse)
{
gchar *buf = NULL;
gulong bytes = 0, read = 0;
gboolean error = FALSE;
- while (parse_file_line(f, &buf, &bytes, &read, parse, &error)) {
+ while (!error && parse_file_line(f, &buf, &bytes, &read, parse, &error)) {
/* XXX use the string in buf */
+ gulong len = strlen(buf);
+ if (buf[0] == '#' || buf[0] == '\0')
+ ; /* ignore comment lines */
+ else if (buf[0] == '[' && buf[len-1] == ']')
+ parse_group(buf, len, parse, &error);
+ else if (!parse->group)
+ /* just ignore keys outside of groups */
+ parse_error("Key found before group", parse, NULL);
+ else
+ /* ignore errors in key-value pairs and continue */
+ parse_key_value(buf, len, parse, NULL);
++parse->lineno;
}
ObtDDParse parse;
GSList *it;
FILE *f;
+ gboolean success;
dd = g_slice_new(ObtDDFile);
dd->ref = 1;
- f = NULL;
- for (it = paths; it && !f; it = g_slist_next(it)) {
+ parse.filename = NULL;
+ parse.lineno = 0;
+ parse.group = NULL;
+ parse.group_hash = g_hash_table_new_full(g_str_hash,
+ g_str_equal,
+ NULL,
+ (GDestroyNotify)group_free);
+
+ success = FALSE;
+ for (it = paths; it && !success; it = g_slist_next(it)) {
gchar *path = g_strdup_printf("%s/%s", (char*)it->data, name);
if ((f = fopen(path, "r"))) {
parse.filename = path;
- parse.lineno = 0;
- if (!parse_file(dd, f, &parse)) f = NULL;
+ parse.lineno = 1;
+ success = parse_file(dd, f, &parse);
+ fclose(f);
}
+ g_free(path);
}
- if (!f) {
+ if (!success) {
obt_ddfile_unref(dd);
dd = NULL;
}
+
+ g_hash_table_destroy(parse.group_hash);
+
return dd;
}
projects / chaz / openbox / blobdiff