dont pass an unused parameter, and return an unused value

diff --git a/src/Window.cc b/src/Window.cc
index 835cbdecad764b3031696b084e0aa6c96424f346..b129121c50b59e03f75bd7343222c64bf41007dd 100644 (file)
--- a/src/Window.cc
+++ b/src/Window.cc
@@ -3065,7 +3065,6 @@ void BlackboxWindow::doMove(int x_root, int y_root) {
   assert(flags.moving);
   assert(blackbox->getChangingWindow() == this);
 
-  bool warp = False;
   int dx = x_root - frame.grab_x, dy = y_root - frame.grab_y;
   dx -= frame.border_w;
   dy -= frame.border_w;
@@ -3074,7 +3073,7 @@ void BlackboxWindow::doMove(int x_root, int y_root) {
 
   if (screen->doOpaqueMove()) {
     if (screen->doWorkspaceWarping())
-      warp = doWorkspaceWarping(x_root, y_root, dx, dy);
+      doWorkspaceWarping(x_root, y_root, dx);
 
     configure(dx, dy, frame.rect.width(), frame.rect.height());
   } else {
@@ -3086,7 +3085,7 @@ void BlackboxWindow::doMove(int x_root, int y_root) {
                    frame.changing.height() - 1);
 
     if (screen->doWorkspaceWarping())
-      warp = doWorkspaceWarping(x_root, y_root, dx, dy);
+      doWorkspaceWarping(x_root, y_root, dx);
 
     frame.changing.setPos(dx, dy);
 
@@ -3102,8 +3101,7 @@ void BlackboxWindow::doMove(int x_root, int y_root) {
 }
 
 
-bool BlackboxWindow::doWorkspaceWarping(int x_root, int y_root,
-                                        int &dx, int dy) {
+void BlackboxWindow::doWorkspaceWarping(int x_root, int y_root, int &dx) {
   // workspace warping
   bool warp = False;
   unsigned int dest = screen->getCurrentWorkspaceID();
@@ -3120,7 +3118,7 @@ bool BlackboxWindow::doWorkspaceWarping(int x_root, int y_root,
     else dest = 0;
   }
   if (! warp)
-    return False;
+    return;
 
   bool focus = flags.focused; // had focus while moving?
 
@@ -3133,11 +3131,6 @@ bool BlackboxWindow::doWorkspaceWarping(int x_root, int y_root,
     dx -= screen->getRect().width() - 1;
   }
 
-  /*
-     We grab the X server here so that we dont end up magically grabbing
-     a different window dring the warp.
-  */
-
   if (! flags.stuck)
     screen->reassociateWindow(this, dest, False);
   screen->changeWorkspaceID(dest);
@@ -3154,7 +3147,6 @@ bool BlackboxWindow::doWorkspaceWarping(int x_root, int y_root,
   if (focus)
     setInputFocus();
 
-  return True;
 }
 
 

diff --git a/src/Window.hh b/src/Window.hh
index 727f1006378bcfc0b19864602342a78ab4c8c52b..02c15bcbf480cbd788fd4f5f4ddccbd262e6f16d 100644 (file)
--- a/src/Window.hh
+++ b/src/Window.hh
@@ -296,7 +296,7 @@ private:
   void setState(unsigned long new_state);
   void upsize(void);
   void doMove(int x_root, int y_root);
-  bool doWorkspaceWarping(int x_root, int y_root, int &dx, int dy);
+  void doWorkspaceWarping(int x_root, int y_root, int &dx);
   void doWindowSnapping(int &dx, int &dy);
   void endMove(void);
   void doResize(int x_root, int y_root);