Let ObPrompts be modal dialogs, and when they are transient for a window, make it...

diff --git a/openbox/client.c b/openbox/client.c
index 9fa311cfbdb1fce62123c416284cabe45b527cb6..32daf6637dcbfc69c8c43afcf796592e455dd4c6 100644 (file)
--- a/openbox/client.c
+++ b/openbox/client.c
@@ -3442,7 +3442,7 @@ static void client_prompt_kill(ObClient *self)
         g_free(m);
     }
 
-    prompt_show(self->kill_prompt, self);
+    prompt_show(self->kill_prompt, self, TRUE);
 }
 
 void client_kill(ObClient *self)

diff --git a/openbox/prompt.c b/openbox/prompt.c
index 84fe2d0d8dcd0cb00979237dceb461747413126a..d3a1ab7bee0c7327f1c8b094f3f5a16d3edc4367 100644 (file)
--- a/openbox/prompt.c
+++ b/openbox/prompt.c
@@ -21,6 +21,7 @@
 #include "screen.h"
 #include "openbox.h"
 #include "client.h"
+#include "group.h"
 #include "prop.h"
 #include "modkeys.h"
 #include "event.h"
@@ -435,7 +436,7 @@ static void render_all(ObPrompt *self)
         render_button(self, &self->button[i]);
 }
 
-void prompt_show(ObPrompt *self, ObClient *parent)
+void prompt_show(ObPrompt *self, ObClient *parent, gboolean modal)
 {
     gint i;
 
@@ -457,8 +458,33 @@ void prompt_show(ObPrompt *self, ObClient *parent)
             break;
         }
 
-    XSetTransientForHint(ob_display, self->super.window,
-                         (parent ? parent->window : 0));
+    if (parent) {
+        Atom states[1];
+        gint nstates;
+        Window p;
+        XWMHints h;
+
+        if (parent->group) {
+            /* make it transient for the window's group */
+            h.flags = WindowGroupHint;
+            h.window_group = parent->group->leader;
+            p = RootWindow(ob_display, ob_screen);
+        }
+        else {
+            /* make it transient for the window directly */
+            h.flags = 0;
+            p = parent->window;
+        }
+
+        XSetWMHints(ob_display, self->super.window, &h);
+        PROP_SET32(self->super.window, wm_transient_for, window, p);
+
+        states[0] = prop_atoms.net_wm_state_modal;
+        nstates = (modal ? 1 : 0);
+        PROP_SETA32(self->super.window, net_wm_state, atom, states, nstates);
+    }
+    else
+        PROP_ERASE(self->super.window, wm_transient_for);
 
     /* set up the dialog and render it */
     prompt_layout(self);

diff --git a/openbox/prompt.h b/openbox/prompt.h
index c24f044898eaca684757195e15b881dacaaf5620..89d3d598d8bf5334967e0fe4614756c433e38f69 100644 (file)
--- a/openbox/prompt.h
+++ b/openbox/prompt.h
@@ -100,7 +100,7 @@ void prompt_ref(ObPrompt *self);
 void prompt_unref(ObPrompt *self);
 
 /*! Show the prompt.  It will be centered within the given area rectangle */
-void prompt_show(ObPrompt *self, struct _ObClient *parent);
+void prompt_show(ObPrompt *self, struct _ObClient *parent, gboolean modal);
 void prompt_hide(ObPrompt *self);
 
 gboolean prompt_key_event(ObPrompt *self, XEvent *e);

diff --git a/openbox/prop.c b/openbox/prop.c
index 695e441fea9f206bd7f3f69e4fa0ac13918e27b0..5dc4a2fa87e1dab4eb3c45697818a63163cc5bca 100644 (file)
--- a/openbox/prop.c
+++ b/openbox/prop.c
@@ -51,6 +51,7 @@ void prop_startup(void)
     CREATE(wm_client_machine, "WM_CLIENT_MACHINE");
     CREATE(wm_command, "WM_COMMAND");
     CREATE(wm_client_leader, "WM_CLIENT_LEADER");
+    CREATE(wm_transient_for, "WM_TRANSIENT_FOR");
     CREATE(motif_wm_hints, "_MOTIF_WM_HINTS");
 
     CREATE(sm_client_id, "SM_CLIENT_ID");

diff --git a/openbox/prop.h b/openbox/prop.h
index ae423271f6bb68f77733b104ed9c8918da159530..46c930177e0bccef8743bc5f2b30f2a86576ba32 100644 (file)
--- a/openbox/prop.h
+++ b/openbox/prop.h
@@ -53,6 +53,7 @@ typedef struct Atoms {
     Atom wm_client_machine;
     Atom wm_command;
     Atom wm_client_leader;
+    Atom wm_transient_for;
     Atom motif_wm_hints;
 
     /* SM atoms */