]> Dogcows Code - chaz/openbox/blobdiff - src/openbox.cc
fixed memory leaks for strftime_format and rootcommand
[chaz/openbox] / src / openbox.cc
index ffbe166c83f47aaee3516262cd28d9753103cb95..d048837875b1a0107c9d374d970cb60a2ac833c0 100644 (file)
@@ -55,6 +55,7 @@
 #include "Window.h"
 #include "Workspace.h"
 #include "Workspacemenu.h"
+#include "Util.h"
 
 #include <string>
 #include <algorithm>
 #  include <stdio.h>
 #endif // HAVE_STDIO_H
 
-#ifdef    STDC_HEADERS
+#ifdef    HAVE_STDLIB_H
 #  include <stdlib.h>
+#endif // HAVE_STDLIB_H
+
+#ifdef    HAVE_STRING_H
 #  include <string.h>
-#endif // STDC_HEADERS
+#endif // HAVE_STRING_H
 
 #ifdef    HAVE_UNISTD_H
 #  include <sys/types.h>
@@ -197,8 +201,7 @@ Openbox::Openbox(int m_argc, char **m_argv, char *dpy_name, char *rc)
 
   menuTimestamps = new LinkedList<MenuTimestamp>;
 
-  XrmInitialize();
-  load_rc();
+  load();
 
 #ifdef    HAVE_GETPID
   openbox_pid = XInternAtom(getXDisplay(), "_BLACKBOX_PID", False);
@@ -206,7 +209,7 @@ Openbox::Openbox(int m_argc, char **m_argv, char *dpy_name, char *rc)
 
   screenList = new LinkedList<BScreen>;
   for (int i = 0; i < getNumberOfScreens(); i++) {
-    BScreen *screen = new BScreen(this, i);
+    BScreen *screen = new BScreen(*this, i, config);
 
     if (! screen->isScreenManaged()) {
       delete screen;
@@ -223,12 +226,15 @@ Openbox::Openbox(int m_argc, char **m_argv, char *dpy_name, char *rc)
     ::exit(3);
   }
 
+  // save current settings and default values
+  save();
+  
   XSynchronize(getXDisplay(), False);
   XSync(getXDisplay(), False);
 
   reconfigure_wait = reread_menu_wait = False;
 
-  timer = new BTimer(this, this);
+  timer = new BTimer(*this, *this);
   timer->setTimeout(0);
   timer->fireOnce(True);
 
@@ -236,7 +242,7 @@ Openbox::Openbox(int m_argc, char **m_argv, char *dpy_name, char *rc)
 }
 
 
-Openbox::~Openbox(void) {
+Openbox::~Openbox() {
   while (screenList->count())
     delete screenList->remove(0);
 
@@ -255,6 +261,9 @@ Openbox::~Openbox(void) {
   if (resource.style_file)
     delete [] resource.style_file;
 
+  if (resource.titlebar_layout)
+    delete [] resource.titlebar_layout;
+
   delete timer;
 
   delete screenList;
@@ -337,14 +346,14 @@ void Openbox::process_event(XEvent *e) {
            if (my < 0) my = 0;
 
            if (mx + screen->getWorkspacemenu()->getWidth() >
-               screen->getWidth())
-             mx = screen->getWidth() -
+               screen->size().w())
+             mx = screen->size().w() -
                screen->getWorkspacemenu()->getWidth() -
                screen->getBorderWidth();
 
            if (my + screen->getWorkspacemenu()->getHeight() >
-               screen->getHeight())
-             my = screen->getHeight() -
+               screen->size().h())
+             my = screen->size().h() -
                screen->getWorkspacemenu()->getHeight() -
                screen->getBorderWidth();
 
@@ -363,13 +372,13 @@ void Openbox::process_event(XEvent *e) {
            if (mx < 0) mx = 0;
            if (my < 0) my = 0;
 
-           if (mx + screen->getRootmenu()->getWidth() > screen->getWidth())
-             mx = screen->getWidth() -
+           if (mx + screen->getRootmenu()->getWidth() > screen->size().w())
+             mx = screen->size().w() -
                screen->getRootmenu()->getWidth() -
                screen->getBorderWidth();
 
-           if (my + screen->getRootmenu()->getHeight() > screen->getHeight())
-               my = screen->getHeight() -
+           if (my + screen->getRootmenu()->getHeight() > screen->size().h())
+               my = screen->size().h() -
                  screen->getRootmenu()->getHeight() -
                  screen->getBorderWidth();
 
@@ -380,15 +389,16 @@ void Openbox::process_event(XEvent *e) {
              screen->getRootmenu()->show();
            }
           } else if (e->xbutton.button == 4) {
-            if ((screen->getCurrentWorkspaceID()-1)<0)
-              screen->changeWorkspaceID(screen->getCount()-1);
+            if ((screen->getCurrentWorkspaceID() + 1) >
+                screen->getWorkspaceCount() - 1)
+              screen->changeWorkspaceID(0);
             else
-              screen->changeWorkspaceID(screen->getCurrentWorkspaceID()-1);
+              screen->changeWorkspaceID(screen->getCurrentWorkspaceID() + 1);
           } else if (e->xbutton.button == 5) {
-            if ((screen->getCurrentWorkspaceID()+1)>screen->getCount()-1)
-              screen->changeWorkspaceID(0);
+            if ((screen->getCurrentWorkspaceID() - 1) < 0)
+              screen->changeWorkspaceID(screen->getWorkspaceCount() - 1);
             else
-              screen->changeWorkspaceID(screen->getCurrentWorkspaceID()+1);
+              screen->changeWorkspaceID(screen->getCurrentWorkspaceID() - 1);
           }
         }
       }
@@ -467,7 +477,7 @@ void Openbox::process_event(XEvent *e) {
     OpenboxWindow *win = searchWindow(e->xmaprequest.window);
 
     if (! win)
-      win = new OpenboxWindow(this, e->xmaprequest.window);
+      win = new OpenboxWindow(*this, e->xmaprequest.window);
 
     if ((win = searchWindow(e->xmaprequest.window)))
       win->mapRequestEvent(&e->xmaprequest);
@@ -579,7 +589,7 @@ void Openbox::process_event(XEvent *e) {
        (screen = searchScreen(e->xcrossing.window))) {
       screen->getImageControl()->installRootColormap();
     } else if ((win = searchWindow(e->xcrossing.window))) {
-      if (win->getScreen()->isSloppyFocus() &&
+      if (win->getScreen()->sloppyFocus() &&
          (! win->isFocused()) && (! no_focus)) {
        grab();
 
@@ -688,7 +698,7 @@ void Openbox::process_event(XEvent *e) {
        BScreen *screen = searchScreen(e->xclient.window);
 
        if (screen && e->xclient.data.l[0] >= 0 &&
-           e->xclient.data.l[0] < screen->getCount())
+           e->xclient.data.l[0] < screen->getWorkspaceCount())
          screen->changeWorkspaceID(e->xclient.data.l[0]);
       } else if (e->xclient.message_type == getOpenboxChangeWindowFocusAtom()) {
        OpenboxWindow *win = searchWindow(e->xclient.window);
@@ -744,11 +754,8 @@ void Openbox::process_event(XEvent *e) {
 Bool Openbox::handleSignal(int sig) {
   switch (sig) {
   case SIGHUP:
-    reconfigure();
-    break;
-
   case SIGUSR1:
-    reload_rc();
+    reconfigure();
     break;
 
   case SIGUSR2:
@@ -953,7 +960,7 @@ void Openbox::restart(const char *prog) {
 }
 
 
-void Openbox::shutdown(void) {
+void Openbox::shutdown() {
   BaseDisplay::shutdown();
 
   XSetInputFocus(getXDisplay(), PointerRoot, None, CurrentTime);
@@ -963,249 +970,41 @@ void Openbox::shutdown(void) {
     s->shutdown();
 
   XSync(getXDisplay(), False);
-
-  save_rc();
 }
 
 
-void Openbox::save_rc(void) {
-  XrmDatabase new_openboxrc = (XrmDatabase) 0;
-  char rc_string[1024];
-
-  load_rc();
-
-  sprintf(rc_string, "session.menuFile:  %s", resource.menu_file);
-  XrmPutLineResource(&new_openboxrc, rc_string);
-
-  sprintf(rc_string, "session.colorsPerChannel:  %d",
-          resource.colors_per_channel);
-  XrmPutLineResource(&new_openboxrc, rc_string);
-
-  sprintf(rc_string, "session.titlebarLayout:  %s",
-          resource.titlebar_layout);
-  XrmPutLineResource(&new_openboxrc, rc_string);
-
-  sprintf(rc_string, "session.doubleClickInterval:  %lu",
-          resource.double_click_interval);
-  XrmPutLineResource(&new_openboxrc, rc_string);
-
-  sprintf(rc_string, "session.autoRaiseDelay:  %lu",
+void Openbox::save() {
+  config.setAutoSave(false);
+  
+  // save all values as they are so that the defaults will be written to the rc
+  // file
+  
+  config.setValue("session.menuFile", getMenuFilename());
+  config.setValue("session.colorsPerChannel",
+                  resource.colors_per_channel);
+  config.setValue("session.doubleClickInterval",
+                  (long)resource.double_click_interval);
+  config.setValue("session.autoRaiseDelay",
           ((resource.auto_raise_delay.tv_sec * 1000) +
            (resource.auto_raise_delay.tv_usec / 1000)));
-  XrmPutLineResource(&new_openboxrc, rc_string);
-
-  sprintf(rc_string, "session.cacheLife: %lu", resource.cache_life / 60000);
-  XrmPutLineResource(&new_openboxrc, rc_string);
-
-  sprintf(rc_string, "session.cacheMax: %lu", resource.cache_max);
-  XrmPutLineResource(&new_openboxrc, rc_string);
+  config.setValue("session.cacheLife", (long)resource.cache_life / 60000);
+  config.setValue("session.cacheMax", (long)resource.cache_max);
+  config.setValue("session.styleFile", resource.style_file);
 
   LinkedListIterator<BScreen> it(screenList);
-  for (BScreen *screen = it.current(); screen; it++, screen = it.current()) {
-    int screen_number = screen->getScreenNumber();
-
-#ifdef    SLIT
-    char *slit_placement = (char *) 0;
-
-    switch (screen->getSlitPlacement()) {
-    case Slit::TopLeft: slit_placement = "TopLeft"; break;
-    case Slit::CenterLeft: slit_placement = "CenterLeft"; break;
-    case Slit::BottomLeft: slit_placement = "BottomLeft"; break;
-    case Slit::TopCenter: slit_placement = "TopCenter"; break;
-    case Slit::BottomCenter: slit_placement = "BottomCenter"; break;
-    case Slit::TopRight: slit_placement = "TopRight"; break;
-    case Slit::BottomRight: slit_placement = "BottomRight"; break;
-    case Slit::CenterRight: default: slit_placement = "CenterRight"; break;
-    }
-
-    sprintf(rc_string, "session.screen%d.slit.placement: %s", screen_number,
-           slit_placement);
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.slit.direction: %s", screen_number,
-            ((screen->getSlitDirection() == Slit::Horizontal) ? "Horizontal" :
-                                                                "Vertical"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    const char *rootcmd;
-    if ((rootcmd = screen->getRootCommand()) != NULL) {
-      sprintf(rc_string, "session.screen%d.rootCommand: %s", screen_number,
-              rootcmd);
-      XrmPutLineResource(&new_openboxrc, rc_string);
-    }
-
-    sprintf(rc_string, "session.screen%d.slit.onTop: %s", screen_number,
-            ((screen->getSlit()->isOnTop()) ? "True" : "False"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.slit.autoHide: %s", screen_number,
-            ((screen->getSlit()->doAutoHide()) ? "True" : "False"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-#endif // SLIT
-
-    sprintf(rc_string, "session.opaqueMove: %s",
-           ((screen->doOpaqueMove()) ? "True" : "False"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.imageDither: %s",
-           ((screen->getImageControl()->doDither()) ? "True" : "False"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.fullMaximization: %s", screen_number,
-           ((screen->doFullMax()) ? "True" : "False"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.focusNewWindows: %s", screen_number,
-            ((screen->doFocusNew()) ? "True" : "False"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.focusLastWindow: %s", screen_number,
-           ((screen->doFocusLast()) ? "True" : "False"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.rowPlacementDirection: %s",
-           screen_number,
-           ((screen->getRowPlacementDirection() == BScreen::LeftRight) ?
-            "LeftToRight" : "RightToLeft"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.colPlacementDirection: %s",
-           screen_number,
-           ((screen->getColPlacementDirection() == BScreen::TopBottom) ?
-            "TopToBottom" : "BottomToTop"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    char *placement = (char *) 0;
-    switch (screen->getPlacementPolicy()) {
-    case BScreen::CascadePlacement:
-      placement = "CascadePlacement";
-      break;
-
-    case BScreen::ColSmartPlacement:
-      placement = "ColSmartPlacement";
-      break;
-
-    case BScreen::RowSmartPlacement:
-    default:
-      placement = "RowSmartPlacement";
-      break;
-    }
-    sprintf(rc_string, "session.screen%d.windowPlacement:  %s", screen_number,
-           placement);
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.windowZones:  %i", screen_number,
-           screen->getWindowZones());
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.focusModel:  %s", screen_number,
-           ((screen->isSloppyFocus()) ?
-            ((screen->doAutoRaise()) ? "AutoRaiseSloppyFocus" :
-             "SloppyFocus") :
-            "ClickToFocus"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.workspaces:  %d", screen_number,
-           screen->getCount());
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.toolbar.onTop:  %s", screen_number,
-           ((screen->getToolbar()->isOnTop()) ? "True" : "False"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.toolbar.autoHide:  %s", screen_number,
-           ((screen->getToolbar()->doAutoHide()) ? "True" : "False"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    char *toolbar_placement = (char *) 0;
-
-    switch (screen->getToolbarPlacement()) {
-    case Toolbar::TopLeft: toolbar_placement = "TopLeft"; break;
-    case Toolbar::BottomLeft: toolbar_placement = "BottomLeft"; break;
-    case Toolbar::TopCenter: toolbar_placement = "TopCenter"; break;
-    case Toolbar::TopRight: toolbar_placement = "TopRight"; break;
-    case Toolbar::BottomRight: toolbar_placement = "BottomRight"; break;
-    case Toolbar::BottomCenter: default:
-      toolbar_placement = "BottomCenter"; break;
-    }
-
-    sprintf(rc_string, "session.screen%d.toolbar.placement: %s", screen_number,
-            toolbar_placement);
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    load_rc(screen);
-
-    // these are static, but may not be saved in the users .openbox/rc,
-    // writing these resources will allow the user to edit them at a later
-    // time... but loading the defaults before saving allows us to rewrite the
-    // users changes...
-
-#ifdef    HAVE_STRFTIME
-    sprintf(rc_string, "session.screen%d.strftimeFormat: %s", screen_number,
-           screen->getStrftimeFormat());
-    XrmPutLineResource(&new_openboxrc, rc_string);
-#else // !HAVE_STRFTIME
-    sprintf(rc_string, "session.screen%d.dateFormat:  %s", screen_number,
-           ((screen->getDateFormat() == B_EuropeanDate) ?
-            "European" : "American"));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.clockFormat:  %d", screen_number,
-           ((screen->isClock24Hour()) ? 24 : 12));
-    XrmPutLineResource(&new_openboxrc, rc_string);
-#endif // HAVE_STRFTIME
-
-    sprintf(rc_string, "session.screen%d.edgeSnapThreshold: %d", screen_number,
-           screen->getEdgeSnapThreshold());
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    sprintf(rc_string, "session.screen%d.toolbar.widthPercent:  %d",
-            screen_number, screen->getToolbarWidthPercent());
-    XrmPutLineResource(&new_openboxrc, rc_string);
-
-    // write out the users workspace names
-    int i, len = 0;
-    for (i = 0; i < screen->getCount(); i++)
-      len += strlen((screen->getWorkspace(i)->getName()) ?
-                   screen->getWorkspace(i)->getName() : "Null") + 1;
-
-    char *resource_string = new char[len + 1024],
-      *save_string = new char[len], *save_string_pos = save_string,
-      *name_string_pos;
-    if (save_string) {
-      for (i = 0; i < screen->getCount(); i++) {
-       len = strlen((screen->getWorkspace(i)->getName()) ?
-                    screen->getWorkspace(i)->getName() : "Null") + 1;
-       name_string_pos =
-         (char *) ((screen->getWorkspace(i)->getName()) ?
-                   screen->getWorkspace(i)->getName() : "Null");
-
-       while (--len) *(save_string_pos++) = *(name_string_pos++);
-       *(save_string_pos++) = ',';
-      }
-    }
-
-    *(--save_string_pos) = '\0';
-
-    sprintf(resource_string, "session.screen%d.workspaceNames:  %s",
-           screen_number, save_string);
-    XrmPutLineResource(&new_openboxrc, resource_string);
-
-    delete [] resource_string;
-    delete [] save_string;
+  for (BScreen *s = it.current(); s != NULL; it++, s = it.current()) {
+    s->save();
+    s->getToolbar()->save();
+    s->getSlit()->save();
   }
 
-  XrmDatabase old_openboxrc = XrmGetFileDatabase(rc_file);
-
-  XrmMergeDatabases(new_openboxrc, &old_openboxrc);
-  XrmPutFileDatabase(old_openboxrc, rc_file);
-  XrmDestroyDatabase(old_openboxrc);
+  config.setAutoSave(true);
+  config.save();
 }
 
-
-void Openbox::load_rc(void) {
+void Openbox::load() {
   if (!config.load())
-    return;
+    config.create();
 
   std::string s;
   long l;
@@ -1265,301 +1064,18 @@ void Openbox::load_rc(void) {
 }
 
 
-void Openbox::load_rc(BScreen *screen) {
-  assert (screen != NULL);
-  const int screen_number = screen->getScreenNumber();
-  assert (screen_number >= 0);
-
-  if (!config.load())
-    return;
-
-  std::string s;
-  long l;
-  bool b;
-  char name_lookup[1024], class_lookup[1024];
-   
-  sprintf(name_lookup,  "session.screen%d.fullMaximization", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.FullMaximization", screen_number);
-  if (config.getValue(name_lookup, class_lookup, b))
-    screen->saveFullMax((Bool)b);
-  else
-    screen->saveFullMax(False);
-
-  sprintf(name_lookup,  "session.screen%d.focusNewWindows", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.FocusNewWindows", screen_number);
-  if (config.getValue(name_lookup, class_lookup, b))
-    screen->saveFocusNew((Bool)b);
-  else
-    screen->saveFocusNew(False);
-  
-  sprintf(name_lookup,  "session.screen%d.focusLastWindow", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.focusLastWindow", screen_number);
-  if (config.getValue(name_lookup, class_lookup, b))
-    screen->saveFocusLast((Bool)b);
-  else
-    screen->saveFocusLast(False);
-  
-  sprintf(name_lookup,  "session.screen%d.rowPlacementDirection",
-          screen_number);
-  sprintf(class_lookup, "Session.Screen%d.RowPlacementDirection",
-         screen_number);
-  if (config.getValue(name_lookup, class_lookup, s)) {
-    if (0 == strncasecmp(s.c_str(), "righttoleft", s.length()))
-      screen->saveRowPlacementDirection(BScreen::RightLeft);
-    else
-      screen->saveRowPlacementDirection(BScreen::LeftRight);
-  } else
-    screen->saveRowPlacementDirection(BScreen::LeftRight);
-  
-  sprintf(name_lookup,  "session.screen%d.colPlacementDirection",
-         screen_number);
-  sprintf(class_lookup, "Session.Screen%d.ColPlacementDirection",
-         screen_number);
-  if (config.getValue(name_lookup, class_lookup, s)) {
-    if (0 == strncasecmp(s.c_str(), "bottomtotop", s.length()))
-      screen->saveColPlacementDirection(BScreen::BottomTop);
-    else
-      screen->saveColPlacementDirection(BScreen::TopBottom);
-  } else
-    screen->saveColPlacementDirection(BScreen::TopBottom);
-
-  sprintf(name_lookup,  "session.screen%d.workspaces", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.Workspaces", screen_number);
-  if (config.getValue(name_lookup, class_lookup, l))
-    screen->saveWorkspaces(l);
-  else
-    screen->saveWorkspaces(1);
-  
-  sprintf(name_lookup,  "session.screen%d.toolbar.widthPercent",
-          screen_number);
-  sprintf(class_lookup, "Session.Screen%d.Toolbar.WidthPercent",
-          screen_number);
-  if (config.getValue(name_lookup, class_lookup, l) && (l > 0 && l <= 100))
-    screen->saveToolbarWidthPercent(l);
-  else
-    screen->saveToolbarWidthPercent(66);
-
-  sprintf(name_lookup, "session.screen%d.toolbar.placement", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.Toolbar.Placement", screen_number);
-  if (config.getValue(name_lookup, class_lookup, s)) {
-    if (0 == strncasecmp(s.c_str(), "TopLeft", s.length()))
-      screen->saveToolbarPlacement(Toolbar::TopLeft);
-    else if (0 == strncasecmp(s.c_str(), "BottomLeft", s.length()))
-      screen->saveToolbarPlacement(Toolbar::BottomLeft);
-    else if (0 == strncasecmp(s.c_str(), "TopCenter", s.length()))
-      screen->saveToolbarPlacement(Toolbar::TopCenter);
-    else if (0 == strncasecmp(s.c_str(), "TopRight", s.length()))
-      screen->saveToolbarPlacement(Toolbar::TopRight);
-    else if ( 0 == strncasecmp(s.c_str(), "BottomRight", s.length()))
-      screen->saveToolbarPlacement(Toolbar::BottomRight);
-    else
-      screen->saveToolbarPlacement(Toolbar::BottomCenter);
-  } else
-    screen->saveToolbarPlacement(Toolbar::BottomCenter);
-
-  screen->removeWorkspaceNames();
-  sprintf(name_lookup,  "session.screen%d.workspaceNames", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.WorkspaceNames", screen_number);
-  if (config.getValue(name_lookup, class_lookup, s)) {
-  //  for (int i = 0; i < screen->getNumberOfWorkspaces(); i++) {
-    std::string::const_iterator it = s.begin(), end = s.end();
-    while(1) {
-      std::string::const_iterator tmp = it;// current string.begin()
-      it = std::find(tmp, end, ',');       // look for comma between tmp and end
-      std::string name(tmp, it);           // name = s[tmp:it]
-      screen->addWorkspaceName(name.c_str());
-      if (it == end)
-        break;
-      ++it;
-    }
-  }
-
-  sprintf(name_lookup,  "session.screen%d.toolbar.onTop", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.Toolbar.OnTop", screen_number);
-  if (config.getValue(name_lookup, class_lookup, b))
-    screen->saveToolbarOnTop((Bool)b);
-  else
-    screen->saveToolbarOnTop(False);
-
-  sprintf(name_lookup,  "session.screen%d.toolbar.autoHide", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.Toolbar.autoHide", screen_number);
-  if (config.getValue(name_lookup, class_lookup, b))
-    screen->saveToolbarAutoHide((Bool)b);
-  else
-    screen->saveToolbarAutoHide(False);
-
-  sprintf(name_lookup,  "session.screen%d.focusModel", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.FocusModel", screen_number);
-  if (config.getValue(name_lookup, class_lookup, s)) {
-    if (0 == strncasecmp(s.c_str(), "clicktofocus", s.length())) {
-      screen->saveAutoRaise(False);
-      screen->saveSloppyFocus(False);
-    } else if (0 == strncasecmp(s.c_str(), "autoraisesloppyfocus",
-                                s.length())) {
-      screen->saveSloppyFocus(True);
-      screen->saveAutoRaise(True);
-    } else {
-      screen->saveSloppyFocus(True);
-      screen->saveAutoRaise(False);
-    }
-  } else {
-    screen->saveSloppyFocus(True);
-    screen->saveAutoRaise(False);
-  }
-
-  sprintf(name_lookup,  "session.screen%d.windowZones", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.WindowZones", screen_number);
-  if (config.getValue(name_lookup, class_lookup, l))
-    screen->saveWindowZones((l == 1 || l == 2 || l == 4) ? l : 1);
-  else
-    screen->saveWindowZones(1);
-  
-  sprintf(name_lookup,  "session.screen%d.windowPlacement", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.WindowPlacement", screen_number);
-  if (config.getValue(name_lookup, class_lookup, s)) {
-    if (0 == strncasecmp(s.c_str(), "RowSmartPlacement", s.length()))
-      screen->savePlacementPolicy(BScreen::RowSmartPlacement);
-    else if (0 == strncasecmp(s.c_str(), "ColSmartPlacement", s.length()))
-      screen->savePlacementPolicy(BScreen::ColSmartPlacement);
-    else
-      screen->savePlacementPolicy(BScreen::CascadePlacement);
-  } else
-    screen->savePlacementPolicy(BScreen::RowSmartPlacement);
-
-#ifdef    SLIT
-  sprintf(name_lookup, "session.screen%d.slit.placement", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.Slit.Placement", screen_number);
-  if (config.getValue(name_lookup, class_lookup, s)) {
-    if (0 == strncasecmp(s.c_str(), "TopLeft", s.length()))
-      screen->saveSlitPlacement(Slit::TopLeft);
-    else if (0 == strncasecmp(s.c_str(), "CenterLeft", s.length()))
-      screen->saveSlitPlacement(Slit::CenterLeft);
-    else if (0 == strncasecmp(s.c_str(), "BottomLeft", s.length()))
-      screen->saveSlitPlacement(Slit::BottomLeft);
-    else if (0 == strncasecmp(s.c_str(), "TopCenter", s.length()))
-      screen->saveSlitPlacement(Slit::TopCenter);
-    else if (0 == strncasecmp(s.c_str(), "BottomCenter", s.length()))
-      screen->saveSlitPlacement(Slit::BottomCenter);
-    else if (0 == strncasecmp(s.c_str(), "TopRight", s.length()))
-      screen->saveSlitPlacement(Slit::TopRight);
-    else if (0 == strncasecmp(s.c_str(), "BottomRight", s.length()))
-      screen->saveSlitPlacement(Slit::BottomRight);
-    else
-      screen->saveSlitPlacement(Slit::CenterRight);
-  } else
-    screen->saveSlitPlacement(Slit::CenterRight);
-
-  sprintf(name_lookup, "session.screen%d.slit.direction", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.Slit.Direction", screen_number);
-  if (config.getValue(name_lookup, class_lookup, s)) {
-    if (0 == strncasecmp(s.c_str(), "Horizontal", s.length()))
-      screen->saveSlitDirection(Slit::Horizontal);
-    else
-      screen->saveSlitDirection(Slit::Vertical);
-  } else
-    screen->saveSlitDirection(Slit::Vertical);
-  
-  sprintf(name_lookup, "session.screen%d.slit.onTop", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.Slit.OnTop", screen_number);
-  if (config.getValue(name_lookup, class_lookup, b))
-    screen->saveSlitOnTop((Bool)b);
-  else
-    screen->saveSlitOnTop(False);
-
-  sprintf(name_lookup, "session.screen%d.slit.autoHide", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.Slit.AutoHide", screen_number);
-  if (config.getValue(name_lookup, class_lookup, b))
-    screen->saveSlitAutoHide((Bool)b);
-  else
-    screen->saveSlitAutoHide(False);
-#endif // SLIT
-
-#ifdef    HAVE_STRFTIME
-  sprintf(name_lookup,  "session.screen%d.strftimeFormat", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.StrftimeFormat", screen_number);
-  if (config.getValue(name_lookup, class_lookup, s))
-    screen->saveStrftimeFormat(s.c_str());
-  else
-    screen->saveStrftimeFormat("%I:%M %p");
-
-#else //  HAVE_STRFTIME
-  sprintf(name_lookup,  "session.screen%d.dateFormat", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.DateFormat", screen_number);
-  if (config.getValue(name_lookup, class_lookup, s)) {
-    if (strncasecmp(s.c_str(), "european", s.length()))
-      screen->saveDateFormat(B_AmericanDate);
-    else
-      screen->saveDateFormat(B_EuropeanDate);
-  } else
-    screen->saveDateFormat(B_AmericanDate);
-
-  sprintf(name_lookup,  "session.screen%d.clockFormat", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.ClockFormat", screen_number);
-  if (config.getValue(name_lookup, class_lookup, l)) {
-    if (clock == 24)
-      screen->saveClock24Hour(True);
-    else
-      screen->saveClock24Hour(False);
-  } else
-    screen->saveClock24Hour(False);
-#endif // HAVE_STRFTIME
-
-  sprintf(name_lookup,  "session.screen%d.edgeSnapThreshold", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.EdgeSnapThreshold", screen_number);
-  if (config.getValue(name_lookup, class_lookup, l))
-    screen->saveEdgeSnapThreshold(l);
-  else
-    screen->saveEdgeSnapThreshold(4);
-
-  sprintf(name_lookup,  "session.screen%d.imageDither", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.ImageDither", screen_number);
-  if (config.getValue("session.imageDither", "Session.ImageDither", b))
-    screen->saveImageDither((Bool)b);
-  else
-    screen->saveImageDither(True);
-
-  sprintf(name_lookup, "session.screen%d.rootCommand", screen_number);
-  sprintf(class_lookup, "Session.Screen%d.RootCommand", screen_number);
-  if (config.getValue(name_lookup, class_lookup, s))
-    screen->saveRootCommand(s.c_str());
-  else
-    screen->saveRootCommand(NULL);
-
-  if (config.getValue("session.opaqueMove", "Session.OpaqueMove", b))
-    screen->saveOpaqueMove((Bool)b);
-  else
-    screen->saveOpaqueMove(False);
-}
-
-
-void Openbox::reload_rc(void) {
-  load_rc();
-  reconfigure();
-}
-
-
-void Openbox::reconfigure(void) {
+void Openbox::reconfigure() {
   reconfigure_wait = True;
 
   if (! timer->isTiming()) timer->start();
 }
 
 
-void Openbox::real_reconfigure(void) {
+void Openbox::real_reconfigure() {
   grab();
 
-  XrmDatabase new_openboxrc = (XrmDatabase) 0;
-  char style[MAXPATHLEN + 64];
-
-  sprintf(style, "session.styleFile: %s", resource.style_file);
-  XrmPutLineResource(&new_openboxrc, style);
-
-  XrmDatabase old_openboxrc = XrmGetFileDatabase(rc_file);
-
-  XrmMergeDatabases(new_openboxrc, &old_openboxrc);
-  XrmPutFileDatabase(old_openboxrc, rc_file);
-  if (old_openboxrc) XrmDestroyDatabase(old_openboxrc);
-
+  load();
+  
   for (int i = 0, n = menuTimestamps->count(); i < n; i++) {
     MenuTimestamp *ts = menuTimestamps->remove(0);
 
@@ -1580,7 +1096,7 @@ void Openbox::real_reconfigure(void) {
 }
 
 
-void Openbox::checkMenu(void) {
+void Openbox::checkMenu() {
   Bool reread = False;
   LinkedListIterator<MenuTimestamp> it(menuTimestamps);
   for (MenuTimestamp *tmp = it.current(); tmp && (! reread);
@@ -1599,14 +1115,14 @@ void Openbox::checkMenu(void) {
 }
 
 
-void Openbox::rereadMenu(void) {
+void Openbox::rereadMenu() {
   reread_menu_wait = True;
 
   if (! timer->isTiming()) timer->start();
 }
 
 
-void Openbox::real_rereadMenu(void) {
+void Openbox::real_rereadMenu() {
   for (int i = 0, n = menuTimestamps->count(); i < n; i++) {
     MenuTimestamp *ts = menuTimestamps->remove(0);
 
@@ -1624,15 +1140,16 @@ void Openbox::real_rereadMenu(void) {
 }
 
 
-void Openbox::saveStyleFilename(const char *filename) {
+void Openbox::setStyleFilename(const char *filename) {
   if (resource.style_file)
     delete [] resource.style_file;
 
   resource.style_file = bstrdup(filename);
+  config.setValue("session.styleFile", resource.style_file);
 }
 
 
-void Openbox::saveMenuFilename(const char *filename) {
+void Openbox::setMenuFilename(const char *filename) {
   Bool found = False;
 
   LinkedListIterator<MenuTimestamp> it(menuTimestamps);
@@ -1655,7 +1172,7 @@ void Openbox::saveMenuFilename(const char *filename) {
 }
 
 
-void Openbox::timeout(void) {
+void Openbox::timeout() {
   if (reconfigure_wait)
     real_reconfigure();
 
This page took 0.03726 seconds and 4 git commands to generate.