// reparent the client to the frame
XReparentWindow(otk::OBDisplay::display, _client->window(),
_plate.window(), 0, 0);
- // this generates 2 unmap's that we catch, one to the window and one to root,
- // but both have .window set to this window, so both need to be ignored
- _client->ignore_unmaps+=2;
+ /*
+ When reparenting the client window, it is usually not mapped yet, since
+ this occurs from a MapRequest. However, in the case where Openbox is
+ starting up, the window is already mapped, so we'll see unmap events for
+ it. There are 2 unmap events generated that we see, one with the 'event'
+ member set the root window, and one set to the client, but both get handled
+ and need to be ignored.
+ */
+ if (Openbox::instance->state() == Openbox::State_Starting)
+ _client->ignore_unmaps += 2;
// select the event mask on the client's parent (to receive config req's)
XSelectInput(otk::OBDisplay::display, _plate.window(),
XEvent ev;
if (XCheckTypedWindowEvent(otk::OBDisplay::display, _client->window(),
ReparentNotify, &ev)) {
- // XXX: ob2/bb didn't do this.. look up this process in other wm's!
- XPutBackEvent(otk::OBDisplay::display, &ev);
+ /*
+ If the app reparented itself, then we unmanage the window. This causes
+ the window to be unmapped, so to be nice to it, we remap the window
+ here. We don't put the event back onto the stack because we put it there
+ in the first place.
+ */
+ XMapWindow(otk::OBDisplay::display, _client->window());
} else {
// according to the ICCCM - if the client doesn't reparent to
// root, then we have to do it for them
}
// do an extra map here .. ? XXX
- XMapWindow(otk::OBDisplay::display, _client->window());
+// XMapWindow(otk::OBDisplay::display, _client->window());
}