]> Dogcows Code - chaz/openbox/blobdiff - src/Workspace.cc
BScreen (ScreenInfo) now contains a size() instead of a getWidth/getHeight
[chaz/openbox] / src / Workspace.cc
index c31b3efaa02b6dd9502de838461467fc22b242cd..0d996632689a699099b6716054e188687067c267 100644 (file)
@@ -43,6 +43,7 @@
 #include "Workspace.h"
 #include "Windowmenu.h"
 #include "Geometry.h"
+#include "Util.h"
 
 #ifdef    HAVE_STDIO_H
 #  include <stdio.h>
@@ -59,8 +60,7 @@
 #include <vector>
 typedef vector<Rect> rectList;
 
-Workspace::Workspace(BScreen *scrn, int i) {
-  screen = scrn;
+Workspace::Workspace(BScreen &scrn, int i) : screen(scrn) {
 
   cascade_x = cascade_y = 32;
 
@@ -68,12 +68,12 @@ Workspace::Workspace(BScreen *scrn, int i) {
 
   stackingList = new LinkedList<OpenboxWindow>;
   windowList = new LinkedList<OpenboxWindow>;
-  clientmenu = new Clientmenu(this);
+  clientmenu = new Clientmenu(*this);
 
   lastfocus = (OpenboxWindow *) 0;
 
   name = (char *) 0;
-  char *tmp = screen->getNameOfWorkspace(id);
+  char *tmp = screen.getNameOfWorkspace(id);
   setName(tmp);
 }
 
@@ -102,7 +102,7 @@ const int Workspace::addWindow(OpenboxWindow *w, Bool place) {
   clientmenu->insert((const char **) w->getTitle());
   clientmenu->update();
 
-  screen->updateNetizenWindowAdd(w->getClientWindow(), id);
+  screen.updateNetizenWindowAdd(w->getClientWindow(), id);
 
   raiseWindow(w);
 
@@ -119,14 +119,14 @@ const int Workspace::removeWindow(OpenboxWindow *w) {
     if (w->isTransient() && w->getTransientFor() &&
        w->getTransientFor()->isVisible()) {
       w->getTransientFor()->setInputFocus();
-    } else if (screen->isSloppyFocus()) {
-      screen->getOpenbox()->setFocusedWindow((OpenboxWindow *) 0);
+    } else if (screen.isSloppyFocus()) {
+      screen.getOpenbox().setFocusedWindow((OpenboxWindow *) 0);
     } else {
       OpenboxWindow *top = stackingList->first();
       if (! top || ! top->setInputFocus()) {
-       screen->getOpenbox()->setFocusedWindow((OpenboxWindow *) 0);
-       XSetInputFocus(screen->getOpenbox()->getXDisplay(),
-                      screen->getToolbar()->getWindowID(),
+       screen.getOpenbox().setFocusedWindow((OpenboxWindow *) 0);
+       XSetInputFocus(screen.getOpenbox().getXDisplay(),
+                      screen.getToolbar()->getWindowID(),
                       RevertToParent, CurrentTime);
       }
     }
@@ -139,7 +139,7 @@ const int Workspace::removeWindow(OpenboxWindow *w) {
   clientmenu->remove(w->getWindowNumber());
   clientmenu->update();
 
-  screen->updateNetizenWindowDel(w->getClientWindow());
+  screen.updateNetizenWindowDel(w->getClientWindow());
 
   LinkedListIterator<OpenboxWindow> it(windowList);
   OpenboxWindow *bw = it.current();
@@ -198,10 +198,10 @@ void Workspace::raiseWindow(OpenboxWindow *w) {
   win = bottom;
   while (True) {
     *(curr++) = win->getFrameWindow();
-    screen->updateNetizenWindowRaise(win->getClientWindow());
+    screen.updateNetizenWindowRaise(win->getClientWindow());
 
     if (! win->isIconic()) {
-      wkspc = screen->getWorkspace(win->getWorkspaceNumber());
+      wkspc = screen.getWorkspace(win->getWorkspaceNumber());
       wkspc->stackingList->remove(win);
       wkspc->stackingList->insert(win, 0);
     }
@@ -212,7 +212,7 @@ void Workspace::raiseWindow(OpenboxWindow *w) {
     win = win->getTransient();
   }
 
-  screen->raiseWindows(nstack, i);
+  screen.raiseWindows(nstack, i);
 
   delete [] nstack;
 }
@@ -237,10 +237,10 @@ void Workspace::lowerWindow(OpenboxWindow *w) {
 
   while (True) {
     *(curr++) = win->getFrameWindow();
-    screen->updateNetizenWindowLower(win->getClientWindow());
+    screen.updateNetizenWindowLower(win->getClientWindow());
 
     if (! win->isIconic()) {
-      wkspc = screen->getWorkspace(win->getWorkspaceNumber());
+      wkspc = screen.getWorkspace(win->getWorkspaceNumber());
       wkspc->stackingList->remove(win);
       wkspc->stackingList->insert(win);
     }
@@ -251,12 +251,12 @@ void Workspace::lowerWindow(OpenboxWindow *w) {
     win = win->getTransientFor();
   }
 
-  screen->getOpenbox()->grab();
+  screen.getOpenbox().grab();
 
-  XLowerWindow(screen->getBaseDisplay()->getXDisplay(), *nstack);
-  XRestackWindows(screen->getBaseDisplay()->getXDisplay(), nstack, i);
+  XLowerWindow(screen.getBaseDisplay().getXDisplay(), *nstack);
+  XRestackWindows(screen.getBaseDisplay().getXDisplay(), nstack, i);
 
-  screen->getOpenbox()->ungrab();
+  screen.getOpenbox().ungrab();
 
   delete [] nstack;
 }
@@ -288,12 +288,12 @@ const int Workspace::getCount(void) {
 
 void Workspace::update(void) {
   clientmenu->update();
-  screen->getToolbar()->redrawWindowLabel(True);
+  screen.getToolbar()->redrawWindowLabel(True);
 }
 
 
 Bool Workspace::isCurrent(void) {
-  return (id == screen->getCurrentWorkspaceID());
+  return (id == screen.getCurrentWorkspaceID());
 }
 
 
@@ -302,7 +302,7 @@ Bool Workspace::isLastWindow(OpenboxWindow *w) {
 }
 
 void Workspace::setCurrent(void) {
-  screen->changeWorkspaceID(id);
+  screen.changeWorkspaceID(id);
 }
 
 
@@ -334,33 +334,33 @@ static rectList calcSpace(const OpenboxWindow &win, const rectList &spaces) {
   rectList result;
   rectList::const_iterator siter;
   for(siter=spaces.begin(); siter!=spaces.end(); ++siter) {
-    if(win.getArea().Intersect(*siter)) {
+    if(win.area().Intersect(*siter)) {
       //Check for space to the left of the window
-      if(win.getXFrame() > siter->x())
+      if(win.origin().x() > siter->x())
         result.push_back(Rect(siter->x(), siter->y(),
-                              win.getXFrame() - siter->x() - 1,
+                              win.origin().x() - siter->x() - 1,
                               siter->h()));
       //Check for space above the window
-      if(win.getYFrame() > siter->y())
+      if(win.origin().y() > siter->y())
         result.push_back(Rect(siter->x(), siter->y(),
                               siter->w(),
-                              win.getYFrame() - siter->y() - 1));
+                              win.origin().y() - siter->y() - 1));
       //Check for space to the right of the window
-      if((win.getXFrame()+win.getWidth()) <
+      if((win.origin().x()+win.size().w()) <
          (siter->x()+siter->w()))
-        result.push_back(Rect(win.getXFrame() + win.getWidth() + 1,
+        result.push_back(Rect(win.origin().x() + win.size().w() + 1,
                               siter->y(),
                               siter->x() + siter->w() -
-                              win.getXFrame() - win.getWidth() - 1,
+                              win.origin().x() - win.size().w() - 1,
                               siter->h()));
       //Check for space below the window
-      if((win.getYFrame()+win.getHeight()) <
+      if((win.origin().y()+win.size().h()) <
          (siter->y()+siter->h()))
         result.push_back(Rect(siter->x(),
-                              win.getYFrame() + win.getHeight() + 1,
+                              win.origin().y() + win.size().h() + 1,
                               siter->w(),
                               siter->y() + siter->h()-
-                              win.getYFrame() - win.getHeight() - 1));
+                              win.origin().y() - win.size().h() - 1));
 
     }
     else
@@ -405,97 +405,95 @@ inline Point *Workspace::rowSmartPlacement(const Size &win_size,
   int test_x, test_y, place_x = 0, place_y = 0;
   int start_pos = 0;
   int change_y =
-     ((screen->getColPlacementDirection() == BScreen::TopBottom) ? 1 : -1);
+     ((screen.getColPlacementDirection() == BScreen::TopBottom) ? 1 : -1);
   int change_x =
-     ((screen->getRowPlacementDirection() == BScreen::LeftRight) ? 1 : -1);
+     ((screen.getRowPlacementDirection() == BScreen::LeftRight) ? 1 : -1);
   int delta_x = 8, delta_y = 8;
   LinkedListIterator<OpenboxWindow> it(windowList);
 
-  test_y = (screen->getColPlacementDirection() == BScreen::TopBottom) ?
-    start_pos : screen->getHeight() - win_size.h() - start_pos;
+  test_y = (screen.getColPlacementDirection() == BScreen::TopBottom) ?
+    start_pos : screen.size().h() - win_size.h() - start_pos;
 
   while(!placed &&
-        ((screen->getColPlacementDirection() == BScreen::BottomTop) ?
+        ((screen.getColPlacementDirection() == BScreen::BottomTop) ?
          test_y > 0 : test_y + win_size.h() < (signed) space.h())) {
-     test_x = (screen->getRowPlacementDirection() == BScreen::LeftRight) ?
-              start_pos : space.w() - win_size.w() - start_pos;
-     while (!placed &&
-            ((screen->getRowPlacementDirection() == BScreen::RightLeft) ?
-             test_x > 0 : test_x + win_size.w() < (signed) space.w())) {
-        placed = true;
-    
-        it.reset();
-        for (OpenboxWindow *curr = it.current(); placed && curr;
-             it++, curr = it.current()) {
-           int curr_w = curr->getWidth() + (screen->getBorderWidth() * 4);
-           int curr_h =
-             ((curr->isShaded()) ? curr->getTitleHeight() : curr->getHeight()) +
-             (screen->getBorderWidth() * 4);
-   
-           if (curr->getXFrame() < test_x + win_size.w() &&
-               curr->getXFrame() + curr_w > test_x &&
-               curr->getYFrame() < test_y + win_size.h() &&
-               curr->getYFrame() + curr_h > test_y) {
-              placed = false;
-           }
+    test_x = (screen.getRowPlacementDirection() == BScreen::LeftRight) ?
+      start_pos : space.w() - win_size.w() - start_pos;
+    while (!placed &&
+           ((screen.getRowPlacementDirection() == BScreen::RightLeft) ?
+            test_x > 0 : test_x + win_size.w() < (signed) space.w())) {
+      placed = true;
+
+      it.reset();
+      for (OpenboxWindow *curr = it.current(); placed && curr;
+           it++, curr = it.current()) {
+        int curr_w = curr->size().w() + (screen.getBorderWidth() * 4);
+        int curr_h = curr->size().h() + (screen.getBorderWidth() * 4);
+
+        if (curr->origin().x() < test_x + win_size.w() &&
+            curr->origin().x() + curr_w > test_x &&
+            curr->origin().y() < test_y + win_size.h() &&
+            curr->origin().y() + curr_h > test_y) {
+          placed = false;
         }
-        // Removed code for checking toolbar and slit
-        // The space passed in should not include either
-        
-        if (placed) {
-           place_x = test_x;
-           place_y = test_y;
-           break;
-        }   
-        
-        test_x += (change_x * delta_x);
-     }
-
-     test_y += (change_y * delta_y);
+      }
+
+      // Removed code for checking toolbar and slit
+      // The space passed in should not include either
+
+      if (placed) {
+        place_x = test_x;
+        place_y = test_y;
+
+        break;
+      }   
+
+      test_x += (change_x * delta_x);
+    }
+
+    test_y += (change_y * delta_y);
   }
   return new Point(place_x, place_y);
 }
 
 void Workspace::placeWindow(OpenboxWindow *win) {
-  assert(win != NULL);
+  ASSERT(win != NULL);
 
   Bool placed = False;
 
-  const int win_w = win->getWidth() + (screen->getBorderWidth() * 4),
-    win_h = win->getHeight() + (screen->getBorderWidth() * 4),
+  const int win_w = win->size().w() + (screen.getBorderWidth() * 4),
+    win_h = win->size().h() + (screen.getBorderWidth() * 4),
 #ifdef    SLIT
-    slit_x = screen->getSlit()->getX() - screen->getBorderWidth(),
-    slit_y = screen->getSlit()->getY() - screen->getBorderWidth(),
-    slit_w = screen->getSlit()->getWidth() +
-      (screen->getBorderWidth() * 4),
-    slit_h = screen->getSlit()->getHeight() +
-      (screen->getBorderWidth() * 4),
+    slit_x = screen.getSlit()->getX() - screen.getBorderWidth(),
+    slit_y = screen.getSlit()->getY() - screen.getBorderWidth(),
+    slit_w = screen.getSlit()->getWidth() +
+      (screen.getBorderWidth() * 4),
+    slit_h = screen.getSlit()->getHeight() +
+      (screen.getBorderWidth() * 4),
 #endif // SLIT
-    toolbar_x = screen->getToolbar()->getX() - screen->getBorderWidth(),
-    toolbar_y = screen->getToolbar()->getY() - screen->getBorderWidth(),
-    toolbar_w = screen->getToolbar()->getWidth() +
-      (screen->getBorderWidth() * 4),
-    toolbar_h = screen->getToolbar()->getHeight() + 
-      (screen->getBorderWidth() * 4),
+    toolbar_x = screen.getToolbar()->getX() - screen.getBorderWidth(),
+    toolbar_y = screen.getToolbar()->getY() - screen.getBorderWidth(),
+    toolbar_w = screen.getToolbar()->getWidth() +
+      (screen.getBorderWidth() * 4),
+    toolbar_h = screen.getToolbar()->getHeight() + 
+      (screen.getBorderWidth() * 4),
     start_pos = 0,
     change_y =
-      ((screen->getColPlacementDirection() == BScreen::TopBottom) ? 1 : -1),
+      ((screen.getColPlacementDirection() == BScreen::TopBottom) ? 1 : -1),
     change_x =
-      ((screen->getRowPlacementDirection() == BScreen::LeftRight) ? 1 : -1),
+      ((screen.getRowPlacementDirection() == BScreen::LeftRight) ? 1 : -1),
     delta_x = 8, delta_y = 8;
 
   int test_x, test_y, place_x = 0, place_y = 0;
   LinkedListIterator<OpenboxWindow> it(windowList);
 
   Rect space(0, 0,
-             screen->getWidth(),
-             screen->getHeight()
+             screen.size().w(),
+             screen.size().h()
             );
   Size window_size(win_w, win_h);
 
-  switch (screen->getPlacementPolicy()) {
+  switch (screen.getPlacementPolicy()) {
   case BScreen::BestFitPlacement: {
     Point *spot = bestFitPlacement(window_size, space);
     if (spot != NULL) {
@@ -518,18 +516,18 @@ void Workspace::placeWindow(OpenboxWindow *win) {
   }
 
   case BScreen::ColSmartPlacement: {
-    test_x = (screen->getRowPlacementDirection() == BScreen::LeftRight) ?
-      start_pos : screen->getWidth() - win_w - start_pos;
+    test_x = (screen.getRowPlacementDirection() == BScreen::LeftRight) ?
+      start_pos : screen.size().w() - win_w - start_pos;
 
     while (!placed &&
-          ((screen->getRowPlacementDirection() == BScreen::RightLeft) ?
-           test_x > 0 : test_x + win_w < (signed) screen->getWidth())) {
-      test_y = (screen->getColPlacementDirection() == BScreen::TopBottom) ?
-       start_pos : screen->getHeight() - win_h - start_pos;
+          ((screen.getRowPlacementDirection() == BScreen::RightLeft) ?
+           test_x > 0 : test_x + win_w < (signed) screen.size().w())) {
+      test_y = (screen.getColPlacementDirection() == BScreen::TopBottom) ?
+       start_pos : screen.size().h() - win_h - start_pos;
       
       while (!placed &&
-            ((screen->getColPlacementDirection() == BScreen::BottomTop) ?
-             test_y > 0 : test_y + win_h < (signed) screen->getHeight())) {
+            ((screen.getColPlacementDirection() == BScreen::BottomTop) ?
+             test_y > 0 : test_y + win_h < (signed) screen.size().h())) {
         placed = True;
 
         it.reset();
@@ -537,15 +535,15 @@ void Workspace::placeWindow(OpenboxWindow *win) {
             it++, curr = it.current()) {
           if (curr->isMaximizedFull()) // fully maximized, ignore it
             continue;
-          int curr_w = curr->getWidth() + (screen->getBorderWidth() * 4);
+          int curr_w = curr->size().w() + (screen.getBorderWidth() * 4);
           int curr_h =
-            ((curr->isShaded()) ? curr->getTitleHeight() : curr->getHeight()) +
-            (screen->getBorderWidth() * 4);
+            ((curr->isShaded()) ? curr->getTitleHeight() : curr->size().h()) +
+            (screen.getBorderWidth() * 4);
 
-          if (curr->getXFrame() < test_x + win_w &&
-              curr->getXFrame() + curr_w > test_x &&
-              curr->getYFrame() < test_y + win_h &&
-              curr->getYFrame() + curr_h > test_y) {
+          if (curr->origin().x() < test_x + win_w &&
+              curr->origin().x() + curr_w > test_x &&
+              curr->origin().y() < test_y + win_h &&
+              curr->origin().y() + curr_h > test_y) {
             placed = False;
          }
         }
@@ -583,8 +581,8 @@ void Workspace::placeWindow(OpenboxWindow *win) {
   } // switch
 
   if (! placed) {
-    if (((unsigned) cascade_x > (screen->getWidth() / 2)) ||
-       ((unsigned) cascade_y > (screen->getHeight() / 2)))
+    if (((unsigned) cascade_x > (screen.size().w() / 2)) ||
+       ((unsigned) cascade_y > (screen.size().h() / 2)))
       cascade_x = cascade_y = 32;
 
     place_x = cascade_x;
@@ -594,10 +592,10 @@ void Workspace::placeWindow(OpenboxWindow *win) {
     cascade_y += win->getTitleHeight();
   }
   
-  if (place_x + win_w > (signed) screen->getWidth())
-    place_x = (((signed) screen->getWidth()) - win_w) / 2;
-  if (place_y + win_h > (signed) screen->getHeight())
-    place_y = (((signed) screen->getHeight()) - win_h) / 2;
+  if (place_x + win_w > (signed) screen.size().w())
+    place_x = (((signed) screen.size().w()) - win_w) / 2;
+  if (place_y + win_h > (signed) screen.size().h())
+    place_y = (((signed) screen.size().h()) - win_h) / 2;
 
-  win->configure(place_x, place_y, win->getWidth(), win->getHeight());
+  win->configure(place_x, place_y, win->size().w(), win->size().h());
 }
This page took 0.035961 seconds and 4 git commands to generate.