]> Dogcows Code - chaz/openbox/blobdiff - render/theme.c
revert the pressed toggled thing for a while
[chaz/openbox] / render / theme.c
index e658d8731f8a264eba9af2ecabe97866aacef509..3b44b525379d6656c8ee33c3a7d0c15a0711d204 100644 (file)
@@ -1,9 +1,28 @@
+/* -*- indent-tabs-mode: nil; tab-width: 4; c-basic-offset: 4; -*-
+
+   theme.c for the Openbox window manager
+   Copyright (c) 2003        Ben Jansens
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   See the COPYING file for a copy of the GNU General Public License.
+*/
+
 #include "render.h"
 #include "color.h"
 #include "font.h"
 #include "mask.h"
 #include "theme.h"
 #include "icon.h"
+#include "parser/parse.h"
 
 #include <X11/Xlib.h>
 #include <X11/Xresource.h>
@@ -11,9 +30,9 @@
 #include <stdlib.h>
 #include <string.h>
 
-static XrmDatabase loaddb(RrTheme *theme, char *name);
-static gboolean read_int(XrmDatabase db, char *rname, int *value);
-static gboolean read_string(XrmDatabase db, char *rname, char **value);
+static XrmDatabase loaddb(RrTheme *theme, gchar *name);
+static gboolean read_int(XrmDatabase db, gchar *rname, gint *value);
+static gboolean read_string(XrmDatabase db, gchar *rname, gchar **value);
 static gboolean read_color(XrmDatabase db, const RrInstance *inst,
                            gchar *rname, RrColor **value);
 static gboolean read_mask(const RrInstance *inst,
@@ -71,28 +90,21 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     theme->a_clear = RrAppearanceNew(inst, 0);
     theme->a_clear_tex = RrAppearanceNew(inst, 1);
 
-    theme->app_hilite_bg = RrAppearanceNew(inst, 0);
-    theme->app_unhilite_bg = RrAppearanceNew(inst, 0);
-    theme->app_hilite_fg = RrAppearanceNew(inst, 0);
-    theme->app_unhilite_fg = RrAppearanceNew(inst, 0);
-    theme->app_hilite_label = RrAppearanceNew(inst, 1);
-    theme->app_unhilite_label = RrAppearanceNew(inst, 1);
-
     if (name) {
-       db = loaddb(theme, name);
+        db = loaddb(theme, name);
         if (db == NULL) {
-           g_warning("Failed to load the theme '%s'\n"
+            g_warning("Failed to load the theme '%s'\n"
                       "Falling back to the default: '%s'",
                       name, DEFAULT_THEME);
-       } else
+        } else
             theme->name = g_path_get_basename(name);
     }
     if (db == NULL) {
-       db = loaddb(theme, DEFAULT_THEME);
-       if (db == NULL) {
-           g_warning("Failed to load the theme '%s'.", DEFAULT_THEME);
-           return NULL;
-       } else
+        db = loaddb(theme, DEFAULT_THEME);
+        if (db == NULL) {
+            g_warning("Failed to load the theme '%s'.", DEFAULT_THEME);
+            return NULL;
+        } else
             theme->name = g_path_get_basename(DEFAULT_THEME);
     }
 
@@ -100,21 +112,21 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     if (!read_string(db, "window.active.label.text.font", &font_str))
         font_str = "arial,sans:bold:pixelsize=10:shadow=y:shadowtint=50";
 
-    if (!(theme->winfont_focused = RrFontOpen(inst, font_str))) {
+    if (!(theme->win_font_focused = RrFontOpen(inst, font_str))) {
         RrThemeFree(theme);
         return NULL;
     }
-    theme->winfont_height = RrFontHeight(theme->winfont_focused);
+    theme->win_font_height = RrFontHeight(theme->win_font_focused);
 
     if (!read_string(db, "window.inactive.label.text.font", &font_str))
         /* font_str will already be set to the last one */;
 
-    if (!(theme->winfont_unfocused = RrFontOpen(inst, font_str))) {
+    if (!(theme->win_font_unfocused = RrFontOpen(inst, font_str))) {
         RrThemeFree(theme);
         return NULL;
     }
-    theme->winfont_height = MAX(theme->winfont_height,
-                                RrFontHeight(theme->winfont_unfocused));
+    theme->win_font_height = MAX(theme->win_font_height,
+                                 RrFontHeight(theme->win_font_unfocused));
 
     winjust = RR_JUSTIFY_LEFT;
     if (read_string(db, "window.label.text.justify", &str)) {
@@ -127,11 +139,11 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     if (!read_string(db, "menu.title.text.font", &font_str))
         font_str = "arial,sans:bold:pixelsize=12:shadow=y";
 
-    if (!(theme->mtitlefont = RrFontOpen(inst, font_str))) {
+    if (!(theme->menu_title_font = RrFontOpen(inst, font_str))) {
         RrThemeFree(theme);
         return NULL;
     }
-    theme->mtitlefont_height = RrFontHeight(theme->mtitlefont);
+    theme->menu_title_font_height = RrFontHeight(theme->menu_title_font);
 
     mtitlejust = RR_JUSTIFY_LEFT;
     if (read_string(db, "menu.title.text.justify", &str)) {
@@ -144,15 +156,15 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     if (!read_string(db, "menu.items.font", &font_str))
         font_str = "arial,sans:bold:pixelsize=11:shadow=y";
 
-    if (!(theme->mfont = RrFontOpen(inst, font_str))) {
+    if (!(theme->menu_font = RrFontOpen(inst, font_str))) {
         RrThemeFree(theme);
         return NULL;
     }
-    theme->mfont_height = RrFontHeight(theme->mfont);
+    theme->menu_font_height = RrFontHeight(theme->menu_font);
 
     /* load direct dimensions */
     if (!read_int(db, "menu.overlap", &theme->menu_overlap) ||
-       theme->menu_overlap < 0 || theme->menu_overlap > 20)
+        theme->menu_overlap < 0 || theme->menu_overlap > 20)
         theme->menu_overlap = 0;
     if (!read_int(db, "window.handle.width", &theme->handle_height))
         theme->handle_height = 6;
@@ -161,48 +173,48 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     if (theme->handle_height <= 0 || theme->handle_height > 100)
         theme->handle_height = 6;
     if (!read_int(db, "padding.width", &theme->padding) ||
-       theme->padding < 0 || theme->padding > 100)
+        theme->padding < 0 || theme->padding > 100)
         theme->padding = 3;
     if (!read_int(db, "border.width", &theme->bwidth) ||
-       theme->bwidth < 0 || theme->bwidth > 100)
+        theme->bwidth < 0 || theme->bwidth > 100)
         theme->bwidth = 1;
     if (!read_int(db, "window.client.padding.width", &theme->cbwidth) ||
-       theme->cbwidth < 0 || theme->cbwidth > 100)
+        theme->cbwidth < 0 || theme->cbwidth > 100)
         theme->cbwidth = theme->padding;
 
     /* load colors */
     if (!read_color(db, inst,
                     "border.color", &theme->b_color))
-       theme->b_color = RrColorNew(inst, 0, 0, 0);
+        theme->b_color = RrColorNew(inst, 0, 0, 0);
     if (!read_color(db, inst,
                     "window.active.client.color",
                     &theme->cb_focused_color))
-       theme->cb_focused_color = RrColorNew(inst, 0xff, 0xff, 0xff);
+        theme->cb_focused_color = RrColorNew(inst, 0xff, 0xff, 0xff);
     if (!read_color(db, inst,
                     "window.inactive.client.color",
                     &theme->cb_unfocused_color))
-       theme->cb_unfocused_color = RrColorNew(inst, 0xff, 0xff, 0xff);
+        theme->cb_unfocused_color = RrColorNew(inst, 0xff, 0xff, 0xff);
     if (!read_color(db, inst,
                     "window.active.label.text.color",
                     &theme->title_focused_color))
-       theme->title_focused_color = RrColorNew(inst, 0x0, 0x0, 0x0);
+        theme->title_focused_color = RrColorNew(inst, 0x0, 0x0, 0x0);
     if (!read_color(db, inst,
                     "window.inactive.label.text.color",
                     &theme->title_unfocused_color))
-       theme->title_unfocused_color = RrColorNew(inst, 0xff, 0xff, 0xff);
+        theme->title_unfocused_color = RrColorNew(inst, 0xff, 0xff, 0xff);
     if (!read_color(db, inst,
                     "window.active.button.unpressed.image.color",
                     &theme->titlebut_focused_unpressed_color))
-       theme->titlebut_focused_unpressed_color = RrColorNew(inst, 0, 0, 0);
+        theme->titlebut_focused_unpressed_color = RrColorNew(inst, 0, 0, 0);
     if (!read_color(db, inst,
                     "window.inactive.button.unpressed.image.color",
                     &theme->titlebut_unfocused_unpressed_color))
-       theme->titlebut_unfocused_unpressed_color =
+        theme->titlebut_unfocused_unpressed_color =
             RrColorNew(inst, 0xff, 0xff, 0xff);
     if (!read_color(db, inst,
                     "window.active.button.pressed.image.color",
                     &theme->titlebut_focused_pressed_color))
-       theme->titlebut_focused_pressed_color =
+        theme->titlebut_focused_pressed_color =
             RrColorNew(inst,
                        theme->titlebut_focused_unpressed_color->r,
                        theme->titlebut_focused_unpressed_color->g,
@@ -210,7 +222,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     if (!read_color(db, inst,
                     "window.inactive.button.pressed.image.color",
                     &theme->titlebut_unfocused_pressed_color))
-       theme->titlebut_unfocused_pressed_color =
+        theme->titlebut_unfocused_pressed_color =
             RrColorNew(inst,
                        theme->titlebut_unfocused_unpressed_color->r,
                        theme->titlebut_unfocused_unpressed_color->g,
@@ -218,16 +230,16 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     if (!read_color(db, inst,
                     "window.active.button.disabled.image.color",
                     &theme->titlebut_disabled_focused_color))
-       theme->titlebut_disabled_focused_color =
+        theme->titlebut_disabled_focused_color =
             RrColorNew(inst, 0xff, 0xff, 0xff);
     if (!read_color(db, inst,
                     "window.inactive.button.disabled.image.color",
                     &theme->titlebut_disabled_unfocused_color))
-       theme->titlebut_disabled_unfocused_color = RrColorNew(inst, 0, 0, 0);
+        theme->titlebut_disabled_unfocused_color = RrColorNew(inst, 0, 0, 0);
     if (!read_color(db, inst,
                     "window.active.button.hover.image.color",
                     &theme->titlebut_hover_focused_color))
-       theme->titlebut_hover_focused_color =
+        theme->titlebut_hover_focused_color =
             RrColorNew(inst,
                        theme->titlebut_focused_unpressed_color->r,
                        theme->titlebut_focused_unpressed_color->g,
@@ -235,7 +247,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     if (!read_color(db, inst,
                     "window.inactive.button.hover.image.color",
                     &theme->titlebut_hover_unfocused_color))
-       theme->titlebut_hover_unfocused_color =
+        theme->titlebut_hover_unfocused_color =
             RrColorNew(inst,
                        theme->titlebut_unfocused_unpressed_color->r,
                        theme->titlebut_unfocused_unpressed_color->g,
@@ -243,7 +255,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     if (!read_color(db, inst,
                     "window.active.button.toggled.image.color",
                     &theme->titlebut_toggled_focused_color))
-       theme->titlebut_toggled_focused_color =
+        theme->titlebut_toggled_focused_color =
             RrColorNew(inst,
                        theme->titlebut_focused_pressed_color->r,
                        theme->titlebut_focused_pressed_color->g,
@@ -251,7 +263,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     if (!read_color(db, inst,
                     "window.inactive.button.toggled.image.color",
                     &theme->titlebut_toggled_unfocused_color))
-       theme->titlebut_toggled_unfocused_color =
+        theme->titlebut_toggled_unfocused_color =
             RrColorNew(inst,
                        theme->titlebut_unfocused_pressed_color->r,
                        theme->titlebut_unfocused_pressed_color->g,
@@ -288,14 +300,14 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
         if (!read_mask(inst, "max_hover.xbm", theme, &theme->max_hover_mask)) {
             theme->max_hover_mask = RrPixmapMaskCopy(theme->max_mask);
         }
-   } else {
+    } else {
         {
             guchar data[] = { 0x7f, 0x7f, 0x7f, 0x41, 0x41, 0x41, 0x7f };
-            theme->max_mask = RrPixmapMaskNew(inst, 7, 7, (char*)data);
+            theme->max_mask = RrPixmapMaskNew(inst, 7, 7, (gchar*)data);
         }
         {
             guchar data[] = { 0x7c, 0x44, 0x47, 0x47, 0x7f, 0x1f, 0x1f };
-            theme->max_toggled_mask = RrPixmapMaskNew(inst, 7, 7, (char*)data);
+            theme->max_toggled_mask = RrPixmapMaskNew(inst, 7, 7, (gchar*)data);
         }
         theme->max_pressed_mask = RrPixmapMaskCopy(theme->max_mask);
         theme->max_disabled_mask = RrPixmapMaskCopy(theme->max_mask);
@@ -320,7 +332,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     } else {
         {
             guchar data[] = { 0x00, 0x00, 0x00, 0x00, 0x7f, 0x7f, 0x7f };
-            theme->iconify_mask = RrPixmapMaskNew(inst, 7, 7, (char*)data);
+            theme->iconify_mask = RrPixmapMaskNew(inst, 7, 7, (gchar*)data);
         }
         theme->iconify_pressed_mask = RrPixmapMaskCopy(theme->iconify_mask);
         theme->iconify_disabled_mask = RrPixmapMaskCopy(theme->iconify_mask);
@@ -352,12 +364,12 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     } else {
         {
             guchar data[] = { 0x63, 0x63, 0x00, 0x00, 0x00, 0x63, 0x63 };
-            theme->desk_mask = RrPixmapMaskNew(inst, 7, 7, (char*)data);
+            theme->desk_mask = RrPixmapMaskNew(inst, 7, 7, (gchar*)data);
         }
         {
             guchar data[] = { 0x00, 0x36, 0x36, 0x08, 0x36, 0x36, 0x00 };
             theme->desk_toggled_mask = RrPixmapMaskNew(inst, 7, 7,
-                                                       (char*)data);
+                                                       (gchar*)data);
         }
         theme->desk_pressed_mask = RrPixmapMaskCopy(theme->desk_mask);
         theme->desk_disabled_mask = RrPixmapMaskCopy(theme->desk_mask);
@@ -385,12 +397,12 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     } else {
         {
             guchar data[] = { 0x7f, 0x7f, 0x7f, 0x00, 0x00, 0x00, 0x00 };
-            theme->shade_mask = RrPixmapMaskNew(inst, 7, 7, (char*)data);
+            theme->shade_mask = RrPixmapMaskNew(inst, 7, 7, (gchar*)data);
         }
         {
             guchar data[] = { 0x7f, 0x7f, 0x7f, 0x00, 0x00, 0x00, 0x7f };
             theme->shade_toggled_mask = RrPixmapMaskNew(inst, 7, 7,
-                                                        (char*)data);
+                                                        (gchar*)data);
         }
         theme->shade_pressed_mask = RrPixmapMaskCopy(theme->shade_mask);
         theme->shade_disabled_mask = RrPixmapMaskCopy(theme->shade_mask);
@@ -413,7 +425,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     } else {
         {
             guchar data[] = { 0x63, 0x77, 0x3e, 0x1c, 0x3e, 0x77, 0x63 };
-            theme->close_mask = RrPixmapMaskNew(inst, 7, 7, (char*)data);
+            theme->close_mask = RrPixmapMaskNew(inst, 7, 7, (gchar*)data);
         }
         theme->close_pressed_mask = RrPixmapMaskCopy(theme->close_mask);
         theme->close_disabled_mask = RrPixmapMaskCopy(theme->close_mask);
@@ -422,120 +434,93 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
 
     if (!read_mask(inst, "bullet.xbm", theme, &theme->menu_bullet_mask)) {
         guchar data[] = { 0x01, 0x03, 0x07, 0x0f, 0x07, 0x03, 0x01 };
-        theme->menu_bullet_mask = RrPixmapMaskNew(inst, 4, 7, (char*)data);
+        theme->menu_bullet_mask = RrPixmapMaskNew(inst, 4, 7, (gchar*)data);
     }
 
     /* read the decoration textures */
     if (!read_appearance(db, inst,
                          "window.active.title.bg", theme->a_focused_title,
                          FALSE))
-       set_default_appearance(theme->a_focused_title);
+        set_default_appearance(theme->a_focused_title);
     if (!read_appearance(db, inst,
                          "window.inactive.title.bg", theme->a_unfocused_title,
                          FALSE))
-       set_default_appearance(theme->a_unfocused_title);
+        set_default_appearance(theme->a_unfocused_title);
     if (!read_appearance(db, inst,
                          "window.active.label.bg", theme->a_focused_label,
                          TRUE))
-       set_default_appearance(theme->a_focused_label);
+        set_default_appearance(theme->a_focused_label);
     if (!read_appearance(db, inst,
                          "window.inactive.label.bg", theme->a_unfocused_label,
                          TRUE))
-       set_default_appearance(theme->a_unfocused_label);
+        set_default_appearance(theme->a_unfocused_label);
     if (!read_appearance(db, inst,
                          "window.active.handle.bg", theme->a_focused_handle,
                          FALSE))
-       set_default_appearance(theme->a_focused_handle);
+        set_default_appearance(theme->a_focused_handle);
     if (!read_appearance(db, inst,
                          "window.inactive.handle.bg",theme->a_unfocused_handle,
                          FALSE))
-       set_default_appearance(theme->a_unfocused_handle);
+        set_default_appearance(theme->a_unfocused_handle);
     if (!read_appearance(db, inst,
                          "window.active.grip.bg", theme->a_focused_grip,
                          TRUE))
-       set_default_appearance(theme->a_focused_grip);
+        set_default_appearance(theme->a_focused_grip);
     if (!read_appearance(db, inst,
                          "window.inactive.grip.bg", theme->a_unfocused_grip,
                          TRUE))
-       set_default_appearance(theme->a_unfocused_grip);
+        set_default_appearance(theme->a_unfocused_grip);
     if (!read_appearance(db, inst,
                          "menu.items.bg", theme->a_menu,
                          FALSE))
-       set_default_appearance(theme->a_menu);
+        set_default_appearance(theme->a_menu);
     if (!read_appearance(db, inst,
                          "menu.title.bg", theme->a_menu_title,
                          FALSE))
-       set_default_appearance(theme->a_menu_title);
+        set_default_appearance(theme->a_menu_title);
     if (!read_appearance(db, inst,
                          "menu.items.active.bg", theme->a_menu_selected,
                          TRUE))
-       set_default_appearance(theme->a_menu_selected);
+        set_default_appearance(theme->a_menu_selected);
 
     /* read the appearances for rendering non-decorations */
-    if (!read_appearance(db, inst,
-                         "window.active.title.bg", theme->app_hilite_bg,
-                         FALSE))
-        set_default_appearance(theme->app_hilite_bg);
-    if (!read_appearance(db, inst,
-                         "window.active.label.bg", theme->app_hilite_label,
-                         TRUE))
-        set_default_appearance(theme->app_hilite_label);
-    if (!read_appearance(db, inst,
-                         "window.active.label.bg", theme->app_hilite_fg,
-                         TRUE))
-        set_default_appearance(theme->app_hilite_fg);
-    else if (theme->app_hilite_label->surface.grad == RR_SURFACE_PARENTREL) {
-        if (!read_appearance(db, inst,
-                             "window.active.title.bg",
-                             theme->app_hilite_fg,
-                             FALSE))
-            set_default_appearance(theme->app_hilite_fg);
-    }
-    if (!read_appearance(db, inst,
-                         "window.inactive.title.bg", theme->app_unhilite_bg,
-                         FALSE))
-        set_default_appearance(theme->app_unhilite_bg);
-    if (!read_appearance(db, inst,
-                         "window.inactive.label.bg", theme->app_unhilite_label,
-                         TRUE))
-        set_default_appearance(theme->app_unhilite_label);
-    if (!read_appearance(db, inst,
-                         "window.inactive.label.bg", theme->app_unhilite_fg,
-                         TRUE))
-        set_default_appearance(theme->app_unhilite_fg);
-    else if (theme->app_unhilite_label->surface.grad == RR_SURFACE_PARENTREL) {
-        if (!read_appearance(db, inst,
-                             "window.inactive.title.bg",
-                             theme->app_unhilite_fg,
-                             FALSE))
-            set_default_appearance(theme->app_unhilite_fg);
-    }
-        
+    theme->app_hilite_bg = RrAppearanceCopy(theme->a_focused_title);
+    theme->app_hilite_label = RrAppearanceCopy(theme->a_focused_label);
+    if (theme->a_focused_label->surface.grad != RR_SURFACE_PARENTREL)
+        theme->app_hilite_fg = RrAppearanceCopy(theme->a_focused_label);
+    else
+        theme->app_hilite_fg = RrAppearanceCopy(theme->a_focused_title);
+    theme->app_unhilite_bg = RrAppearanceCopy(theme->a_unfocused_title);
+    theme->app_unhilite_label = RrAppearanceCopy(theme->a_unfocused_label);
+    if (theme->a_unfocused_label->surface.grad != RR_SURFACE_PARENTREL)
+        theme->app_unhilite_fg = RrAppearanceCopy(theme->a_unfocused_label);
+    else
+        theme->app_unhilite_fg = RrAppearanceCopy(theme->a_unfocused_title);
 
     /* read buttons textures */
     if (!read_appearance(db, inst,
                          "window.active.button.disabled.bg",
-                        theme->a_disabled_focused_max,
+                         theme->a_disabled_focused_max,
                          TRUE))
         set_default_appearance(theme->a_disabled_focused_max);
     if (!read_appearance(db, inst,
                          "window.inactive.button.disabled.bg",
-                        theme->a_disabled_unfocused_max,
+                         theme->a_disabled_unfocused_max,
                          TRUE))
         set_default_appearance(theme->a_disabled_unfocused_max);
     if (!read_appearance(db, inst,
                          "window.active.button.pressed.bg",
-                        theme->a_focused_pressed_max,
+                         theme->a_focused_pressed_max,
                          TRUE))
         set_default_appearance(theme->a_focused_pressed_max);
     if (!read_appearance(db, inst,
                          "window.inactive.button.pressed.bg",
-                        theme->a_unfocused_pressed_max,
+                         theme->a_unfocused_pressed_max,
                          TRUE))
         set_default_appearance(theme->a_unfocused_pressed_max);
     if (!read_appearance(db, inst,
                          "window.active.button.toggled.bg",
-                        theme->a_toggled_focused_max,
+                         theme->a_toggled_focused_max,
                          TRUE))
     {
         RrAppearanceFree(theme->a_toggled_focused_max);
@@ -544,7 +529,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     }
     if (!read_appearance(db, inst,
                          "window.inactive.button.toggled.bg",
-                        theme->a_toggled_unfocused_max,
+                         theme->a_toggled_unfocused_max,
                          TRUE))
     {
         RrAppearanceFree(theme->a_toggled_unfocused_max);
@@ -553,17 +538,17 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     }
     if (!read_appearance(db, inst,
                          "window.active.button.unpressed.bg",
-                        theme->a_focused_unpressed_max,
+                         theme->a_focused_unpressed_max,
                          TRUE))
-       set_default_appearance(theme->a_focused_unpressed_max);
+        set_default_appearance(theme->a_focused_unpressed_max);
     if (!read_appearance(db, inst,
                          "window.inactive.button.unpressed.bg",
-                        theme->a_unfocused_unpressed_max,
+                         theme->a_unfocused_unpressed_max,
                          TRUE))
-       set_default_appearance(theme->a_unfocused_unpressed_max);
+        set_default_appearance(theme->a_unfocused_unpressed_max);
     if (!read_appearance(db, inst,
                          "window.active.button.hover.bg",
-                        theme->a_hover_focused_max,
+                         theme->a_hover_focused_max,
                          TRUE))
     {
         RrAppearanceFree(theme->a_hover_focused_max);
@@ -572,7 +557,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     }
     if (!read_appearance(db, inst,
                          "window.inactive.button.hover.bg",
-                        theme->a_hover_unfocused_max,
+                         theme->a_hover_unfocused_max,
                          TRUE))
     {
         RrAppearanceFree(theme->a_hover_unfocused_max);
@@ -606,7 +591,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
         RrAppearanceCopy(theme->a_hover_unfocused_max); 
     theme->a_toggled_focused_desk =
         RrAppearanceCopy(theme->a_toggled_focused_max);
-   theme->a_toggled_unfocused_desk =
+    theme->a_toggled_unfocused_desk =
         RrAppearanceCopy(theme->a_toggled_unfocused_max);
     theme->a_unfocused_unpressed_desk =
         RrAppearanceCopy(theme->a_unfocused_unpressed_max);
@@ -671,7 +656,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     theme->app_hilite_label->texture[0].data.text.justify = RR_JUSTIFY_LEFT;
     theme->a_focused_label->texture[0].data.text.font =
         theme->app_hilite_label->texture[0].data.text.font =
-        theme->winfont_focused;
+        theme->win_font_focused;
     theme->a_focused_label->texture[0].data.text.color =
         theme->app_hilite_label->texture[0].data.text.color =
         theme->title_focused_color;
@@ -683,14 +668,14 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
         RR_JUSTIFY_LEFT;
     theme->a_unfocused_label->texture[0].data.text.font =
         theme->app_unhilite_label->texture[0].data.text.font =
-        theme->winfont_unfocused;
+        theme->win_font_unfocused;
     theme->a_unfocused_label->texture[0].data.text.color =
         theme->app_unhilite_label->texture[0].data.text.color =
         theme->title_unfocused_color;
 
     theme->a_menu_title->texture[0].type = RR_TEXTURE_TEXT;
     theme->a_menu_title->texture[0].data.text.justify = mtitlejust;
-    theme->a_menu_title->texture[0].data.text.font = theme->mtitlefont;
+    theme->a_menu_title->texture[0].data.text.font = theme->menu_title_font;
     theme->a_menu_title->texture[0].data.text.color = theme->menu_title_color;
 
     theme->a_menu_text_normal->texture[0].type =
@@ -702,7 +687,8 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
         RR_JUSTIFY_LEFT;
     theme->a_menu_text_normal->texture[0].data.text.font =
         theme->a_menu_text_disabled->texture[0].data.text.font =
-        theme->a_menu_text_selected->texture[0].data.text.font = theme->mfont;
+        theme->a_menu_text_selected->texture[0].data.text.font =
+        theme->menu_font;
     theme->a_menu_text_normal->texture[0].data.text.color = theme->menu_color;
     theme->a_menu_text_disabled->texture[0].data.text.color =
         theme->menu_disabled_color;
@@ -880,7 +866,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
         theme->a_unfocused_unpressed_shade->texture[0].data.mask.color = 
         theme->a_unfocused_unpressed_iconify->texture[0].data.mask.color = 
         theme->titlebut_unfocused_unpressed_color;
-        theme->a_unfocused_pressed_max->texture[0].data.mask.color = 
+    theme->a_unfocused_pressed_max->texture[0].data.mask.color = 
         theme->a_unfocused_pressed_close->texture[0].data.mask.color = 
         theme->a_unfocused_pressed_desk->texture[0].data.mask.color = 
         theme->a_unfocused_pressed_shade->texture[0].data.mask.color = 
@@ -894,26 +880,28 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
     XrmDestroyDatabase(db);
 
     {
-        gint fl, ft, fr, fb;
-        gint ul, ut, ur, ub;
+        gint ft, fb, fl, fr, ut, ub, ul, ur;
 
         RrMargins(theme->a_focused_label, &fl, &ft, &fr, &fb);
         RrMargins(theme->a_unfocused_label, &ul, &ut, &ur, &ub);
-        theme->label_height = theme->winfont_height
-            + MAX(ft + fb, ut + ub);
+        theme->label_height = theme->win_font_height + MAX(ft + fb, ut + ub);
 
         /* this would be nice I think, since padding.width can now be 0,
            but it breaks frame.c horribly and I don't feel like fixing that
            right now, so if anyone complains, here is how to keep text from
            going over the title's bevel/border with a padding.width of 0 and a
            bevelless/borderless label
-        RrMargins(theme->a_focused_title, &fl, &ft, &fr, &fb);
-        RrMargins(theme->a_unfocused_title, &ul, &ut, &ur, &ub);
-        theme->title_height = theme->label_height +
-            MAX(MAX(theme->padding * 2, ft + fb),
-                MAX(theme->padding * 2, ut + ub));
+           RrMargins(theme->a_focused_title, &fl, &ft, &fr, &fb);
+           RrMargins(theme->a_unfocused_title, &ul, &ut, &ur, &ub);
+           theme->title_height = theme->label_height +
+           MAX(MAX(theme->padding * 2, ft + fb),
+           MAX(theme->padding * 2, ut + ub));
         */
         theme->title_height = theme->label_height + theme->padding * 2;
+        /* this should match the above title_height given the same font size
+           for both. */
+        theme->menu_title_height = theme->menu_title_font_height +
+            theme->padding * 2;
     }
     theme->button_size = theme->label_height - 2;
     theme->grip_width = theme->title_height * 1.5;
@@ -924,6 +912,7 @@ RrTheme* RrThemeNew(const RrInstance *inst, gchar *name)
 void RrThemeFree(RrTheme *theme)
 {
     if (theme) {
+        g_free(theme->path);
         g_free(theme->name);
 
         RrColorFree(theme->b_color);
@@ -973,10 +962,10 @@ void RrThemeFree(RrTheme *theme)
         RrPixmapMaskFree(theme->close_pressed_mask);
         RrPixmapMaskFree(theme->menu_bullet_mask);
 
-        RrFontClose(theme->winfont_focused); 
-        RrFontClose(theme->winfont_unfocused);
-        RrFontClose(theme->mtitlefont);
-        RrFontClose(theme->mfont);
+        RrFontClose(theme->win_font_focused); 
+        RrFontClose(theme->win_font_unfocused);
+        RrFontClose(theme->menu_title_font);
+        RrFontClose(theme->menu_font);
 
         RrAppearanceFree(theme->a_disabled_focused_max);
         RrAppearanceFree(theme->a_disabled_unfocused_max);
@@ -1051,27 +1040,44 @@ void RrThemeFree(RrTheme *theme)
         RrAppearanceFree(theme->app_unhilite_fg);
         RrAppearanceFree(theme->app_hilite_label);
         RrAppearanceFree(theme->app_unhilite_label);
+
+        g_free(theme);
     }
 }
 
-static XrmDatabase loaddb(RrTheme *theme, char *name)
+static XrmDatabase loaddb(RrTheme *theme, gchar *name)
 {
-    XrmDatabase db;
+    GSList *it;
+    XrmDatabase db = NULL;
+    gchar *s;
 
-    char *s = g_build_filename(g_get_home_dir(), ".openbox", "themes",
-                               name, "themerc", NULL);
-    if ((db = XrmGetFileDatabase(s)))
-        theme->path = g_path_get_dirname(s);
-    g_free(s);
-    if (db == NULL) {
-       char *s = g_build_filename(THEMEDIR, name, "themerc", NULL);
-       if ((db = XrmGetFileDatabase(s)))
+    if (name[0] == '/') {
+        s = g_build_filename(name, "openbox-3", "themerc", NULL);
+        if ((db = XrmGetFileDatabase(s)))
             theme->path = g_path_get_dirname(s);
-       g_free(s);
+        g_free(s);
+    } else {
+        /* XXX backwards compatibility, remove me sometime later */
+        s = g_build_filename(g_get_home_dir(), ".themes", name,
+                             "openbox-3", "themerc", NULL);
+        if ((db = XrmGetFileDatabase(s)))
+            theme->path = g_path_get_dirname(s);
+        g_free(s);
+
+        for (it = parse_xdg_data_dir_paths(); !db && it;
+             it = g_slist_next(it))
+        {
+            s = g_build_filename(it->data, "themes", name,
+                                 "openbox-3", "themerc", NULL);
+            if ((db = XrmGetFileDatabase(s)))
+                theme->path = g_path_get_dirname(s);
+            g_free(s);
+        }
     }
+
     if (db == NULL) {
-        char *s = g_build_filename(name, "themerc", NULL);
-       if ((db = XrmGetFileDatabase(s)))
+        s = g_build_filename(name, "themerc", NULL);
+        if ((db = XrmGetFileDatabase(s)))
             theme->path = g_path_get_dirname(s);
         g_free(s);
     }
@@ -1079,50 +1085,50 @@ static XrmDatabase loaddb(RrTheme *theme, char *name)
     return db;
 }
 
-static char *create_class_name(char *rname)
+static gchar *create_class_name(gchar *rname)
 {
-    char *rclass = g_strdup(rname);
-    char *p = rclass;
+    gchar *rclass = g_strdup(rname);
+    gchar *p = rclass;
 
     while (TRUE) {
-       *p = toupper(*p);
-       p = strchr(p+1, '.');
-       if (p == NULL) break;
-       ++p;
-       if (*p == '\0') break;
+        *p = toupper(*p);
+        p = strchr(p+1, '.');
+        if (p == NULL) break;
+        ++p;
+        if (*p == '\0') break;
     }
     return rclass;
 }
 
-static gboolean read_int(XrmDatabase db, char *rname, int *value)
+static gboolean read_int(XrmDatabase db, gchar *rname, gint *value)
 {
     gboolean ret = FALSE;
-    char *rclass = create_class_name(rname);
-    char *rettype, *end;
+    gchar *rclass = create_class_name(rname);
+    gchar *rettype, *end;
     XrmValue retvalue;
   
     if (XrmGetResource(db, rname, rclass, &rettype, &retvalue) &&
-       retvalue.addr != NULL) {
-       *value = (int)strtol(retvalue.addr, &end, 10);
-       if (end != retvalue.addr)
-           ret = TRUE;
+        retvalue.addr != NULL) {
+        *value = (gint)strtol(retvalue.addr, &end, 10);
+        if (end != retvalue.addr)
+            ret = TRUE;
     }
 
     g_free(rclass);
     return ret;
 }
 
-static gboolean read_string(XrmDatabase db, char *rname, char **value)
+static gboolean read_string(XrmDatabase db, gchar *rname, gchar **value)
 {
     gboolean ret = FALSE;
-    char *rclass = create_class_name(rname);
-    char *rettype;
+    gchar *rclass = create_class_name(rname);
+    gchar *rettype;
     XrmValue retvalue;
   
     if (XrmGetResource(db, rname, rclass, &rettype, &retvalue) &&
-       retvalue.addr != NULL) {
-       *value = retvalue.addr;
-       ret = TRUE;
+        retvalue.addr != NULL) {
+        *value = retvalue.addr;
+        ret = TRUE;
     }
 
     g_free(rclass);
@@ -1133,17 +1139,17 @@ static gboolean read_color(XrmDatabase db, const RrInstance *inst,
                            gchar *rname, RrColor **value)
 {
     gboolean ret = FALSE;
-    char *rclass = create_class_name(rname);
-    char *rettype;
+    gchar *rclass = create_class_name(rname);
+    gchar *rettype;
     XrmValue retvalue;
   
     if (XrmGetResource(db, rname, rclass, &rettype, &retvalue) &&
-       retvalue.addr != NULL) {
-       RrColor *c = RrColorParse(inst, retvalue.addr);
-       if (c != NULL) {
-           *value = c;
-           ret = TRUE;
-       }
+        retvalue.addr != NULL) {
+        RrColor *c = RrColorParse(inst, retvalue.addr);
+        if (c != NULL) {
+            *value = c;
+            ret = TRUE;
+        }
     }
 
     g_free(rclass);
@@ -1155,15 +1161,15 @@ static gboolean read_mask(const RrInstance *inst,
                           RrPixmapMask **value)
 {
     gboolean ret = FALSE;
-    char *s;
-    int hx, hy; /* ignored */
-    unsigned int w, h;
-    unsigned char *b;
+    gchar *s;
+    gint hx, hy; /* ignored */
+    guint w, h;
+    guchar *b;
 
     s = g_build_filename(theme->path, maskname, NULL);
     if (XReadBitmapFileData(s, &w, &h, &b, &hx, &hy) == BitmapSuccess) {
         ret = TRUE;
-        *value = RrPixmapMaskNew(inst, w, h, (char*)b);
+        *value = RrPixmapMaskNew(inst, w, h, (gchar*)b);
         XFree(b);
     }
     g_free(s);
@@ -1176,52 +1182,52 @@ static void parse_appearance(gchar *tex, RrSurfaceColorType *grad,
                              gboolean *interlaced, gboolean *border,
                              gboolean allow_trans)
 {
-    char *t;
+    gchar *t;
 
     /* convert to all lowercase */
     for (t = tex; *t != '\0'; ++t)
-       *t = g_ascii_tolower(*t);
+        *t = g_ascii_tolower(*t);
 
     if (allow_trans && strstr(tex, "parentrelative") != NULL) {
-       *grad = RR_SURFACE_PARENTREL;
+        *grad = RR_SURFACE_PARENTREL;
     } else {
-       if (strstr(tex, "gradient") != NULL) {
-           if (strstr(tex, "crossdiagonal") != NULL)
-               *grad = RR_SURFACE_CROSS_DIAGONAL;
-           else if (strstr(tex, "pyramid") != NULL)
-               *grad = RR_SURFACE_PYRAMID;
-           else if (strstr(tex, "horizontal") != NULL)
-               *grad = RR_SURFACE_HORIZONTAL;
-           else if (strstr(tex, "vertical") != NULL)
-               *grad = RR_SURFACE_VERTICAL;
-           else
-               *grad = RR_SURFACE_DIAGONAL;
-       } else {
-           *grad = RR_SURFACE_SOLID;
-       }
-
-       if (strstr(tex, "sunken") != NULL)
-           *relief = RR_RELIEF_SUNKEN;
-       else if (strstr(tex, "flat") != NULL)
-           *relief = RR_RELIEF_FLAT;
-       else
-           *relief = RR_RELIEF_RAISED;
-       
-       *border = FALSE;
-       if (*relief == RR_RELIEF_FLAT) {
-           if (strstr(tex, "border") != NULL)
-               *border = TRUE;
-       } else {
-           if (strstr(tex, "bevel2") != NULL)
-               *bevel = RR_BEVEL_2;
-           else
-               *bevel = RR_BEVEL_1;
-       }
-
-       if (strstr(tex, "interlaced") != NULL)
-           *interlaced = TRUE;
-       else
-           *interlaced = FALSE;
+        if (strstr(tex, "gradient") != NULL) {
+            if (strstr(tex, "crossdiagonal") != NULL)
+                *grad = RR_SURFACE_CROSS_DIAGONAL;
+            else if (strstr(tex, "pyramid") != NULL)
+                *grad = RR_SURFACE_PYRAMID;
+            else if (strstr(tex, "horizontal") != NULL)
+                *grad = RR_SURFACE_HORIZONTAL;
+            else if (strstr(tex, "vertical") != NULL)
+                *grad = RR_SURFACE_VERTICAL;
+            else
+                *grad = RR_SURFACE_DIAGONAL;
+        } else {
+            *grad = RR_SURFACE_SOLID;
+        }
+
+        if (strstr(tex, "sunken") != NULL)
+            *relief = RR_RELIEF_SUNKEN;
+        else if (strstr(tex, "flat") != NULL)
+            *relief = RR_RELIEF_FLAT;
+        else
+            *relief = RR_RELIEF_RAISED;
+
+        *border = FALSE;
+        if (*relief == RR_RELIEF_FLAT) {
+            if (strstr(tex, "border") != NULL)
+                *border = TRUE;
+        } else {
+            if (strstr(tex, "bevel2") != NULL)
+                *bevel = RR_BEVEL_2;
+            else
+                *bevel = RR_BEVEL_1;
+        }
+
+        if (strstr(tex, "interlaced") != NULL)
+            *interlaced = TRUE;
+        else
+            *interlaced = FALSE;
     }
 }
 
@@ -1231,9 +1237,9 @@ static gboolean read_appearance(XrmDatabase db, const RrInstance *inst,
                                 gboolean allow_trans)
 {
     gboolean ret = FALSE;
-    char *rclass = create_class_name(rname);
-    char *cname, *ctoname, *bcname, *icname;
-    char *rettype;
+    gchar *rclass = create_class_name(rname);
+    gchar *cname, *ctoname, *bcname, *icname;
+    gchar *rettype;
     XrmValue retvalue;
 
     cname = g_strconcat(rname, ".color", NULL);
@@ -1242,27 +1248,27 @@ static gboolean read_appearance(XrmDatabase db, const RrInstance *inst,
     icname = g_strconcat(rname, ".interlace.color", NULL);
 
     if (XrmGetResource(db, rname, rclass, &rettype, &retvalue) &&
-       retvalue.addr != NULL) {
-       parse_appearance(retvalue.addr,
-                        &value->surface.grad,
-                        &value->surface.relief,
-                        &value->surface.bevel,
-                        &value->surface.interlaced,
-                        &value->surface.border,
+        retvalue.addr != NULL) {
+        parse_appearance(retvalue.addr,
+                         &value->surface.grad,
+                         &value->surface.relief,
+                         &value->surface.bevel,
+                         &value->surface.interlaced,
+                         &value->surface.border,
                          allow_trans);
-       if (!read_color(db, inst, cname, &value->surface.primary))
-           value->surface.primary = RrColorNew(inst, 0, 0, 0);
-       if (!read_color(db, inst, ctoname, &value->surface.secondary))
-           value->surface.secondary = RrColorNew(inst, 0, 0, 0);
-       if (value->surface.border)
-           if (!read_color(db, inst, bcname,
-                           &value->surface.border_color))
-               value->surface.border_color = RrColorNew(inst, 0, 0, 0);
+        if (!read_color(db, inst, cname, &value->surface.primary))
+            value->surface.primary = RrColorNew(inst, 0, 0, 0);
+        if (!read_color(db, inst, ctoname, &value->surface.secondary))
+            value->surface.secondary = RrColorNew(inst, 0, 0, 0);
+        if (value->surface.border)
+            if (!read_color(db, inst, bcname,
+                            &value->surface.border_color))
+                value->surface.border_color = RrColorNew(inst, 0, 0, 0);
         if (value->surface.interlaced)
-           if (!read_color(db, inst, icname,
-                           &value->surface.interlace_color))
-               value->surface.interlace_color = RrColorNew(inst, 0, 0, 0);
-       ret = TRUE;
+            if (!read_color(db, inst, icname,
+                            &value->surface.interlace_color))
+                value->surface.interlace_color = RrColorNew(inst, 0, 0, 0);
+        ret = TRUE;
     }
 
     g_free(icname);
@@ -1291,11 +1297,9 @@ static RrPixel32* read_c_image(gint width, gint height, const guint8 *data)
     RrPixel32 *im, *p;
     gint i;
 
-    p = im = g_memdup(OB_DEFAULT_ICON_pixel_data,
-                      OB_DEFAULT_ICON_WIDTH * OB_DEFAULT_ICON_HEIGHT *
-                      sizeof(RrPixel32));
+    p = im = g_memdup(data, width * height * sizeof(RrPixel32));
 
-    for (i = 0; i < OB_DEFAULT_ICON_WIDTH*OB_DEFAULT_ICON_HEIGHT; ++i) {
+    for (i = 0; i < width * height; ++i) {
         guchar a = ((*p >> 24) & 0xff);
         guchar b = ((*p >> 16) & 0xff);
         guchar g = ((*p >>  8) & 0xff);
This page took 0.060788 seconds and 4 git commands to generate.