clarify using stacking_lower for restoring the stacking order

[chaz/openbox] / render / font.c

diff --git a/render/font.c b/render/font.c
index c03ea544447f789008297e545a0e312714864cef..4436cf8430fb0b732e5fdb140221ef4e8a7d74cd 100644 (file)
--- a/render/font.c
+++ b/render/font.c
@@ -1,11 +1,12 @@
-#include <stdlib.h>
-#include <X11/Xft/Xft.h>
 #include "../kernel/openbox.h"
 #include "font.h"
 
-#include "../src/gettext.h"
+#include "../kernel/gettext.h"
 #define _(str) gettext(str)
 
+#include <X11/Xft/Xft.h>
+#include <glib.h>
+
 void font_startup(void)
 {
 #ifdef DEBUG
@@ -44,7 +45,7 @@ ObFont *font_open(char *fontstring)
     XftFont *xf;
     
     if ((xf = XftFontOpenName(ob_display, ob_screen, fontstring))) {
-        out = malloc(sizeof(ObFont));
+        out = g_new(ObFont, 1);
         out->xftfont = xf;
         measure_height(out);
         return out;
@@ -53,7 +54,7 @@ ObFont *font_open(char *fontstring)
     g_warning(_("Trying fallback font: %s\n"), "fixed");
 
     if ((xf = XftFontOpenName(ob_display, ob_screen, "fixed"))) {
-        out = malloc(sizeof(ObFont));
+        out = g_new(ObFont, 1);
         out->xftfont = xf;
         measure_height(out);
         return out;
@@ -61,15 +62,16 @@ ObFont *font_open(char *fontstring)
     g_warning(_("Unable to load font: %s\n"), "fixed");
     g_warning(_("Aborting!.\n"));
 
-    exit(3); // can't continue without a font
+    exit(3); /* can't continue without a font */
 }
 
 void font_close(ObFont *f)
 {
     XftFontClose(ob_display, f->xftfont);
+    g_free(f);
 }
 
-int font_measure_string(ObFont *f, const char *str, int shadow, int offset)
+int font_measure_string(ObFont *f, char *str, int shadow, int offset)
 {
     XGlyphInfo info;
 
@@ -94,7 +96,8 @@ void font_draw(XftDraw *d, TextureText *t, int x, int y, int w, int h)
     XftColor c;
 
     /* accomidate for areas bigger/smaller than Xft thinks the font is tall */
-    y += (h - t->font->xftfont->height) / 2;
+    y -= (2 * (t->font->xftfont->ascent + t->font->xftfont->descent) -
+          (t->font->height + h)) / 2;
 
     x += 3; /* XXX figure out X with justification */
 
@@ -102,7 +105,7 @@ void font_draw(XftDraw *d, TextureText *t, int x, int y, int w, int h)
         c.color.red = 0;
         c.color.green = 0;
         c.color.blue = 0;
-        c.color.alpha = t->tint | t->tint << 8; // transparent shadow
+        c.color.alpha = t->tint | t->tint << 8; /* transparent shadow */
         c.pixel = BlackPixel(ob_display, ob_screen);
   
         XftDrawStringUtf8(d, &c, t->font->xftfont, x + t->offset,
@@ -112,12 +115,11 @@ void font_draw(XftDraw *d, TextureText *t, int x, int y, int w, int h)
     c.color.red = t->color->r | t->color->r << 8;
     c.color.green = t->color->g | t->color->g << 8;
     c.color.blue = t->color->b | t->color->b << 8;
+    c.color.alpha = 0xff | 0xff << 8; /* fully opaque text */
     c.pixel = t->color->pixel;
-    c.color.alpha = 0xff | 0xff << 8; // no transparency in Color yet
                      
     XftDrawStringUtf8(d, &c, t->font->xftfont, x,
-                      t->font->xftfont->ascent + y -
-                      (t->font->xftfont->height - t->font->height) / 2,
-                     (FcChar8*)t->string, strlen(t->string));
+                      t->font->xftfont->ascent + y,
+                      (FcChar8*)t->string, strlen(t->string));
     return;
 }