declare vars at top

[chaz/openbox] / plugins / menu / fifo_menu.c

diff --git a/plugins/menu/fifo_menu.c b/plugins/menu/fifo_menu.c
index a05989f8964accd3981122609cb25eacf90ae027..3443294e2ced983b66c85e424956c6a71056bfb2 100644 (file)
--- a/plugins/menu/fifo_menu.c
+++ b/plugins/menu/fifo_menu.c
@@ -12,11 +12,12 @@
 
 static char *PLUGIN_NAME = "fifo_menu";
 
-typedef struct Fifo_Menu_Data{
+typedef struct Fifo_Menu_Data {
     char *fifo;
     char *buf; /* buffer to hold partially read menu */
     unsigned long buflen; /* how many bytes are in the buffer */
     int fd; /* file descriptor to read menu from */
+    gboolean use_pid;
     event_fd_handler *handler;
 } Fifo_Menu_Data;
 
@@ -78,20 +79,21 @@ void fifo_menu_handler(int fd, void *d) {
                         num_realloc);
 
         if (num_read == 0) { /* eof */
-            unsigned long count = 0;
-            char *found = NULL;
+            xmlDocPtr doc;
+            xmlNodePtr node;
 
             menu->invalid = TRUE;
             menu_clear(menu);
 
             FIFO_MENU_DATA(menu)->buf[FIFO_MENU_DATA(menu)->buflen] = '\0';
 
-            xmlDocPtr doc = xmlParseMemory(FIFO_MENU_DATA(menu)->buf,
-                                           FIFO_MENU_DATA(menu)->buflen);
+            doc = xmlParseMemory(FIFO_MENU_DATA(menu)->buf,
+                                 FIFO_MENU_DATA(menu)->buflen);
 
-            xmlNodePtr node = xmlDocGetRootElement(doc);
-
-            if (!xmlStrcasecmp(node->name, (const xmlChar*) "fifo")) {
+            node = xmlDocGetRootElement(doc);
+            
+            if (node &&
+                !xmlStrcasecmp(node->name, (const xmlChar*) "fifo_menu")) {
                 if ((node = parse_find_node("item", node->xmlChildrenNode)))
                     parse_menu_full(doc, node, menu, FALSE);
             }
@@ -131,14 +133,17 @@ void plugin_destroy (ObMenu *m)
         FIFO_MENU_DATA(m)->fifo = NULL;
     }
 
+    if (FIFO_MENU_DATA(m)->buf != NULL) {
+        g_free(FIFO_MENU_DATA(m)->buf);
+        FIFO_MENU_DATA(m)->buf = NULL;
+    }
+ 
     g_free(m->plugin_data);
 
     menu_free(m->name);
 }
 
 void *plugin_create(PluginMenuCreateData *data)
-
-
 {
     char *fifo;
     char *dir;
@@ -146,18 +151,27 @@ void *plugin_create(PluginMenuCreateData *data)
     Fifo_Menu_Data *d;
     ObMenu *m;
     char *label = NULL, *id = NULL;
+    char *attr_pid = NULL;
         
     d = g_new(Fifo_Menu_Data, 1);
 
     parse_attr_string("id", data->node, &id);
     parse_attr_string("label", data->node, &label);
-
+    
+    if (parse_attr_string("pid", data->node, &attr_pid) &&
+        g_strcasecmp(attr_pid, "true") == 0) {
+        d->use_pid = TRUE;
+    } else
+        d->use_pid = FALSE;
+    
     m = menu_new( (label != NULL ? label : ""),
-                 (id != NULL ? id : PLUGIN_NAME),
-                 data->parent);
-    menu_add_entry(data->parent, menu_entry_new_submenu(
-                       (label != NULL ? label : ""),
-                       m));
+                  (id != NULL ? id : PLUGIN_NAME),
+                  data->parent);
+
+    if (data->parent)
+        menu_add_entry(data->parent, menu_entry_new_submenu(
+                           (label != NULL ? label : ""),
+                           m));
 
     g_free(label);
     g_free(id);
@@ -172,6 +186,7 @@ void *plugin_create(PluginMenuCreateData *data)
     
     m->plugin_data = (void *)d;
 
+        
     dir = g_build_filename(g_get_home_dir(), ".openbox",
                           PLUGIN_NAME, NULL);
 
@@ -185,9 +200,19 @@ void *plugin_create(PluginMenuCreateData *data)
         return NULL;
     }
 
-    fifo = g_build_filename(g_get_home_dir(), ".openbox",
-                            PLUGIN_NAME,
-                            m->name, NULL);
+    if (d->use_pid)
+    {
+        char *pid = g_strdup_printf("%s.%d", m->name, getpid());
+        fifo = g_build_filename(g_get_home_dir(), ".openbox",
+                                PLUGIN_NAME,
+                                pid, NULL);
+        g_free(pid);
+    } else {
+        fifo = g_build_filename(g_get_home_dir(), ".openbox",
+                                PLUGIN_NAME,
+                                m->name, NULL);
+    }
+    
     if (mkfifo(fifo, S_IRUSR | S_IWUSR |
                S_IRGRP | S_IWGRP | /* let umask do its thing */
                S_IROTH | S_IWOTH) == -1 && errno != EEXIST) {