]> Dogcows Code - chaz/openbox/blobdiff - openbox/stacking.c
use g_[s]list_next/previous consistantly, and check for "it" instead of "it != NULL...
[chaz/openbox] / openbox / stacking.c
index c3d485f5427b96c1a3dab9b40d44cdc446d8dd11..c715eae04d9ec40f0815a1a1389a190c14098ecf 100644 (file)
@@ -1,11 +1,29 @@
+/* -*- indent-tabs-mode: nil; tab-width: 4; c-basic-offset: 4; -*-
+
+   stacking.c for the Openbox window manager
+   Copyright (c) 2003        Ben Jansens
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   See the COPYING file for a copy of the GNU General Public License.
+*/
+
 #include "openbox.h"
 #include "prop.h"
+#include "screen.h"
 #include "focus.h"
 #include "client.h"
 #include "group.h"
 #include "frame.h"
 #include "window.h"
-#include <glib.h>
 
 GList  *stacking_list = NULL;
 
@@ -18,7 +36,7 @@ void stacking_set_list()
     /* on shutdown, don't update the properties, so that we can read it back
        in on startup and re-stack the windows as they were before we shut down
     */
-    if (ob_state == OB_STATE_EXITING) return;
+    if (ob_state() == OB_STATE_EXITING) return;
 
     /* create an array of the window ids (from bottom to top,
        reverse order!) */
@@ -30,8 +48,8 @@ void stacking_set_list()
         }
     }
 
-    PROP_SETA32(ob_root, net_client_list_stacking, window,
-                (guint32*)windows, i);
+    PROP_SETA32(RootWindow(ob_display, ob_screen),
+                net_client_list_stacking, window, (guint32*)windows, i);
 
     g_free(windows);
 }
@@ -40,20 +58,23 @@ static void do_restack(GList *wins, GList *before)
 {
     GList *it, *next;
     Window *win;
-    int i;
+    gint i;
 
+#ifdef DEBUG
     /* pls only restack stuff in the same layer at a time */
     for (it = wins; it; it = next) {
         next = g_list_next(it);
         if (!next) break;
         g_assert (window_layer(it->data) == window_layer(next->data));
     }
-
+    if (before)
+        g_assert(window_layer(it->data) >= window_layer(before->data));
+#endif
 
     win = g_new(Window, g_list_length(wins) + 1);
 
     if (before == stacking_list)
-        win[0] = focus_backup;
+        win[0] = screen_support_win;
     else if (!before)
         win[0] = window_top(g_list_last(stacking_list)->data);
     else
@@ -66,12 +87,14 @@ static void do_restack(GList *wins, GList *before)
         stacking_list = g_list_insert_before(stacking_list, before, it->data);
     }
 
-    /* XXX some debug checking of the stacking list's order */
+#ifdef DEBUG
+    /* some debug checking of the stacking list's order */
     for (it = stacking_list; ; it = next) {
         next = g_list_next(it);
         if (!next) break;
         g_assert(window_layer(it->data) >= window_layer(next->data));
     }
+#endif
 
     XRestackWindows(ob_display, win, i);
     g_free(win);
@@ -82,22 +105,22 @@ static void do_restack(GList *wins, GList *before)
 static void do_raise(GList *wins)
 {
     GList *it;
-    GList *layer[NUM_STACKLAYER] = {NULL};
-    int i;
+    GList *layer[OB_NUM_STACKING_LAYERS] = {NULL};
+    gint i;
 
     for (it = wins; it; it = g_list_next(it)) {
-        StackLayer l;
+        ObStackingLayer l;
 
         l = window_layer(it->data);
         layer[l] = g_list_append(layer[l], it->data);
     }
 
     it = stacking_list;
-    for (i = NUM_STACKLAYER - 1; i >= 0; --i) {
+    for (i = OB_NUM_STACKING_LAYERS - 1; i >= 0; --i) {
         if (layer[i]) {
             for (; it; it = g_list_next(it)) {
                 /* look for the top of the layer */
-                if (window_layer(it->data) <= (StackLayer) i)
+                if (window_layer(it->data) <= (ObStackingLayer) i)
                     break;
             }
             do_restack(layer[i], it);
@@ -109,22 +132,22 @@ static void do_raise(GList *wins)
 static void do_lower(GList *wins)
 {
     GList *it;
-    GList *layer[NUM_STACKLAYER] = {NULL};
-    int i;
+    GList *layer[OB_NUM_STACKING_LAYERS] = {NULL};
+    gint i;
 
     for (it = wins; it; it = g_list_next(it)) {
-        StackLayer l;
+        ObStackingLayer l;
 
         l = window_layer(it->data);
         layer[l] = g_list_append(layer[l], it->data);
     }
 
     it = stacking_list;
-    for (i = NUM_STACKLAYER - 1; i >= 0; --i) {
+    for (i = OB_NUM_STACKING_LAYERS - 1; i >= 0; --i) {
         if (layer[i]) {
             for (; it; it = g_list_next(it)) {
                 /* look for the top of the next layer down */
-                if (window_layer(it->data) < (StackLayer) i)
+                if (window_layer(it->data) < (ObStackingLayer) i)
                     break;
             }
             do_restack(layer[i], it);
@@ -133,19 +156,22 @@ static void do_lower(GList *wins)
     }
 }
 
-static GList *pick_windows(Client *top, Client *selected, gboolean raise)
+static GList *pick_windows(ObClient *top, ObClient *selected, gboolean raise)
 {
     GList *ret = NULL;
     GList *it, *next, *prev;
     GSList *sit;
-    int i, n;
+    gint i, n;
     GList *modals = NULL;
     GList *trans = NULL;
-    GList *modal_sel_it = NULL; /* the selected guy if modal */
-    GList *trans_sel_it = NULL; /* the selected guy if not */
+    GList *modal_sel = NULL; /* the selected guys if modal */
+    GList *trans_sel = NULL; /* the selected guys if not */
 
     /* remove first so we can't run into ourself */
-    stacking_list = g_list_remove(stacking_list, top);
+    if ((it = g_list_find(stacking_list, top)))
+        stacking_list = g_list_delete_link(stacking_list, it);
+    else
+        return NULL;
 
     i = 0;
     n = g_slist_length(top->transients);
@@ -154,27 +180,33 @@ static GList *pick_windows(Client *top, Client *selected, gboolean raise)
         next = g_list_next(it);
 
         if ((sit = g_slist_find(top->transients, it->data))) {
-            Client *c = sit->data;
+            ObClient *c = sit->data;
+            gboolean sel_child;
 
             ++i;
 
+            if (c == selected)
+                sel_child = TRUE;
+            else
+                sel_child = client_search_transient(c, selected) != NULL;
+
             if (!c->modal) {
-                if (c != selected) {
+                if (!sel_child) {
                     trans = g_list_concat(trans,
-                                           pick_windows(c, selected, raise));
+                                          pick_windows(c, selected, raise));
                 } else {
-                    g_assert(modal_sel_it == NULL);
-                    g_assert(trans_sel_it == NULL);
-                    trans_sel_it = pick_windows(c, selected, raise);
+                    trans_sel = g_list_concat(trans_sel,
+                                                 pick_windows(c, selected,
+                                                              raise));
                 }
             } else {
-                if (c != selected) {
+                if (!sel_child) {
                     modals = g_list_concat(modals,
                                            pick_windows(c, selected, raise));
                 } else {
-                    g_assert(modal_sel_it == NULL);
-                    g_assert(trans_sel_it == NULL);
-                    modal_sel_it = pick_windows(c, selected, raise);
+                    modal_sel = g_list_concat(modal_sel,
+                                                 pick_windows(c, selected,
+                                                              raise));
                 }
             }
             /* if we dont have a prev then start back at the beginning,
@@ -183,11 +215,11 @@ static GList *pick_windows(Client *top, Client *selected, gboolean raise)
         }
     }
 
-    ret = g_list_concat((raise ? modal_sel_it : modals),
-                        (raise ? modals : modal_sel_it));
+    ret = g_list_concat((raise ? modal_sel : modals),
+                        (raise ? modals : modal_sel));
 
-    ret = g_list_concat(ret, (raise ? trans_sel_it : trans));
-    ret = g_list_concat(ret, (raise ? trans : trans_sel_it));
+    ret = g_list_concat(ret, (raise ? trans_sel : trans));
+    ret = g_list_concat(ret, (raise ? trans : trans_sel));
 
 
     /* add itself */
@@ -196,12 +228,13 @@ static GList *pick_windows(Client *top, Client *selected, gboolean raise)
     return ret;
 }
 
-static GList *pick_group_windows(Client *top, Client *selected, gboolean raise)
+static GList *pick_group_windows(ObClient *top, ObClient *selected,
+                                 gboolean raise)
 {
     GList *ret = NULL;
     GList *it, *next, *prev;
     GSList *sit;
-    int i, n;
+    gint i, n;
 
     /* add group members in their stacking order */
     if (top->group) {
@@ -212,12 +245,26 @@ static GList *pick_group_windows(Client *top, Client *selected, gboolean raise)
             next = g_list_next(it);
 
             if ((sit = g_slist_find(top->group->members, it->data))) {
+                ObClient *c;
+                ObClientType t;
+
                 ++i;
-                ret = g_list_concat(ret,
-                                    pick_windows(sit->data, selected, raise)); 
-                /* if we dont have a prev then start back at the beginning,
-                   otherwise skip back to the prev's next */
-                next = prev ? g_list_next(prev) : stacking_list;
+                c = it->data;
+                t = c->type;
+
+                if ((c->desktop == selected->desktop ||
+                     c->desktop == DESKTOP_ALL) &&
+                    (t == OB_CLIENT_TYPE_TOOLBAR ||
+                     t == OB_CLIENT_TYPE_MENU ||
+                     t == OB_CLIENT_TYPE_UTILITY))
+                {
+                    ret = g_list_concat(ret,
+                                        pick_windows(sit->data,
+                                                     selected, raise)); 
+                    /* if we dont have a prev then start back at the beginning,
+                       otherwise skip back to the prev's next */
+                    next = prev ? g_list_next(prev) : stacking_list;
+                }
             }
         }
     }
@@ -229,8 +276,8 @@ void stacking_raise(ObWindow *window)
     GList *wins;
 
     if (WINDOW_IS_CLIENT(window)) {
-        Client *c;
-        Client *selected;
+        ObClient *c;
+        ObClient *selected;
         selected = WINDOW_AS_CLIENT(window);
         c = client_search_top_transient(selected);
         wins = pick_windows(c, selected, TRUE);
@@ -248,8 +295,8 @@ void stacking_lower(ObWindow *window)
     GList *wins;
 
     if (WINDOW_IS_CLIENT(window)) {
-        Client *c;
-        Client *selected;
+        ObClient *c;
+        ObClient *selected;
         selected = WINDOW_AS_CLIENT(window);
         c = client_search_top_transient(selected);
         wins = pick_windows(c, selected, FALSE);
@@ -262,12 +309,26 @@ void stacking_lower(ObWindow *window)
     g_list_free(wins);
 }
 
+void stacking_below(ObWindow *window, ObWindow *below)
+{
+    GList *wins, *before;
+
+    if (window_layer(window) != window_layer(below))
+        return;
+
+    wins = g_list_append(NULL, window);
+    stacking_list = g_list_remove(stacking_list, window);
+    before = g_list_next(g_list_find(stacking_list, below));
+    do_restack(wins, before);
+    g_list_free(wins);
+}
+
 void stacking_add(ObWindow *win)
 {
-    StackLayer l;
+    ObStackingLayer l;
     GList *wins;
 
-    g_assert(focus_backup != None); /* make sure I dont break this in the
+    g_assert(screen_support_win != None); /* make sure I dont break this in the
                                        future */
 
     l = window_layer(win);
@@ -279,8 +340,8 @@ void stacking_add(ObWindow *win)
 
 void stacking_add_nonintrusive(ObWindow *win)
 {
-    Client *client;
-    Client *parent = NULL;
+    ObClient *client;
+    ObClient *parent = NULL;
     GList *it_before = NULL;
 
     if (!WINDOW_IS_CLIENT(win)) {
@@ -292,18 +353,19 @@ void stacking_add_nonintrusive(ObWindow *win)
 
     /* insert above its highest parent */
     if (client->transient_for) {
-        if (client->transient_for != TRAN_GROUP) {
+        if (client->transient_for != OB_TRAN_GROUP) {
             parent = client->transient_for;
         } else {
             GSList *sit;
             GList *it;
 
             if (client->group)
-                for (it = stacking_list; !parent && it; it = it->next) {
+                for (it = stacking_list; !parent && it; it = g_list_next(it)) {
                     if ((sit = g_slist_find(client->group->members, it->data)))
                 for (sit = client->group->members; !parent && sit;
-                     sit = sit->next) {
-                    Client *c = sit->data;
+                     sit = g_slist_next(sit))
+                {
+                    ObClient *c = sit->data;
                     /* checking transient_for prevents infinate loops! */
                     if (sit->data == it->data && !c->transient_for)
                         parent = it->data;
This page took 0.030132 seconds and 4 git commands to generate.