CREATE(atom, "ATOM");
CREATE(string, "STRING");
CREATE(utf8, "UTF8_STRING");
+
+ CREATE(manager, "MANAGER");
CREATE(wm_colormap_windows, "WM_COLORMAP_WINDOWS");
CREATE(wm_protocols, "WM_PROTOCOLS");
CREATE(wm_window_role, "WM_WINDOW_ROLE");
CREATE(motif_wm_hints, "_MOTIF_WM_HINTS");
+ CREATE(sm_client_id, "SM_CLIENT_ID");
+
CREATE(net_supported, "_NET_SUPPORTED");
CREATE(net_client_list, "_NET_CLIENT_LIST");
CREATE(net_client_list_stacking, "_NET_CLIENT_LIST_STACKING");
CREATE(net_wm_window_type, "_NET_WM_WINDOW_TYPE");
CREATE(net_wm_state, "_NET_WM_STATE");
CREATE(net_wm_strut, "_NET_WM_STRUT");
+ CREATE(net_wm_strut_partial, "_NET_WM_STRUT_PARTIAL");
CREATE(net_wm_icon, "_NET_WM_ICON");
/* CREATE(net_wm_pid, "_NET_WM_PID"); */
CREATE(net_wm_allowed_actions, "_NET_WM_ALLOWED_ACTIONS");
((guint16*)data)[i] = ((guint16*)xdata)[i];
break;
case 32:
- ((guint32*)data)[i] = ((guint32*)xdata)[i];
+ ((guint32*)data)[i] = ((gulong*)xdata)[i];
break;
default:
g_assert_not_reached(); /* unhandled size */
((guint16*)*data)[i] = ((guint16*)xdata)[i];
break;
case 32:
- ((guint32*)*data)[i] = ((guint32*)xdata)[i];
+ ((guint32*)*data)[i] = ((gulong*)xdata)[i];
break;
default:
g_assert_not_reached(); /* unhandled size */
gboolean prop_get_strings_locale(Window win, Atom prop, char ***ret)
{
+ GSList *strs = NULL, *it;
char *raw, *p;
- guint num, i;
+ guint num, i, count = 0;
- if (get_all(win, prop, prop_atoms.string, 8, (guchar**)&raw, &num)){
- *ret = g_new(char*, num + 1);
- (*ret)[num] = NULL; /* null terminated list */
+ if (get_all(win, prop, prop_atoms.string, 8, (guchar**)&raw, &num)) {
p = raw;
- for (i = 0; i < num; ++i) {
- (*ret)[i] = g_convert(p, strlen(p), "UTF-8", "ISO-8859-1",
+ while (p < raw + num - 1) {
+ ++count;
+ strs = g_slist_append(strs, p);
+ p += strlen(p) + 1; /* next string */
+ }
+
+ *ret = g_new0(char*, count + 1);
+ (*ret)[count] = NULL; /* null terminated list */
+
+ for (i = 0, it = strs; it; ++i, it = g_slist_next(it)) {
+ (*ret)[i] = g_convert(it->data, -1, "UTF-8", "ISO-8859-1",
NULL, NULL, NULL);
/* make sure translation did not fail */
- if (!(*ret)[i]) {
- g_strfreev(*ret); /* free what we did so far */
- break; /* the force is not strong with us */
- }
- p = strchr(p, '\0');
+ if (!(*ret)[i])
+ (*ret)[i] = g_strdup("");
}
g_free(raw);
- if (i == num)
- return TRUE;
+ g_slist_free(strs);
+ return TRUE;
}
return FALSE;
}
gboolean prop_get_string_utf8(Window win, Atom prop, char **ret)
{
char *raw;
+ char *str;
guint num;
if (get_all(win, prop, prop_atoms.utf8, 8, (guchar**)&raw, &num)) {
- *ret = g_strndup(raw, num); /* grab the first string from the list */
+ str = g_strndup(raw, num); /* grab the first string from the list */
g_free(raw);
- return TRUE;
+ if (g_utf8_validate(str, -1, NULL)) {
+ *ret = str;
+ return TRUE;
+ }
+ g_free(str);
}
return FALSE;
}
gboolean prop_get_strings_utf8(Window win, Atom prop, char ***ret)
{
+ GSList *strs = NULL, *it;
char *raw, *p;
- guint num, i;
+ guint num, i, count = 0;
if (get_all(win, prop, prop_atoms.utf8, 8, (guchar**)&raw, &num)) {
- *ret = g_new(char*, num + 1);
- (*ret)[num] = NULL; /* null terminated list */
p = raw;
- for (i = 0; i < num; ++i) {
- (*ret)[i] = g_strdup(p);
- p = strchr(p, '\0');
+ while (p < raw + num - 1) {
+ ++count;
+ strs = g_slist_append(strs, p);
+ p += strlen(p) + 1; /* next string */
+ }
+
+ *ret = g_new0(char*, count + 1);
+
+ for (i = 0, it = strs; it; ++i, it = g_slist_next(it)) {
+ if (g_utf8_validate(it->data, -1, NULL))
+ (*ret)[i] = g_strdup(it->data);
+ else
+ (*ret)[i] = g_strdup("");
}
g_free(raw);
+ g_slist_free(strs);
return TRUE;
}
return FALSE;
}
void prop_message(Window about, Atom messagetype, long data0, long data1,
- long data2, long data3)
+ long data2, long data3, long mask)
{
XEvent ce;
ce.xclient.type = ClientMessage;
ce.xclient.data.l[1] = data1;
ce.xclient.data.l[2] = data2;
ce.xclient.data.l[3] = data3;
- XSendEvent(ob_display, ob_root, FALSE,
- SubstructureNotifyMask | SubstructureRedirectMask, &ce);
+ XSendEvent(ob_display, RootWindow(ob_display, ob_screen), FALSE,
+ mask, &ce);
}