woot sexy

[chaz/openbox] / openbox / place.c

diff --git a/openbox/place.c b/openbox/place.c
index 3edb82c9b4681419bb89c3faf39bedb2332800f5..cf03b72d6874690977f9f5e2a5d1ce2cb5d8f204 100644 (file)
--- a/openbox/place.c
+++ b/openbox/place.c
@@ -32,7 +32,7 @@ static Rect* pick_head(ObClient *c)
     }
 
     /* more than one guy in his group (more than just him) */
-    if (c->group && c->group->members->next) {
+    if (client_has_group_siblings(c)) {
         GSList *it;
 
         /* try on the client's desktop */
@@ -160,7 +160,7 @@ static gint area_cmp(gconstpointer p1, gconstpointer p2, gpointer data)
     }
 
     /* has to be more than me in the group */
-    if (diffhead && c->group && c->group->members->next) {
+    if (diffhead && client_has_group_siblings(c)) {
         guint *num, most;
         GSList *it;
 
@@ -194,7 +194,7 @@ typedef enum
 } ObSmartType;
 
 #define SMART_IGNORE(placer, c) \
-    (placer == c || !c->visible || c->shaded || !client_normal(c) || \
+    (placer == c || !c->frame->visible || c->shaded || !client_normal(c) || \
      (c->desktop != DESKTOP_ALL && \
       c->desktop != (placer->desktop == DESKTOP_ALL ? \
                      screen_desktop : placer->desktop)))
@@ -219,8 +219,7 @@ static gboolean place_smart(ObClient *client, gint *x, gint *y,
                            screen_desktop : client->desktop];
         foc = list ? list->data : NULL;
 
-        for (it = stacking_list; it && !stop; it = g_list_next(it))
-        {
+        for (it = stacking_list; it && !stop; it = g_list_next(it)) {
             ObClient *c;
 
             if (WINDOW_IS_CLIENT(it->data))
@@ -242,7 +241,7 @@ static gboolean place_smart(ObClient *client, gint *x, gint *y,
         }
     } else if (type == SMART_GROUP) {
         /* has to be more than me in the group */
-        if (!client->group || !client->group->members->next)
+        if (!client_has_group_siblings(client))
             return FALSE;
 
         for (sit = client->group->members; sit; sit = g_slist_next(sit)) {
@@ -250,6 +249,22 @@ static gboolean place_smart(ObClient *client, gint *x, gint *y,
             if (!SMART_IGNORE(client, c))
                 spaces = area_remove(spaces, &c->frame->area);
         }
+
+        /* stay out from under windows in higher layers */
+        for (it = stacking_list; it; it = g_list_next(it)) {
+            ObClient *c;
+
+            if (WINDOW_IS_CLIENT(it->data))
+                c = it->data;
+            else
+                continue;
+
+            if (c->layer > client->layer) {
+                if (!SMART_IGNORE(client, c))
+                    spaces = area_remove(spaces, &c->frame->area);
+            } else
+                break;
+        }
     } else
         g_assert_not_reached();
 
@@ -372,13 +387,13 @@ void place_client(ObClient *client, gint *x, gint *y)
 {
     if (client->positioned)
         return;
-    if (place_transient(client, x, y)            ||
-        place_dialog(client, x, y)               ||
-        place_smart(client, x, y, SMART_FULL)    ||
-        place_smart(client, x, y, SMART_GROUP)   ||
-        place_smart(client, x, y, SMART_FOCUSED) ||
-        (config_focus_follow ?
+    if (place_transient(client, x, y)             ||
+        place_dialog(client, x, y)                ||
+        ((config_place_policy == OB_PLACE_POLICY_MOUSE) ?
          place_under_mouse(client, x, y) :
+         place_smart(client, x, y, SMART_FULL)    ||
+         place_smart(client, x, y, SMART_GROUP)   ||
+         place_smart(client, x, y, SMART_FOCUSED) ||
          place_random(client, x, y)))
     {
         /* get where the client should be */