#define PING_TIMEOUT (G_USEC_PER_SEC * 3)
/*! Warn the user after this many PING_TIMEOUT intervals */
-#define PING_TIMEOUT_WARN 3
+#define PING_TIMEOUT_WARN 2
static void ping_send(ObPingTarget *t);
static void ping_end(ObClient *client, gpointer data);
{
ObPingTarget *t;
- /* make sure we're not already pinging the client */
- g_assert(g_hash_table_find(ping_ids, find_client, client) == NULL);
-
+ /* make sure the client supports ping! */
g_assert(client->ping == TRUE);
- t = g_new0(ObPingTarget, 1);
+ /* make sure we're not already pinging the client */
+ if (g_hash_table_find(ping_ids, find_client, client) != NULL) return;
+
+ t = g_slice_new0(ObPingTarget);
t->client = client;
t->h = h;
g_assert(g_hash_table_find(ping_ids, find_client, client) != NULL);
}
-void ping_stop(struct _ObClient *c)
-{
- ping_end(c, NULL);
-}
-
void ping_got_pong(guint32 id)
{
ObPingTarget *t;
if ((t = g_hash_table_lookup(ping_ids, &id))) {
- /*ob_debug("-PONG: '%s' (id %u)\n", t->client->title, t->id);*/
+ /*ob_debug("-PONG: '%s' (id %u)", t->client->title, t->id);*/
if (t->waiting > PING_TIMEOUT_WARN) {
/* we had notified that they weren't responding, so now we
need to notify that they are again */
t->h(t->client, FALSE);
}
t->waiting = 0; /* not waiting for a reply anymore */
+
+ /* we got a pong so we're happy now */
+ ping_end(t->client, NULL);
}
else
- ob_debug("Got PONG with id %u but not waiting for one\n", id);
+ ob_debug("Got PONG with id %u but not waiting for one", id);
}
static gboolean find_client(gpointer key, gpointer value, gpointer client)
g_hash_table_insert(ping_ids, &t->id, t);
}
- /*ob_debug("+PING: '%s' (id %u)\n", t->client->title, t->id);*/
+ /*ob_debug("+PING: '%s' (id %u)", t->client->title, t->id);*/
OBT_PROP_MSG_TO(t->client->window, t->client->window, WM_PROTOCOLS,
OBT_PROP_ATOM(NET_WM_PING), t->id, t->client->window, 0, 0,
NoEventMask);
obt_main_loop_timeout_remove_data(ob_main_loop, ping_timeout,
t, FALSE);
- g_free(t);
+ g_slice_free(ObPingTarget, t);
}
}