#include "screen.h"
#include "prop.h"
#include "actions.h"
+#include "event.h"
#include "grab.h"
#include "openbox.h"
#include "mainloop.h"
ObMenuFrame *frame);
static void menu_entry_frame_free(ObMenuEntryFrame *self);
static void menu_frame_update(ObMenuFrame *self);
-static gboolean menu_entry_frame_submenu_hide_timeout(gpointer data);
-static gboolean menu_entry_frame_submenu_show_timeout(gpointer data);
+static gboolean menu_entry_frame_submenu_timeout(gpointer data);
static void menu_frame_hide(ObMenuFrame *self);
+static gboolean menu_entry_frame_submenu_hide_timeout(gpointer data);
+
static Window createWindow(Window parent, gulong mask,
XSetWindowAttributes *attrib)
{
self->type = Window_Menu;
self->menu = menu;
self->selected = NULL;
- self->open_submenu = NULL;
self->client = client;
self->direction_right = TRUE;
self->show_from = show_from;
gboolean mouse)
{
gint px, py;
- guint i;
if (menu_frame_is_visible(self))
return TRUE;
return TRUE;
}
+static void remove_submenu_hide_timeout(ObMenuFrame *self /* parent of submenu to hide */)
+{
+ ob_main_loop_timeout_remove(ob_main_loop,
+ menu_entry_frame_submenu_hide_timeout);
+ if (self)
+ self->submenu_to_hide = NULL;
+}
+
gboolean menu_frame_show_submenu(ObMenuFrame *self, ObMenuFrame *parent,
ObMenuEntryFrame *parent_entry)
{
self->monitor = parent->monitor;
self->parent = parent;
self->parent_entry = parent_entry;
- parent->open_submenu = parent_entry;
+
+ remove_submenu_hide_timeout(parent);
/* set up parent's child to be us */
- if (parent->child)
- menu_frame_hide(parent->child);
- parent->child = self;
+ if ((parent->child) != self) {
+ if (parent->child)
+ menu_frame_hide(parent->child);
+ parent->child = self;
+ }
if (!menu_frame_show(self))
return FALSE;
static void menu_frame_hide(ObMenuFrame *self)
{
GList *it = g_list_find(menu_frame_visible, self);
+ gulong ignore_start;
+
+ remove_submenu_hide_timeout(self->parent);
if (!it)
return;
if (self->child)
menu_frame_hide(self->child);
- if (self->parent && self->parent->child == self) {
+ if (self->parent)
self->parent->child = NULL;
- self->parent->open_submenu = NULL;
- }
self->parent = NULL;
self->parent_entry = NULL;
ungrab_keyboard();
}
+ ignore_start = event_start_ignore_all_enters();
XUnmapWindow(ob_display, self->window);
+ event_end_ignore_all_enters(ignore_start);
menu_frame_free(self);
}
if (config_submenu_show_delay) {
/* remove any submenu open requests */
ob_main_loop_timeout_remove(ob_main_loop,
- menu_entry_frame_submenu_show_timeout);
- /* remove any submenu close delays */
- ob_main_loop_timeout_remove(ob_main_loop,
- menu_entry_frame_submenu_hide_timeout);
+ menu_entry_frame_submenu_timeout);
}
if ((it = g_list_last(menu_frame_visible)))
menu_frame_hide(it->data);
if (f->client == client) {
if (config_submenu_show_delay) {
/* remove any submenu open requests */
- ob_main_loop_timeout_remove
- (ob_main_loop,
- menu_entry_frame_submenu_show_timeout);
- /* remove any submenu close delays */
- ob_main_loop_timeout_remove
- (ob_main_loop,
- menu_entry_frame_submenu_hide_timeout);
+ ob_main_loop_timeout_remove(ob_main_loop,
+ menu_entry_frame_submenu_timeout);
}
menu_frame_hide(f);
}
for (it = frame->entries; it; it = g_list_next(it)) {
ObMenuEntryFrame *e = it->data;
+
if (RECT_CONTAINS(e->area, x, y)) {
ret = e;
break;
return ret;
}
-static gboolean menu_entry_frame_submenu_hide_timeout(gpointer data)
+static gboolean menu_entry_frame_submenu_timeout(gpointer data)
{
g_assert(menu_frame_visible);
- g_assert(((ObMenuFrame*)data)->parent != NULL);
- menu_frame_hide((ObMenuFrame*)data);
+ menu_entry_frame_show_submenu((ObMenuEntryFrame*)data);
return FALSE;
}
-static gboolean menu_entry_frame_submenu_show_timeout(gpointer data)
+static gboolean menu_entry_frame_submenu_hide_timeout(gpointer data)
{
- g_assert(menu_frame_visible);
- menu_entry_frame_show_submenu((ObMenuEntryFrame*)data);
+ menu_frame_hide((ObMenuFrame*)data);
return FALSE;
}
{
ObMenuEntryFrame *old = self->selected;
ObMenuFrame *oldchild = self->child;
+ ObMenuEntryFrame *temp;
+ gboolean reselection;
+
+
+ if (!oldchild) {
+ /* self is the last visible (sub)menu */
+ if (self->parent && self->parent_entry != self->parent->selected) {
+ /* Legend:
+ (config_submenu_hide_delay != 0)
+ In the parent menu corresponding entry "A" selected,
+ this submenu ('self') shown, cursor moved in the parent
+ menu to another entry "B", then cursor moved for the
+ first time into this submenu.
+ Results:
+ parent menu selection is "B" instead of "A",
+ */
+ temp = self->parent->selected;
+ self->parent->selected = self->parent_entry;
+ if (temp)
+ menu_entry_frame_render(temp);
+ menu_entry_frame_render(self->parent_entry);
+ }
+ remove_submenu_hide_timeout(self->parent);
+ }
+ else if (oldchild->child) {
+ /* self is the (at least) grandparent of the last visible submenu */
+ menu_frame_hide(oldchild->child);
+ if (temp = oldchild->selected) {
+ oldchild->selected = NULL;
+ menu_entry_frame_render(temp);
+ }
+ }
+
if (entry && entry->entry->type == OB_MENU_ENTRY_TYPE_SEPARATOR)
entry = old;
if (config_submenu_show_delay) {
/* remove any submenu open requests */
ob_main_loop_timeout_remove(ob_main_loop,
- menu_entry_frame_submenu_show_timeout);
- }
-
- if (!entry && self->open_submenu) {
- entry = self->open_submenu;
- oldchild = NULL;
-
- /* remove any submenu close delays */
- ob_main_loop_timeout_remove(ob_main_loop,
- menu_entry_frame_submenu_hide_timeout);
+ menu_entry_frame_submenu_timeout);
}
self->selected = entry;
if (old)
menu_entry_frame_render(old);
+ reselection = FALSE;
if (oldchild) {
- /* there is an open submenu */
-
- if (config_submenu_show_delay && !immediate) {
- if (old == self->open_submenu) {
- /* close the open submenu after a delay if we don't have
- it selected */
- ob_main_loop_timeout_remove
- (ob_main_loop,
- menu_entry_frame_submenu_hide_timeout);
+ if (self->submenu_to_hide == entry) {
+ /* Legend:
+ (config_submenu_hide_delay != 0)
+ Some entry "A" selected; corresponding submenu shown;
+ cursor moved to another entry "B" and moved back
+ to the entry "A", when submenu hide request added,
+ but submenu not hided.
+ */
+ reselection = TRUE;
+ remove_submenu_hide_timeout(self);
+ }
+ else if (!immediate && config_submenu_hide_delay) {
+ if (self->submenu_to_hide == NULL) {
ob_main_loop_timeout_add(ob_main_loop,
- config_submenu_show_delay * 1000,
- menu_entry_frame_submenu_hide_timeout,
- self->child, g_direct_equal,
- NULL);
+ config_submenu_hide_delay * 1000,
+ menu_entry_frame_submenu_hide_timeout,
+ oldchild, g_direct_equal,
+ NULL);
+ self->submenu_to_hide = old;
}
}
else
if (self->selected) {
menu_entry_frame_render(self->selected);
- /* if we've selected a submenu and it wasn't always open, then
- show it */
- if (self->selected->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU &&
- self->selected != self->open_submenu)
+ if (!reselection &&
+ (self->selected->entry->type == OB_MENU_ENTRY_TYPE_SUBMENU))
{
if (config_submenu_show_delay && !immediate) {
/* initiate a new submenu open request */
ob_main_loop_timeout_add(ob_main_loop,
config_submenu_show_delay * 1000,
- menu_entry_frame_submenu_show_timeout,
+ menu_entry_frame_submenu_timeout,
self->selected, g_direct_equal,
NULL);
} else {
projects / chaz / openbox / blobdiff