revert my commit of d3th, it fucked up focus badly

[chaz/openbox] / openbox / mainloop.c

diff --git a/openbox/mainloop.c b/openbox/mainloop.c
index 6061a4606f50902e7f242d378b768e084015b326..9ee2075784fa5c8420cad8224141fdc067419574 100644 (file)
--- a/openbox/mainloop.c
+++ b/openbox/mainloop.c
@@ -566,16 +566,25 @@ static gboolean nearest_timeout_wait(ObMainLoop *loop, GTimeVal *tm)
 
 static void timer_dispatch(ObMainLoop *loop, GTimeVal **wait)
 {
+    GSList *it, *next;
+
+    gboolean fired = FALSE;
+
     g_get_current_time(&loop->now);
 
-    while (loop->timers != NULL) {
-       ObMainLoopTimer *curr = loop->timers->data; /* get the top element */
+    for (it = loop->timers; it; it = next) {
+       ObMainLoopTimer *curr;
+        
+        next = g_slist_next(it);
+
+       curr = it->data;
+
        /* since timer_stop doesn't actually free the timer, we have to do our
           real freeing in here.
        */
        if (curr->del_me) {
             /* delete the top */
-           loop->timers = g_slist_delete_link(loop->timers, loop->timers); 
+           loop->timers = g_slist_delete_link(loop->timers, it); 
            g_free(curr);
            continue;
        }
@@ -589,24 +598,27 @@ static void timer_dispatch(ObMainLoop *loop, GTimeVal **wait)
           then re-insert.  timers maintain their order and may trigger more
           than once if they've waited more than one delay's worth of time.
        */
-       loop->timers = g_slist_delete_link(loop->timers, loop->timers);
+       loop->timers = g_slist_delete_link(loop->timers, it);
        g_time_val_add(&curr->last, curr->delay);
        if (curr->func(curr->data)) {
             g_time_val_add(&curr->timeout, curr->delay);
             insert_timer(loop, curr);
         } else {
-            curr->del_me = TRUE;
+            if (curr->destroy)
+                curr->destroy(curr->data);
+            g_free(curr);
         }
 
+        fired = TRUE;
+    }
+
+    if (fired) {
        /* if at least one timer fires, then don't wait on X events, as there
           may already be some in the queue from the timer callbacks.
        */
        loop->ret_wait.tv_sec = loop->ret_wait.tv_usec = 0;
        *wait = &loop->ret_wait;
-       return;
-    }
-
-    if (nearest_timeout_wait(loop, &loop->ret_wait))
+    } else if (nearest_timeout_wait(loop, &loop->ret_wait))
        *wait = &loop->ret_wait;
     else
        *wait = NULL;