Merge branch 'backport'

[chaz/openbox] / openbox / framerender.c

diff --git a/openbox/framerender.c b/openbox/framerender.c
index b86f469227a6fe332d6621c2bc7cfd1ec3a04aec..af6be016565332c88aac3a8f7a424db4321a4a83 100644 (file)
--- a/openbox/framerender.c
+++ b/openbox/framerender.c
@@ -34,6 +34,14 @@ static void framerender_close(ObFrame *self, RrAppearance *a);
 
 void framerender_frame(ObFrame *self)
 {
+    if (frame_iconify_animating(self))
+        return; /* delay redrawing until the animation is done */
+    if (!self->need_render)
+        return;
+    if (!self->visible)
+        return;
+    self->need_render = FALSE;
+
     {
         gulong px;
 
@@ -51,6 +59,14 @@ void framerender_frame(ObFrame *self)
         XClearWindow(ob_display, self->innerright);
         XSetWindowBackground(ob_display, self->innerbottom, px);
         XClearWindow(ob_display, self->innerbottom);
+        XSetWindowBackground(ob_display, self->innerbll, px);
+        XClearWindow(ob_display, self->innerbll);
+        XSetWindowBackground(ob_display, self->innerbrr, px);
+        XClearWindow(ob_display, self->innerbrr);
+        XSetWindowBackground(ob_display, self->innerblb, px);
+        XClearWindow(ob_display, self->innerblb);
+        XSetWindowBackground(ob_display, self->innerbrb, px);
+        XClearWindow(ob_display, self->innerbrb);
 
         px = (self->focused ?
               RrColorPixel(ob_rr_theme->frame_focused_border_color) :
@@ -71,8 +87,6 @@ void framerender_frame(ObFrame *self)
         XClearWindow(ob_display, self->titletopright);
         XSetWindowBackground(ob_display, self->titleright, px);
         XClearWindow(ob_display, self->titleright);
-        XSetWindowBackground(ob_display, self->titlebottom, px);
-        XClearWindow(ob_display, self->titlebottom);
 
         XSetWindowBackground(ob_display, self->handleleft, px);
         XClearWindow(ob_display, self->handleleft);
@@ -96,6 +110,15 @@ void framerender_frame(ObFrame *self)
         XClearWindow(ob_display, self->rgriptop);
         XSetWindowBackground(ob_display, self->rgripbottom, px);
         XClearWindow(ob_display, self->rgripbottom);
+
+        /* don't use the separator color for shaded windows */
+        if (!self->client->shaded)
+            px = (self->focused ?
+                  RrColorPixel(ob_rr_theme->title_separator_focused_color) :
+                  RrColorPixel(ob_rr_theme->title_separator_unfocused_color));
+
+        XSetWindowBackground(ob_display, self->titlebottom, px);
+        XClearWindow(ob_display, self->titlebottom);
     }
 
     if (self->decorations & OB_FRAME_DECOR_TITLEBAR) {
@@ -111,12 +134,12 @@ void framerender_frame(ObFrame *self)
                   (self->max_press ?
                    ob_rr_theme->a_toggled_focused_pressed_max :
                    (self->max_hover ?
-                    ob_rr_theme->a_toggled_hover_focused_max : 
+                    ob_rr_theme->a_toggled_hover_focused_max :
                     ob_rr_theme->a_toggled_focused_unpressed_max)) :
                   (self->max_press ?
                    ob_rr_theme->a_focused_pressed_max :
                    (self->max_hover ?
-                    ob_rr_theme->a_hover_focused_max : 
+                    ob_rr_theme->a_hover_focused_max :
                     ob_rr_theme->a_focused_unpressed_max))));
             n = self->a_icon;
             i = (!(self->decorations & OB_FRAME_DECOR_ICONIFY) ?
@@ -124,7 +147,7 @@ void framerender_frame(ObFrame *self)
                  (self->iconify_press ?
                   ob_rr_theme->a_focused_pressed_iconify :
                   (self->iconify_hover ?
-                   ob_rr_theme->a_hover_focused_iconify : 
+                   ob_rr_theme->a_hover_focused_iconify :
                    ob_rr_theme->a_focused_unpressed_iconify)));
             d = (!(self->decorations & OB_FRAME_DECOR_ALLDESKTOPS) ?
                  ob_rr_theme->a_disabled_focused_desk :
@@ -132,12 +155,12 @@ void framerender_frame(ObFrame *self)
                   (self->desk_press ?
                    ob_rr_theme->a_toggled_focused_pressed_desk :
                    (self->desk_hover ?
-                    ob_rr_theme->a_toggled_hover_focused_desk : 
+                    ob_rr_theme->a_toggled_hover_focused_desk :
                     ob_rr_theme->a_toggled_focused_unpressed_desk)) :
                   (self->desk_press ?
                    ob_rr_theme->a_focused_pressed_desk :
                    (self->desk_hover ?
-                    ob_rr_theme->a_hover_focused_desk : 
+                    ob_rr_theme->a_hover_focused_desk :
                     ob_rr_theme->a_focused_unpressed_desk))));
             s = (!(self->decorations & OB_FRAME_DECOR_SHADE) ?
                  ob_rr_theme->a_disabled_focused_shade :
@@ -145,19 +168,19 @@ void framerender_frame(ObFrame *self)
                   (self->shade_press ?
                    ob_rr_theme->a_toggled_focused_pressed_shade :
                    (self->shade_hover ?
-                    ob_rr_theme->a_toggled_hover_focused_shade : 
+                    ob_rr_theme->a_toggled_hover_focused_shade :
                     ob_rr_theme->a_toggled_focused_unpressed_shade)) :
                   (self->shade_press ?
                    ob_rr_theme->a_focused_pressed_shade :
                    (self->shade_hover ?
-                    ob_rr_theme->a_hover_focused_shade : 
+                    ob_rr_theme->a_hover_focused_shade :
                     ob_rr_theme->a_focused_unpressed_shade))));
             c = (!(self->decorations & OB_FRAME_DECOR_CLOSE) ?
                  ob_rr_theme->a_disabled_focused_close :
                  (self->close_press ?
                   ob_rr_theme->a_focused_pressed_close :
                   (self->close_hover ?
-                   ob_rr_theme->a_hover_focused_close : 
+                   ob_rr_theme->a_hover_focused_close :
                    ob_rr_theme->a_focused_unpressed_close)));
         } else {
             t = self->a_unfocused_title;
@@ -168,12 +191,12 @@ void framerender_frame(ObFrame *self)
                   (self->max_press ?
                    ob_rr_theme->a_toggled_unfocused_pressed_max :
                    (self->max_hover ?
-                    ob_rr_theme->a_toggled_hover_unfocused_max : 
+                    ob_rr_theme->a_toggled_hover_unfocused_max :
                     ob_rr_theme->a_toggled_unfocused_unpressed_max)) :
                   (self->max_press ?
                    ob_rr_theme->a_unfocused_pressed_max :
                    (self->max_hover ?
-                    ob_rr_theme->a_hover_unfocused_max : 
+                    ob_rr_theme->a_hover_unfocused_max :
                     ob_rr_theme->a_unfocused_unpressed_max))));
             n = self->a_icon;
             i = (!(self->decorations & OB_FRAME_DECOR_ICONIFY) ?
@@ -181,7 +204,7 @@ void framerender_frame(ObFrame *self)
                  (self->iconify_press ?
                   ob_rr_theme->a_unfocused_pressed_iconify :
                   (self->iconify_hover ?
-                   ob_rr_theme->a_hover_unfocused_iconify : 
+                   ob_rr_theme->a_hover_unfocused_iconify :
                    ob_rr_theme->a_unfocused_unpressed_iconify)));
             d = (!(self->decorations & OB_FRAME_DECOR_ALLDESKTOPS) ?
                  ob_rr_theme->a_disabled_unfocused_desk :
@@ -189,12 +212,12 @@ void framerender_frame(ObFrame *self)
                   (self->desk_press ?
                    ob_rr_theme->a_toggled_unfocused_pressed_desk :
                    (self->desk_hover ?
-                    ob_rr_theme->a_toggled_hover_unfocused_desk : 
+                    ob_rr_theme->a_toggled_hover_unfocused_desk :
                     ob_rr_theme->a_toggled_unfocused_unpressed_desk)) :
                   (self->desk_press ?
                    ob_rr_theme->a_unfocused_pressed_desk :
                    (self->desk_hover ?
-                    ob_rr_theme->a_hover_unfocused_desk : 
+                    ob_rr_theme->a_hover_unfocused_desk :
                     ob_rr_theme->a_unfocused_unpressed_desk))));
             s = (!(self->decorations & OB_FRAME_DECOR_SHADE) ?
                  ob_rr_theme->a_disabled_unfocused_shade :
@@ -202,19 +225,19 @@ void framerender_frame(ObFrame *self)
                   (self->shade_press ?
                    ob_rr_theme->a_toggled_unfocused_pressed_shade :
                    (self->shade_hover ?
-                    ob_rr_theme->a_toggled_hover_unfocused_shade : 
+                    ob_rr_theme->a_toggled_hover_unfocused_shade :
                     ob_rr_theme->a_toggled_unfocused_unpressed_shade)) :
                   (self->shade_press ?
                    ob_rr_theme->a_unfocused_pressed_shade :
                    (self->shade_hover ?
-                    ob_rr_theme->a_hover_unfocused_shade : 
+                    ob_rr_theme->a_hover_unfocused_shade :
                     ob_rr_theme->a_unfocused_unpressed_shade))));
             c = (!(self->decorations & OB_FRAME_DECOR_CLOSE) ?
                  ob_rr_theme->a_disabled_unfocused_close :
                  (self->close_press ?
                   ob_rr_theme->a_unfocused_pressed_close :
                   (self->close_hover ?
-                   ob_rr_theme->a_hover_unfocused_close : 
+                   ob_rr_theme->a_hover_unfocused_close :
                    ob_rr_theme->a_unfocused_unpressed_close)));
         }
         clear = ob_rr_theme->a_clear;
@@ -344,6 +367,7 @@ static void framerender_icon(ObFrame *self, RrAppearance *a)
         a->texture[0].type = RR_TEXTURE_RGBA;
         a->texture[0].data.rgba.width = icon->width;
         a->texture[0].data.rgba.height = icon->height;
+        a->texture[0].data.rgba.alpha = 0xff;
         a->texture[0].data.rgba.data = icon->data;
     } else
         a->texture[0].type = RR_TEXTURE_NONE;