]> Dogcows Code - chaz/openbox/blobdiff - openbox/frame.c
fix frame rendering to match layout fixes
[chaz/openbox] / openbox / frame.c
index 3059bc49204739317545dc326e5b3fa540ad767e..96e93ba0ad1612128bd7e8346b1cf396d97d5bf6 100644 (file)
@@ -55,6 +55,7 @@ static void layout_title(ObFrame *self);
 static void set_theme_statics(ObFrame *self);
 static void free_theme_statics(ObFrame *self);
 static gboolean frame_animate_iconify(gpointer self);
+static void frame_adjust_cursors(ObFrame *self);
 
 static Window createWindow(Window parent, Visual *visual,
                            gulong mask, XSetWindowAttributes *attrib)
@@ -329,8 +330,13 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
     oldsize = self->size;
 
     if (resized) {
+        /* do this before changing the frame's status like max_horz max_vert */
+        frame_adjust_cursors(self);
+
+        self->functions = self->client->functions;
         self->decorations = self->client->decorations;
         self->max_horz = self->client->max_horz;
+        self->max_vert = self->client->max_vert;
 
         if (self->decorations & OB_FRAME_DECOR_BORDER) {
             self->bwidth = ob_rr_theme->fbwidth;
@@ -340,20 +346,17 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
             self->bwidth = self->cbwidth_x = self->cbwidth_y = 0;
         }
         self->rbwidth = self->bwidth;
-        self->leftb = self->rightb = TRUE;
 
         if (self->max_horz) {
-            self->leftb = self->rightb = FALSE;
             self->cbwidth_x = 0;
-        }
-
-        self->width = self->client->area.width + self->cbwidth_x * 2;
-        self->width = MAX(self->width, 1); /* no lower than 1 */
+            self->width = self->client->area.width - self->bwidth * 2;
+        } else
+            self->width = self->client->area.width + self->cbwidth_x * 2;
 
         STRUT_SET(self->size,
-                  self->cbwidth_x + (self->leftb ? self->bwidth : 0),
+                  self->cbwidth_x + (!self->max_horz ? self->bwidth : 0),
                   self->cbwidth_y + self->bwidth,
-                  self->cbwidth_x + (self->rightb ? self->bwidth : 0),
+                  self->cbwidth_x + (!self->max_horz ? self->bwidth : 0),
                   self->cbwidth_y + self->bwidth);
 
         if (self->decorations & OB_FRAME_DECOR_TITLEBAR)
@@ -370,9 +373,8 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
             if (self->bwidth) {
                 XMoveResizeWindow(ob_display, self->titletop,
                                   ob_rr_theme->grip_width + self->bwidth, 0,
-                                  self->client->area.width +
-                                  self->cbwidth_x * 2 + self->bwidth * 2 -
-                                  (ob_rr_theme->grip_width + self->bwidth) * 2,
+                                  /* width + bwidth*2 - bwidth*2 - grips*2 */
+                                  self->width - ob_rr_theme->grip_width * 2,
                                   self->bwidth);
                 XMoveResizeWindow(ob_display, self->titletopleft,
                                   0, 0,
@@ -380,7 +382,7 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
                                   self->bwidth);
                 XMoveResizeWindow(ob_display, self->titletopright,
                                   self->client->area.width +
-                                  self->cbwidth_x * 2 + self->bwidth * 2 -
+                                  self->size.left + self->size.right -
                                   ob_rr_theme->grip_width - self->bwidth,
                                   0,
                                   ob_rr_theme->grip_width + self->bwidth,
@@ -389,15 +391,16 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
                 XMoveResizeWindow(ob_display, self->titleleft,
                                   0, self->bwidth,
                                   self->bwidth,
-                                  (self->leftb ?
+                                  (!self->max_horz ?
                                    ob_rr_theme->grip_width :
                                    self->size.top - self->bwidth));
                 XMoveResizeWindow(ob_display, self->titleright,
                                   self->client->area.width +
-                                  self->cbwidth_x * 2 + self->bwidth,
+                                  self->size.left + self->size.right -
                                   self->bwidth,
                                   self->bwidth,
-                                  (self->rightb ?
+                                  self->bwidth,
+                                  (!self->max_horz ?
                                    ob_rr_theme->grip_width :
                                    self->size.top - self->bwidth));
 
@@ -413,8 +416,7 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
                     XMoveResizeWindow(ob_display, self->titlebottom,
                                       self->bwidth,
                                       ob_rr_theme->title_height + self->bwidth,
-                                      self->client->area.width +
-                                      self->cbwidth_x * 2,
+                                      self->width,
                                       self->rbwidth);
 
                     XMapWindow(ob_display, self->titlebottom);
@@ -441,16 +443,17 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
                     XMoveResizeWindow(ob_display, self->topresize,
                                       ob_rr_theme->grip_width + self->bwidth,
                                       0,
-                                      self->width - (ob_rr_theme->grip_width +
-                                                     self->bwidth) * 2,
+                                      self->width - ob_rr_theme->grip_width *2,
                                       ob_rr_theme->paddingy + 1);
 
-                    XMoveWindow(ob_display, self->tltresize, 0, 0);
-                    XMoveWindow(ob_display, self->tllresize, 0, 0);
+                    XMoveWindow(ob_display, self->tltresize, self->bwidth, 0);
+                    XMoveWindow(ob_display, self->tllresize, self->bwidth, 0);
                     XMoveWindow(ob_display, self->trtresize,
-                                self->width - ob_rr_theme->grip_width, 0);
+                                self->bwidth + self->width -
+                                ob_rr_theme->grip_width, 0);
                     XMoveWindow(ob_display, self->trrresize,
-                                self->width - ob_rr_theme->paddingx - 1, 0);
+                                self->bwidth + self->width -
+                                ob_rr_theme->paddingx - 1, 0);
 
                     XMapWindow(ob_display, self->topresize);
                     XMapWindow(ob_display, self->tltresize);
@@ -487,11 +490,11 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
                                   0,
                                   self->size.top + self->client->area.height +
                                   self->size.bottom -
-                                  (self->leftb ?
+                                  (!self->max_horz ?
                                    ob_rr_theme->grip_width :
                                    self->size.bottom),
                                   self->bwidth,
-                                  (self->leftb ?
+                                  (!self->max_horz ?
                                    ob_rr_theme->grip_width :
                                    self->size.bottom));
                 XMoveResizeWindow(ob_display, self->rgripright,
@@ -499,11 +502,11 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
                                   self->size.right - self->bwidth,
                                   self->size.top + self->client->area.height +
                                   self->size.bottom -
-                                  (self->leftb ?
+                                  (!self->max_horz ?
                                    ob_rr_theme->grip_width :
                                    self->size.bottom),
                                   self->bwidth,
-                                  (self->rightb ?
+                                  (!self->max_horz ?
                                    ob_rr_theme->grip_width :
                                    self->size.bottom));
 
@@ -636,7 +639,7 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
                 XUnmapWindow(ob_display, self->handle);
             }
 
-            if (self->bwidth && self->leftb) {
+            if (self->bwidth && !self->max_horz) {
                 XMoveResizeWindow(ob_display, self->left,
                                   0,
                                   self->bwidth + ob_rr_theme->grip_width,
@@ -649,7 +652,7 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
             } else
                 XUnmapWindow(ob_display, self->left);
 
-            if (self->bwidth && self->rightb) {
+            if (self->bwidth && !self->max_horz) {
                 XMoveResizeWindow(ob_display, self->right,
                                   self->client->area.width +
                                   self->cbwidth_x * 2 + self->bwidth,
@@ -670,14 +673,13 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
                               self->size.top - self->cbwidth_y,
                               self->client->area.width +
                               self->cbwidth_x * 2 +
-                              (self->leftb ? self->bwidth : 0) +
-                              (self->rightb ? self->bwidth : 0),
+                              (!self->max_horz ? self->bwidth * 2 : 0),
                               self->client->area.height +
                               self->cbwidth_y * 2);
 
             /* move the plate */
             XMoveWindow(ob_display, self->plate,
-                        (self->leftb ? self->bwidth : 0) + self->cbwidth_x,
+                        (!self->max_horz ? self->bwidth : 0) + self->cbwidth_x,
                         self->cbwidth_y);
 
             /* when the client has StaticGravity, it likes to move around. */
@@ -743,13 +745,17 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
     if (resized && (self->decorations & OB_FRAME_DECOR_TITLEBAR))
         XResizeWindow(ob_display, self->label, self->label_width,
                       ob_rr_theme->label_height);
+}
 
-    /* set up cursors */
-    if (!fake &&
-        (self->functions & OB_CLIENT_FUNC_RESIZE) !=
-        (self->client->functions & OB_CLIENT_FUNC_RESIZE))
+static void frame_adjust_cursors(ObFrame *self)
+{
+    if ((self->functions & OB_CLIENT_FUNC_RESIZE) !=
+        (self->client->functions & OB_CLIENT_FUNC_RESIZE) ||
+        ((self->max_horz && self->max_vert) !=
+         (self->client->max_horz && self->client->max_vert)))
     {
-        gboolean r = self->client->functions & OB_CLIENT_FUNC_RESIZE;
+        gboolean r = (self->client->functions & OB_CLIENT_FUNC_RESIZE) &&
+            !(self->client->max_horz && self->client->max_vert);
         XSetWindowAttributes a;
 
         a.cursor = ob_cursor(r ? OB_CURSOR_NORTH : OB_CURSOR_NONE);
@@ -785,8 +791,6 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
         XChangeWindowAttributes(ob_display, self->rgripright, CWCursor, &a);
         XChangeWindowAttributes(ob_display, self->rgriptop, CWCursor, &a);
         XChangeWindowAttributes(ob_display, self->rgripbottom, CWCursor, &a);
-
-        self->functions = self->client->functions;
     }
 }
 
@@ -1199,26 +1203,55 @@ ObFrameContext frame_context(ObClient *client, Window win, gint x, gint y)
         return OB_FRAME_CONTEXT_CLIENT;
     }
 
-    if (win == self->title) {
-        /* when the user clicks in the corners of the titlebar and the client
-           is fully maximized, then treat it like they clicked in the
-           button that is there */
-        if (self->client->max_horz && self->client->max_vert &&
-            y < ob_rr_theme->paddingy + 1 + ob_rr_theme->button_size)
+    /* when the user clicks in the corners of the titlebar and the client
+       is fully maximized, then treat it like they clicked in the
+       button that is there */
+    if (self->max_horz && self->max_vert &&
+        (win == self->title ||
+         win == self->titleleft || win == self->titletopleft ||
+         win == self->titleright || win == self->titletopright))
+    {
+        /* get the mouse coords in reference to the whole frame */
+        gint fx = x;
+        gint fy = y;
+
+        /* these windows are down a border width from the top of the frame */
+        if (win == self->title ||
+            win == self->titleleft || win == self->titleright)
+            fy += self->bwidth;
+
+        /* title is a border width in from the edge */
+        if (win == self->title)
+            fx += self->bwidth;
+        /* titletopright is way to the right edge */
+        else if (win == self->titletopright)
+            fx += self->area.width - (ob_rr_theme->grip_width + self->bwidth);
+        /* titleright is even more way to the right edge */
+        else if (win == self->titleright)
+            fx += self->area.width - self->bwidth;
+
+        /* figure out if we're over the area that should be considered a
+           button */
+        if (fy < self->bwidth + ob_rr_theme->paddingy + 1 +
+            ob_rr_theme->button_size)
         {
-            if (x < ((ob_rr_theme->paddingx + 1) * 2 +
-                     ob_rr_theme->button_size)) {
+            if (fx < (self->bwidth + ob_rr_theme->paddingx + 1 +
+                      ob_rr_theme->button_size))
+            {
                 if (self->leftmost != OB_FRAME_CONTEXT_NONE)
                     return self->leftmost;
             }
-            else if (x > (self->width -
-                          (ob_rr_theme->paddingx + 1 +
-                           ob_rr_theme->button_size)))
+            else if (fx >= (self->area.width -
+                            (self->bwidth + ob_rr_theme->paddingx + 1 +
+                             ob_rr_theme->button_size)))
             {
                 if (self->rightmost != OB_FRAME_CONTEXT_NONE)
                     return self->rightmost;
             }
         }
+
+        /* there is no resizing maximized windows so make them the titlebar
+           context */
         return OB_FRAME_CONTEXT_TITLEBAR;
     }
 
@@ -1237,16 +1270,17 @@ ObFrameContext frame_context(ObClient *client, Window win, gint x, gint y)
     if (win == self->rgripright)        return OB_FRAME_CONTEXT_BLCORNER;
     if (win == self->rgriptop)          return OB_FRAME_CONTEXT_BLCORNER;
     if (win == self->rgripbottom)       return OB_FRAME_CONTEXT_BLCORNER;
+    if (win == self->title)             return OB_FRAME_CONTEXT_TITLEBAR;
+    if (win == self->titleleft)         return OB_FRAME_CONTEXT_TLCORNER;
+    if (win == self->titletopleft)      return OB_FRAME_CONTEXT_TLCORNER;
+    if (win == self->titleright)        return OB_FRAME_CONTEXT_TRCORNER;
+    if (win == self->titletopright)     return OB_FRAME_CONTEXT_TRCORNER;
     if (win == self->titletop)          return OB_FRAME_CONTEXT_TOP;
     if (win == self->topresize)         return OB_FRAME_CONTEXT_TOP;
     if (win == self->tltresize)         return OB_FRAME_CONTEXT_TLCORNER;
     if (win == self->tllresize)         return OB_FRAME_CONTEXT_TLCORNER;
-    if (win == self->titleleft)         return OB_FRAME_CONTEXT_TLCORNER;
-    if (win == self->titletopleft)      return OB_FRAME_CONTEXT_TLCORNER;
     if (win == self->trtresize)         return OB_FRAME_CONTEXT_TRCORNER;
     if (win == self->trrresize)         return OB_FRAME_CONTEXT_TRCORNER;
-    if (win == self->titleright)        return OB_FRAME_CONTEXT_TRCORNER;
-    if (win == self->titletopright)     return OB_FRAME_CONTEXT_TRCORNER;
     if (win == self->left)              return OB_FRAME_CONTEXT_LEFT;
     if (win == self->right)             return OB_FRAME_CONTEXT_RIGHT;
     if (win == self->max)               return OB_FRAME_CONTEXT_MAXIMIZE;
This page took 0.028901 seconds and 4 git commands to generate.