]> Dogcows Code - chaz/openbox/blobdiff - openbox/frame.c
80 cols
[chaz/openbox] / openbox / frame.c
index 5d7ec6c1b22f12060ed5ecd50831b08e7a03ba3c..2c1152ee0f3f1ee4b9614fd5a30abdb4eefa2ead 100644 (file)
@@ -1,6 +1,7 @@
 /* -*- indent-tabs-mode: nil; tab-width: 4; c-basic-offset: 4; -*-
 
    frame.c for the Openbox window manager
+   Copyright (c) 2006        Mikael Magnusson
    Copyright (c) 2003        Ben Jansens
 
    This program is free software; you can redistribute it and/or modify
@@ -37,7 +38,7 @@
                            EnterWindowMask | LeaveWindowMask)
 
 #define FRAME_HANDLE_Y(f) (f->innersize.top + f->client->area.height + \
-                          f->cbwidth_y)
+                           f->cbwidth_y)
 
 static void layout_title(ObFrame *self);
 static void flash_done(gpointer data);
@@ -47,10 +48,10 @@ static void set_theme_statics(ObFrame *self);
 static void free_theme_statics(ObFrame *self);
 
 static Window createWindow(Window parent, gulong mask,
-                          XSetWindowAttributes *attrib)
+                           XSetWindowAttributes *attrib)
 {
     return XCreateWindow(ob_display, parent, 0, 0, 1, 1, 0,
-                        RrDepth(ob_rr_inst), InputOutput,
+                         RrDepth(ob_rr_inst), InputOutput,
                          RrVisual(ob_rr_inst), mask, attrib);
                        
 }
@@ -66,9 +67,8 @@ ObFrame *frame_new()
     self->obscured = TRUE;
 
     /* create all of the decor windows */
-    mask = CWOverrideRedirect | CWEventMask;
+    mask = CWEventMask;
     attrib.event_mask = FRAME_EVENTMASK;
-    attrib.override_redirect = TRUE;
     self->window = createWindow(RootWindow(ob_display, ob_screen),
                                 mask, &attrib);
 
@@ -110,9 +110,9 @@ ObFrame *frame_new()
     XMapWindow(ob_display, self->label);
 
     self->max_press = self->close_press = self->desk_press = 
-       self->iconify_press = self->shade_press = FALSE;
+        self->iconify_press = self->shade_press = FALSE;
     self->max_hover = self->close_hover = self->desk_hover = 
-       self->iconify_hover = self->shade_hover = FALSE;
+        self->iconify_hover = self->shade_hover = FALSE;
 
     set_theme_statics(self);
 
@@ -219,41 +219,41 @@ void frame_adjust_shape(ObFrame *self)
     XRectangle xrect[2];
 
     if (!self->client->shaped) {
-       /* clear the shape on the frame window */
-       XShapeCombineMask(ob_display, self->window, ShapeBounding,
-                         self->innersize.left,
-                         self->innersize.top,
-                         None, ShapeSet);
+        /* clear the shape on the frame window */
+        XShapeCombineMask(ob_display, self->window, ShapeBounding,
+                          self->innersize.left,
+                          self->innersize.top,
+                          None, ShapeSet);
     } else {
-       /* make the frame's shape match the clients */
-       XShapeCombineShape(ob_display, self->window, ShapeBounding,
-                          self->innersize.left,
-                          self->innersize.top,
-                          self->client->window,
-                          ShapeBounding, ShapeSet);
-
-       num = 0;
-       if (self->decorations & OB_FRAME_DECOR_TITLEBAR) {
-           xrect[0].x = -ob_rr_theme->bwidth;
-           xrect[0].y = -ob_rr_theme->bwidth;
-           xrect[0].width = self->width + self->rbwidth * 2;
-           xrect[0].height = ob_rr_theme->title_height +
-               self->bwidth * 2;
-           ++num;
-       }
-
-       if (self->decorations & OB_FRAME_DECOR_HANDLE) {
-           xrect[1].x = -ob_rr_theme->bwidth;
-           xrect[1].y = FRAME_HANDLE_Y(self);
-           xrect[1].width = self->width + self->rbwidth * 2;
-           xrect[1].height = ob_rr_theme->handle_height +
-               self->bwidth * 2;
-           ++num;
-       }
-
-       XShapeCombineRectangles(ob_display, self->window,
-                               ShapeBounding, 0, 0, xrect, num,
-                               ShapeUnion, Unsorted);
+        /* make the frame's shape match the clients */
+        XShapeCombineShape(ob_display, self->window, ShapeBounding,
+                           self->innersize.left,
+                           self->innersize.top,
+                           self->client->window,
+                           ShapeBounding, ShapeSet);
+
+        num = 0;
+        if (self->decorations & OB_FRAME_DECOR_TITLEBAR) {
+            xrect[0].x = -ob_rr_theme->bwidth;
+            xrect[0].y = -ob_rr_theme->bwidth;
+            xrect[0].width = self->width + self->rbwidth * 2;
+            xrect[0].height = ob_rr_theme->title_height +
+                self->bwidth * 2;
+            ++num;
+        }
+
+        if (self->decorations & OB_FRAME_DECOR_HANDLE) {
+            xrect[1].x = -ob_rr_theme->bwidth;
+            xrect[1].y = FRAME_HANDLE_Y(self);
+            xrect[1].width = self->width + self->rbwidth * 2;
+            xrect[1].height = ob_rr_theme->handle_height +
+                self->bwidth * 2;
+            ++num;
+        }
+
+        XShapeCombineRectangles(ob_display, self->window,
+                                ShapeBounding, 0, 0, xrect, num,
+                                ShapeUnion, Unsorted);
     }
 #endif
 }
@@ -392,9 +392,9 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
 
     /* shading can change without being moved or resized */
     RECT_SET_SIZE(self->area,
-                 self->client->area.width +
-                 self->size.left + self->size.right,
-                 (self->client->shaded ?
+                  self->client->area.width +
+                  self->size.left + self->size.right,
+                  (self->client->shaded ?
                    ob_rr_theme->title_height + self->rbwidth * 2:
                    self->client->area.height +
                    self->size.top + self->size.bottom));
@@ -417,12 +417,11 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
 
         if (resized) {
             framerender_frame(self);
-
             frame_adjust_shape(self);
         }
 
         if (!STRUT_EQUAL(self->size, oldsize)) {
-            guint32 vals[4];
+            gulong vals[4];
             vals[0] = self->size.left;
             vals[1] = self->size.right;
             vals[2] = self->size.top;
@@ -436,6 +435,9 @@ void frame_adjust_area(ObFrame *self, gboolean moved,
         if (focus_cycle_target == self->client)
             focus_cycle_draw_indicator();
     }
+    if (resized && (self->decorations & OB_FRAME_DECOR_TITLEBAR))
+        XResizeWindow(ob_display, self->label, self->label_width,
+                      ob_rr_theme->label_height);
 }
 
 void frame_adjust_state(ObFrame *self)
@@ -474,7 +476,7 @@ void frame_grab_client(ObFrame *self, ObClient *client)
       handled and need to be ignored.
     */
     if (ob_state() == OB_STATE_STARTING)
-       client->ignore_unmaps += 2;
+        client->ignore_unmaps += 2;
 
     /* select the event mask on the client's parent (to receive config/map
        req's) the ButtonPress is to catch clicks on the client border */
@@ -506,26 +508,35 @@ void frame_grab_client(ObFrame *self, ObClient *client)
 void frame_release_client(ObFrame *self, ObClient *client)
 {
     XEvent ev;
+    gboolean reparent = TRUE;
 
     g_assert(self->client == client);
 
     /* check if the app has already reparented its window away */
-    if (XCheckTypedWindowEvent(ob_display, client->window,
-                              ReparentNotify, &ev)) {
-       XPutBackEvent(ob_display, &ev);
-
-       /* re-map the window since the unmanaging process unmaps it */
+    while (XCheckTypedWindowEvent(ob_display, client->window,
+                                  ReparentNotify, &ev))
+    {
+        /* This check makes sure we don't catch our own reparent action to
+           our frame window. This doesn't count as the app reparenting itself
+           away of course.
+
+           Reparent events that are generated by us are just discarded here.
+           They are of no consequence to us anyhow.
+        */
+        if (ev.xreparent.parent != self->plate) {
+            reparent = FALSE;
+            XPutBackEvent(ob_display, &ev);
+            break;
+        }
+    }
 
-        /* XXX ... um no it doesnt it unmaps its parent, the window itself
-           retains its mapped state, no?! XXX
-           XMapWindow(ob_display, client->window); */
-    } else {
-       /* according to the ICCCM - if the client doesn't reparent itself,
-          then we will reparent the window to root for them */
-       XReparentWindow(ob_display, client->window,
+    if (reparent) {
+        /* according to the ICCCM - if the client doesn't reparent itself,
+           then we will reparent the window to root for them */
+        XReparentWindow(ob_display, client->window,
                         RootWindow(ob_display, ob_screen),
-                       client->area.x,
-                       client->area.y);
+                        client->area.x,
+                        client->area.y);
     }
 
     /* remove all the windows for the frame from the window_map */
@@ -545,7 +556,7 @@ void frame_release_client(ObFrame *self, ObClient *client)
     g_hash_table_remove(window_map, &self->tlresize);
     g_hash_table_remove(window_map, &self->trresize);
 
-    ob_main_loop_timeout_remove_data(ob_main_loop, flash_timeout, self);
+    ob_main_loop_timeout_remove_data(ob_main_loop, flash_timeout, self, TRUE);
 
     frame_free(self);
 }
@@ -561,54 +572,66 @@ static void layout_title(ObFrame *self)
     /* figure out whats being shown, and the width of the label */
     self->label_width = self->width - (ob_rr_theme->padding + 1) * 2;
     for (lc = config_title_layout; *lc != '\0'; ++lc) {
-       switch (*lc) {
-       case 'N':
+        switch (*lc) {
+        case 'N':
             if (n) { *lc = ' '; break; } /* rm duplicates */
-           n = TRUE;
-           self->label_width -= (ob_rr_theme->button_size + 2 +
+            n = TRUE;
+            self->label_width -= (ob_rr_theme->button_size + 2 +
                                   ob_rr_theme->padding + 1);
-           break;
-       case 'D':
-            if (d) { *lc = ' '; break; } /* rm duplicates */
-           d = TRUE;
-           self->label_width -= (ob_rr_theme->button_size +
+            break;
+        case 'D':
+            if (d) { *lc = ' '; break; }
+            if (!(self->decorations & OB_FRAME_DECOR_ALLDESKTOPS)
+                && config_theme_hidedisabled)
+                break;
+            d = TRUE;
+            self->label_width -= (ob_rr_theme->button_size +
                                   ob_rr_theme->padding + 1);
-           break;
-       case 'S':
-            if (s) { *lc = ' '; break; } /* rm duplicates */
-           s = TRUE;
-           self->label_width -= (ob_rr_theme->button_size +
+            break;
+        case 'S':
+            if (s) { *lc = ' '; break; }
+            if (!(self->decorations & OB_FRAME_DECOR_SHADE)
+                && config_theme_hidedisabled)
+                break;
+            s = TRUE;
+            self->label_width -= (ob_rr_theme->button_size +
                                   ob_rr_theme->padding + 1);
-           break;
-       case 'I':
-            if (i) { *lc = ' '; break; } /* rm duplicates */
-           i = TRUE;
-           self->label_width -= (ob_rr_theme->button_size +
+            break;
+        case 'I':
+            if (i) { *lc = ' '; break; }
+            if (!(self->decorations & OB_FRAME_DECOR_ICONIFY)
+                && config_theme_hidedisabled)
+                break;
+            i = TRUE;
+            self->label_width -= (ob_rr_theme->button_size +
                                   ob_rr_theme->padding + 1);
-           break;
-       case 'L':
-            if (l) { *lc = ' '; break; } /* rm duplicates */
-           l = TRUE;
-           break;
-       case 'M':
-            if (m) { *lc = ' '; break; } /* rm duplicates */
-           m = TRUE;
-           self->label_width -= (ob_rr_theme->button_size +
+            break;
+        case 'L':
+            if (l) { *lc = ' '; break; }
+            l = TRUE;
+            break;
+        case 'M':
+            if (m) { *lc = ' '; break; }
+            if (!(self->decorations & OB_FRAME_DECOR_MAXIMIZE)
+                && config_theme_hidedisabled)
+                break;
+            m = TRUE;
+            self->label_width -= (ob_rr_theme->button_size +
                                   ob_rr_theme->padding + 1);
-           break;
-       case 'C':
-            if (c) { *lc = ' '; break; } /* rm duplicates */
-           c = TRUE;
-           self->label_width -= (ob_rr_theme->button_size +
+            break;
+        case 'C':
+            if (c) { *lc = ' '; break; }
+            if (!(self->decorations & OB_FRAME_DECOR_CLOSE)
+                && config_theme_hidedisabled)
+                break;
+            c = TRUE;
+            self->label_width -= (ob_rr_theme->button_size +
                                   ob_rr_theme->padding + 1);
-           break;
-       }
+            break;
+        }
     }
     if (self->label_width < 1) self->label_width = 1;
 
-    XResizeWindow(ob_display, self->label, self->label_width,
-                  ob_rr_theme->label_height);
-  
     if (!n) XUnmapWindow(ob_display, self->icon);
     if (!d) XUnmapWindow(ob_display, self->desk);
     if (!s) XUnmapWindow(ob_display, self->shade);
@@ -619,57 +642,57 @@ static void layout_title(ObFrame *self)
 
     x = ob_rr_theme->padding + 1;
     for (lc = config_title_layout; *lc != '\0'; ++lc) {
-       switch (*lc) {
-       case 'N':
-           if (!n) break;
-           self->icon_x = x;
-           XMapWindow(ob_display, self->icon);
-           XMoveWindow(ob_display, self->icon, x, ob_rr_theme->padding);
-           x += ob_rr_theme->button_size + 2 + ob_rr_theme->padding + 1;
-           break;
-       case 'D':
-           if (!d) break;
-           self->desk_x = x;
-           XMapWindow(ob_display, self->desk);
-           XMoveWindow(ob_display, self->desk, x, ob_rr_theme->padding + 1);
-           x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
-           break;
-       case 'S':
-           if (!s) break;
-           self->shade_x = x;
-           XMapWindow(ob_display, self->shade);
-           XMoveWindow(ob_display, self->shade, x, ob_rr_theme->padding + 1);
-           x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
-           break;
-       case 'I':
-           if (!i) break;
-           self->iconify_x = x;
-           XMapWindow(ob_display, self->iconify);
-           XMoveWindow(ob_display,self->iconify, x, ob_rr_theme->padding + 1);
-           x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
-           break;
-       case 'L':
-           if (!l) break;
-           self->label_x = x;
-           XMapWindow(ob_display, self->label);
-           XMoveWindow(ob_display, self->label, x, ob_rr_theme->padding);
-           x += self->label_width + ob_rr_theme->padding + 1;
-           break;
-       case 'M':
-           if (!m) break;
-           self->max_x = x;
-           XMapWindow(ob_display, self->max);
-           XMoveWindow(ob_display, self->max, x, ob_rr_theme->padding + 1);
-           x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
-           break;
-       case 'C':
-           if (!c) break;
-           self->close_x = x;
-           XMapWindow(ob_display, self->close);
-           XMoveWindow(ob_display, self->close, x, ob_rr_theme->padding + 1);
-           x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
-           break;
-       }
+        switch (*lc) {
+        case 'N':
+            if (!n) break;
+            self->icon_x = x;
+            XMapWindow(ob_display, self->icon);
+            XMoveWindow(ob_display, self->icon, x, ob_rr_theme->padding);
+            x += ob_rr_theme->button_size + 2 + ob_rr_theme->padding + 1;
+            break;
+        case 'D':
+            if (!d) break;
+            self->desk_x = x;
+            XMapWindow(ob_display, self->desk);
+            XMoveWindow(ob_display, self->desk, x, ob_rr_theme->padding + 1);
+            x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
+            break;
+        case 'S':
+            if (!s) break;
+            self->shade_x = x;
+            XMapWindow(ob_display, self->shade);
+            XMoveWindow(ob_display, self->shade, x, ob_rr_theme->padding + 1);
+            x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
+            break;
+        case 'I':
+            if (!i) break;
+            self->iconify_x = x;
+            XMapWindow(ob_display, self->iconify);
+            XMoveWindow(ob_display,self->iconify, x, ob_rr_theme->padding + 1);
+            x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
+            break;
+        case 'L':
+            if (!l) break;
+            self->label_x = x;
+            XMapWindow(ob_display, self->label);
+            XMoveWindow(ob_display, self->label, x, ob_rr_theme->padding);
+            x += self->label_width + ob_rr_theme->padding + 1;
+            break;
+        case 'M':
+            if (!m) break;
+            self->max_x = x;
+            XMapWindow(ob_display, self->max);
+            XMoveWindow(ob_display, self->max, x, ob_rr_theme->padding + 1);
+            x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
+            break;
+        case 'C':
+            if (!c) break;
+            self->close_x = x;
+            XMapWindow(ob_display, self->close);
+            XMoveWindow(ob_display, self->close, x, ob_rr_theme->padding + 1);
+            x += ob_rr_theme->button_size + ob_rr_theme->padding + 1;
+            break;
+        }
     }
 }
 
@@ -763,24 +786,24 @@ void frame_client_gravity(ObFrame *self, gint *x, gint *y)
     case NorthWestGravity:
     case SouthWestGravity:
     case WestGravity:
-       break;
+        break;
 
     case NorthGravity:
     case SouthGravity:
     case CenterGravity:
-       *x -= (self->size.left + self->size.right) / 2;
-       break;
+        *x -= (self->size.left + self->size.right) / 2;
+        break;
 
     case NorthEastGravity:
     case SouthEastGravity:
     case EastGravity:
-       *x -= self->size.left + self->size.right;
-       break;
+        *x -= self->size.left + self->size.right;
+        break;
 
     case ForgetGravity:
     case StaticGravity:
-       *x -= self->size.left;
-       break;
+        *x -= self->size.left;
+        break;
     }
 
     /* vertical */
@@ -789,24 +812,24 @@ void frame_client_gravity(ObFrame *self, gint *x, gint *y)
     case NorthWestGravity:
     case NorthEastGravity:
     case NorthGravity:
-       break;
+        break;
 
     case CenterGravity:
     case EastGravity:
     case WestGravity:
-       *y -= (self->size.top + self->size.bottom) / 2;
-       break;
+        *y -= (self->size.top + self->size.bottom) / 2;
+        break;
 
     case SouthWestGravity:
     case SouthEastGravity:
     case SouthGravity:
-       *y -= self->size.top + self->size.bottom;
-       break;
+        *y -= self->size.top + self->size.bottom;
+        break;
 
     case ForgetGravity:
     case StaticGravity:
-       *y -= self->size.top;
-       break;
+        *y -= self->size.top;
+        break;
     }
 }
 
@@ -818,21 +841,21 @@ void frame_frame_gravity(ObFrame *self, gint *x, gint *y)
     case NorthWestGravity:
     case WestGravity:
     case SouthWestGravity:
-       break;
+        break;
     case NorthGravity:
     case CenterGravity:
     case SouthGravity:
-       *x += (self->size.left + self->size.right) / 2;
-       break;
+        *x += (self->size.left + self->size.right) / 2;
+        break;
     case NorthEastGravity:
     case EastGravity:
     case SouthEastGravity:
-       *x += self->size.left + self->size.right;
-       break;
+        *x += self->size.left + self->size.right;
+        break;
     case StaticGravity:
     case ForgetGravity:
-       *x += self->size.left;
-       break;
+        *x += self->size.left;
+        break;
     }
 
     /* vertical */
@@ -841,21 +864,21 @@ void frame_frame_gravity(ObFrame *self, gint *x, gint *y)
     case NorthWestGravity:
     case NorthGravity:
     case NorthEastGravity:
-       break;
+        break;
     case WestGravity:
     case CenterGravity:
     case EastGravity:
-       *y += (self->size.top + self->size.bottom) / 2;
-       break;
+        *y += (self->size.top + self->size.bottom) / 2;
+        break;
     case SouthWestGravity:
     case SouthGravity:
     case SouthEastGravity:
-       *y += self->size.top + self->size.bottom;
-       break;
+        *y += self->size.top + self->size.bottom;
+        break;
     case StaticGravity:
     case ForgetGravity:
-       *y += self->size.top;
-       break;
+        *y += self->size.top;
+        break;
     }
 }
 
This page took 0.04705 seconds and 4 git commands to generate.