]> Dogcows Code - chaz/openbox/blobdiff - openbox/client.c
remove openbox_premax, add ob_wm_state_undecorated
[chaz/openbox] / openbox / client.c
index e77ad7b85c33ef254d984e2f3b18e03ec12715b6..ac444595b95602b5521b8c1491e33ba6258c6798 100644 (file)
@@ -183,9 +183,6 @@ void client_manage_all()
        }
     }
     XFree(children);
-
-    if (config_focus_new)
-        focus_fallback(OB_FOCUS_FALLBACK_NOFOCUS);
 }
 
 void client_manage(Window window)
@@ -280,7 +277,10 @@ void client_manage(Window window)
     client_restore_session_stacking(self);
 
     /* focus the new window? */
-    if (ob_state() != OB_STATE_STARTING && config_focus_new &&
+    if (ob_state() != OB_STATE_STARTING &&
+        (config_focus_new || (self->transient_for &&
+                              self->transient_for != OB_TRAN_GROUP &&
+                              client_focused(self->transient_for))) &&
         /* note the check against Type_Normal/Dialog, not client_normal(self),
            which would also include other types. in this case we want more
            strict rules for focus */
@@ -1960,8 +1960,8 @@ void client_configure_full(ObClient *self, ObCorner anchor,
                                     (resized && config_redraw_resize))));
 
     /* if the client is enlarging, the resize the client before the frame */
-    if (send_resize_client && (w > oldw || h > oldh))
-       XResizeWindow(ob_display, self->window, MAX(w, oldw), MAX(h, oldh));
+    if (send_resize_client && user && (w > oldw || h > oldh))
+        XResizeWindow(ob_display, self->window, MAX(w, oldw), MAX(h, oldh));
 
     /* move/resize the frame to match the request */
     if (self->frame) {
@@ -1991,12 +1991,12 @@ void client_configure_full(ObClient *self, ObCorner anchor,
             event.xconfigure.override_redirect = FALSE;
             XSendEvent(event.xconfigure.display, event.xconfigure.window,
                        FALSE, StructureNotifyMask, &event);
-       }
+        }
     }
 
     /* if the client is shrinking, then resize the frame before the client */
-    if (send_resize_client && (w <= oldw || h <= oldh))
-       XResizeWindow(ob_display, self->window, w, h);
+    if (send_resize_client && (!user || (w <= oldw || h <= oldh)))
+        XResizeWindow(ob_display, self->window, w, h);
 
     XFlush(ob_display);
 }
@@ -2013,42 +2013,31 @@ void client_fullscreen(ObClient *self, gboolean fs, gboolean savearea)
                                   and adjust out layer/stacking */
 
     if (fs) {
-       if (savearea) {
-           guint32 dimensions[4];
-           dimensions[0] = self->area.x;
-           dimensions[1] = self->area.y;
-           dimensions[2] = self->area.width;
-           dimensions[3] = self->area.height;
-  
-           PROP_SETA32(self->window, openbox_premax, cardinal,
-                       dimensions, 4);
-       }
+        if (savearea)
+            self->pre_fullscreen_area = self->area;
 
         /* these are not actually used cuz client_configure will set them
            as appropriate when the window is fullscreened */
         x = y = w = h = 0;
     } else {
-        guint num;
-       gint32 *dimensions;
         Rect *a;
 
-        /* pick some fallbacks... */
-        a = screen_area_monitor(self->desktop, 0);
-        x = a->x + a->width / 4;
-        y = a->y + a->height / 4;
-        w = a->width / 2;
-        h = a->height / 2;
-
-       if (PROP_GETA32(self->window, openbox_premax, cardinal,
-                        (guint32**)&dimensions, &num)) {
-            if (num == 4) {
-                x = dimensions[0];
-                y = dimensions[1];
-                w = dimensions[2];
-                h = dimensions[3];
-            }
-           g_free(dimensions);
-       }
+        if (self->pre_fullscreen_area.width > 0 &&
+            self->pre_fullscreen_area.height > 0)
+        {
+            x = self->pre_fullscreen_area.x;
+            y = self->pre_fullscreen_area.y;
+            w = self->pre_fullscreen_area.width;
+            h = self->pre_fullscreen_area.height;
+            RECT_SET(self->pre_fullscreen_area, 0, 0, 0, 0);
+        } else {
+            /* pick some fallbacks... */
+            a = screen_area_monitor(self->desktop, 0);
+            x = a->x + a->width / 4;
+            y = a->y + a->height / 4;
+            w = a->width / 2;
+            h = a->height / 2;
+        }
     }
 
     client_setup_decor_and_functions(self);
@@ -2074,7 +2063,14 @@ static void client_iconify_recursive(ObClient *self,
 
         if (iconic) {
             if (self->functions & OB_CLIENT_FUNC_ICONIFY) {
+                long old;
+
+                old = self->wmstate;
                 self->wmstate = IconicState;
+                if (old != self->wmstate)
+                    PROP_MSG(self->window, kde_wm_change_state,
+                             self->wmstate, 1, 0, 0);
+
                 self->ignore_unmaps++;
                 /* we unmap the client itself so that we can get MapRequest
                    events, and because the ICCCM tells us to! */
@@ -2088,9 +2084,17 @@ static void client_iconify_recursive(ObClient *self,
                 changed = TRUE;
             }
         } else {
+            long old;
+
             if (curdesk)
                 client_set_desktop(self, screen_desktop, FALSE);
+
+            old = self->wmstate;
             self->wmstate = self->shaded ? IconicState : NormalState;
+            if (old != self->wmstate)
+                PROP_MSG(self->window, kde_wm_change_state,
+                         self->wmstate, 1, 0, 0);
+
             XMapWindow(ob_display, self->window);
 
             /* this puts it after the current focused window */
@@ -2137,98 +2141,66 @@ void client_maximize(ObClient *self, gboolean max, int dir, gboolean savearea)
 
     /* check if already done */
     if (max) {
-       if (dir == 0 && self->max_horz && self->max_vert) return;
-       if (dir == 1 && self->max_horz) return;
-       if (dir == 2 && self->max_vert) return;
+        if (dir == 0 && self->max_horz && self->max_vert) return;
+        if (dir == 1 && self->max_horz) return;
+        if (dir == 2 && self->max_vert) return;
     } else {
-       if (dir == 0 && !self->max_horz && !self->max_vert) return;
-       if (dir == 1 && !self->max_horz) return;
-       if (dir == 2 && !self->max_vert) return;
+        if (dir == 0 && !self->max_horz && !self->max_vert) return;
+        if (dir == 1 && !self->max_horz) return;
+        if (dir == 2 && !self->max_vert) return;
     }
 
-    /* work with the frame's coords */
-    x = self->frame->area.x;
-    y = self->frame->area.y;
+    /* we just tell it to configure in the same place and client_configure
+       worries about filling the screen with the window */
+    x = self->area.x;
+    y = self->area.y;
     w = self->area.width;
     h = self->area.height;
 
     if (max) {
-       if (savearea) {
-           gint32 dimensions[4];
-           gint32 *readdim;
-            guint num;
-
-           dimensions[0] = x;
-           dimensions[1] = y;
-           dimensions[2] = w;
-           dimensions[3] = h;
-
-           /* get the property off the window and use it for the dimensions
-              we are already maxed on */
-           if (PROP_GETA32(self->window, openbox_premax, cardinal,
-                           (guint32**)&readdim, &num)) {
-                if (num == 4) {
-                    if (self->max_horz) {
-                        dimensions[0] = readdim[0];
-                        dimensions[2] = readdim[2];
-                    }
-                    if (self->max_vert) {
-                        dimensions[1] = readdim[1];
-                        dimensions[3] = readdim[3];
-                    }
-                }
-               g_free(readdim);
-           }
-
-           PROP_SETA32(self->window, openbox_premax, cardinal,
-                       (guint32*)dimensions, 4);
-       }
+        if (savearea)
+            self->pre_max_area = self->area;
     } else {
-        guint num;
-       gint32 *dimensions;
         Rect *a;
 
-        /* pick some fallbacks... */
         a = screen_area_monitor(self->desktop, 0);
-        if (dir == 0 || dir == 1) { /* horz */
-            x = a->x + a->width / 4;
-            w = a->width / 2;
-        }
-        if (dir == 0 || dir == 2) { /* vert */
-            y = a->y + a->height / 4;
-            h = a->height / 2;
+        if ((dir == 0 || dir == 1) && self->max_horz) { /* horz */
+            if (self->pre_max_area.width > 0) {
+                x = self->pre_max_area.x;
+                w = self->pre_max_area.width;
+
+                RECT_SET(self->pre_max_area, 0, self->pre_max_area.y,
+                         0, self->pre_max_area.height);
+            } else {
+                /* pick some fallbacks... */
+                x = a->x + a->width / 4;
+                w = a->width / 2;
+            }
         }
+        if ((dir == 0 || dir == 2) && self->max_vert) { /* vert */
+            if (self->pre_max_area.width > 0) {
+                y = self->pre_max_area.y;
+                h = self->pre_max_area.height;
 
-       if (PROP_GETA32(self->window, openbox_premax, cardinal,
-                       (guint32**)&dimensions, &num)) {
-            if (num == 4) {
-                if (dir == 0 || dir == 1) { /* horz */
-                    x = dimensions[0];
-                    w = dimensions[2];
-                }
-                if (dir == 0 || dir == 2) { /* vert */
-                    y = dimensions[1];
-                    h = dimensions[3];
-                }
+                RECT_SET(self->pre_max_area, self->pre_max_area.x, 0,
+                         self->pre_max_area.width, 0);
+            } else {
+                /* pick some fallbacks... */
+                y = a->y + a->height / 4;
+                h = a->height / 2;
             }
-            g_free(dimensions);
-       }
+        }
     }
 
     if (dir == 0 || dir == 1) /* horz */
-       self->max_horz = max;
+        self->max_horz = max;
     if (dir == 0 || dir == 2) /* vert */
-       self->max_vert = max;
-
-    if (!self->max_horz && !self->max_vert)
-       PROP_ERASE(self->window, openbox_premax);
+        self->max_vert = max;
 
     client_change_state(self); /* change the state hints on the client */
 
     client_setup_decor_and_functions(self);
 
-    /* figure out where the client should be going */
-    frame_frame_gravity(self->frame, &x, &y);
     client_move_resize(self, x, y, w, h);
 }
 
@@ -2239,8 +2211,16 @@ void client_shade(ObClient *self, gboolean shade)
        self->shaded == shade) return;     /* already done */
 
     /* when we're iconic, don't change the wmstate */
-    if (!self->iconic)
-       self->wmstate = shade ? IconicState : NormalState;
+    if (!self->iconic) {
+        long old;
+
+        old = self->wmstate;
+        self->wmstate = shade ? IconicState : NormalState;
+        if (old != self->wmstate)
+            PROP_MSG(self->window, kde_wm_change_state,
+                     self->wmstate, 1, 0, 0);
+    }
+
     self->shaded = shade;
     client_change_state(self);
     /* resize the frame to just the titlebar */
@@ -2594,11 +2574,12 @@ gboolean client_focus(ObClient *self)
 
 void client_unfocus(ObClient *self)
 {
-    g_assert(focus_client == self);
+    if (focus_client == self) {
 #ifdef DEBUG_FOCUS
-    ob_debug("client_unfocus for %lx\n", self->window);
+        ob_debug("client_unfocus for %lx\n", self->window);
 #endif
-    focus_fallback(OB_FOCUS_FALLBACK_UNFOCUSING);
+        focus_fallback(OB_FOCUS_FALLBACK_UNFOCUSING);
+    }
 }
 
 void client_activate(ObClient *self, gboolean here)
@@ -3010,9 +2991,29 @@ int client_directional_edge_search(ObClient *c, ObDirection dir)
     case OB_DIRECTION_NORTHWEST:
     case OB_DIRECTION_SOUTHWEST:
         /* not implemented */
-        break;
     default:
-            g_assert_not_reached();
+        g_assert_not_reached();
     }
     return dest;
 }
+
+ObClient* client_under_pointer()
+{
+    int x, y;
+    GList *it;
+    ObClient *ret = NULL;
+
+    if (screen_pointer_pos(&x, &y)) {
+        for (it = stacking_list; it != NULL; it = it->next) {
+            if (WINDOW_IS_CLIENT(it->data)) {
+                ObClient *c = WINDOW_AS_CLIENT(it->data);
+                if (c->desktop == screen_desktop &&
+                    RECT_CONTAINS(c->frame->area, x, y)) {
+                    ret = c;
+                    break;
+                }
+            }
+        }
+    }
+    return ret;
+}
This page took 0.028226 seconds and 4 git commands to generate.