Fix negative ResizeRelative values with terminal windows (Fix bug 5228)

[chaz/openbox] / openbox / actions / shade.c

diff --git a/openbox/actions/shade.c b/openbox/actions/shade.c
index f5c111b9866009b4d89d1a94ecb2a2699740946a..502781dd9e34a58739d16d8a66b9ccc38d518776 100644 (file)
--- a/openbox/actions/shade.c
+++ b/openbox/actions/shade.c
@@ -1,64 +1,46 @@
 #include "openbox/actions.h"
 #include "openbox/client.h"
 
-typedef struct {
-    gboolean toggle;
-    gboolean on;
-} Options;
+static gboolean run_func_on(ObActionsData *data, gpointer options);
+static gboolean run_func_off(ObActionsData *data, gpointer options);
+static gboolean run_func_toggle(ObActionsData *data, gpointer options);
 
-static gpointer setup_func(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node);
-static void     free_func(gpointer options);
-static gboolean run_func(ObActionsData *data, gpointer options);
-
-void action_shade_startup()
+void action_shade_startup(void)
 {
-    actions_register("Shade",
-                     setup_func,
-                     free_func,
-                     run_func,
-                     NULL, NULL);
+    actions_register("Shade", NULL, NULL, run_func_on);
+    actions_register("Unshade", NULL, NULL, run_func_off);
+    actions_register("ToggleShade", NULL, NULL, run_func_toggle);
 }
 
-static gpointer setup_func(ObParseInst *i, xmlDocPtr doc, xmlNodePtr node)
+/* Always return FALSE because its not interactive */
+static gboolean run_func_on(ObActionsData *data, gpointer options)
 {
-    xmlNodePtr n;
-    Options *o;
-
-    o = g_new0(Options, 1);
-    o->toggle = TRUE;
-
-    if ((n = parse_find_node("shade", node))) {
-        gchar *s = parse_string(doc, n);
-        if (g_ascii_strcasecmp(s, "toggle")) {
-            o->toggle = FALSE;
-            o->on = parse_bool(doc, n);
-        }
-        g_free(s);
+    if (data->client) {
+        actions_client_move(data, TRUE);
+        client_shade(data->client, TRUE);
+        actions_client_move(data, FALSE);
     }
-
-    return o;
+    return FALSE;
 }
 
-static void free_func(gpointer options)
+/* Always return FALSE because its not interactive */
+static gboolean run_func_off(ObActionsData *data, gpointer options)
 {
-    Options *o = options;
-
-    g_free(o);
+    if (data->client) {
+        actions_client_move(data, TRUE);
+        client_shade(data->client, FALSE);
+        actions_client_move(data, FALSE);
+    }
+    return FALSE;
 }
 
 /* Always return FALSE because its not interactive */
-static gboolean run_func(ObActionsData *data, gpointer options)
+static gboolean run_func_toggle(ObActionsData *data, gpointer options)
 {
-    Options *o = options;
-
     if (data->client) {
         actions_client_move(data, TRUE);
-        if (o->toggle)
-            client_shade(data->client, !data->client->shaded);
-        else
-            client_shade(data->client, o->on);
+        client_shade(data->client, !data->client->shaded);
         actions_client_move(data, FALSE);
     }
-
     return FALSE;
 }