fallback to transients' parents when possible.

[chaz/openbox] / openbox / action.c

diff --git a/openbox/action.c b/openbox/action.c
index fccabfcdef0b2a60a72ed1de54ac7ac0f236ea4e..8196ef673e096798806dba3410d49ca91bd67bd7 100644 (file)
--- a/openbox/action.c
+++ b/openbox/action.c
@@ -6,6 +6,8 @@
 #include "action.h"
 #include "dispatch.h"
 #include "openbox.h"
+#include "engine.h"
+#include "render/render.h"
 
 #include <glib.h>
 
@@ -168,6 +170,14 @@ Action *action_from_string(char *name)
         a = action_new(action_cycle_windows);
         a->data.cycle.linear = TRUE;
         a->data.cycle.forward = FALSE;
+    } else if (!g_ascii_strcasecmp(name, "nextwindow")) {
+        a = action_new(action_cycle_windows);
+        a->data.cycle.linear = FALSE;
+        a->data.cycle.forward = TRUE;
+    } else if (!g_ascii_strcasecmp(name, "previouswindow")) {
+        a = action_new(action_cycle_windows);
+        a->data.cycle.linear = FALSE;
+        a->data.cycle.forward = FALSE;
     }
     
     return a;
@@ -611,11 +621,46 @@ void action_previous_desktop_row(union ActionData *data)
 
 void action_toggle_decorations(union ActionData *data)
 {
-    Client *c = data->client.c;
+    Client *c = data->client.c;;
+
+    if (!c) return;
+
     c->disabled_decorations = c->disabled_decorations ? 0 : ~0;
     client_setup_decor_and_functions(c);
 }
 
+static void popup_coords(char *format, int a, int b, gboolean hide)
+{
+    XSetWindowAttributes attrib;
+    static Window coords = None;
+
+    if (coords == None) {
+        attrib.override_redirect = TRUE;
+        coords = XCreateWindow(ob_display, ob_root,
+                               0, 0, 1, 1, 0, render_depth, InputOutput,
+                               render_visual, CWOverrideRedirect, &attrib);
+        g_assert(coords != None);
+    }
+
+    if (hide)
+        XUnmapWindow(ob_display, coords);
+    else {
+        Rect area = { 10, 10, 1, 1 };
+        Size s;
+        char *text;
+
+        text = g_strdup_printf(format, a, b);
+        engine_size_label(text, TRUE, TRUE, &s);
+        area.width = s.width; area.height = s.height;
+        XMoveResizeWindow(ob_display, coords,
+                          area.x, area.y, area.width, area.height);
+        engine_render_label(coords, &area, text, TRUE, TRUE);
+        g_free(text);
+
+        XMapWindow(ob_display, coords);
+    }
+}
+
 void action_move(union ActionData *data)
 {
     Client *c = data->move.c;
@@ -626,6 +671,8 @@ void action_move(union ActionData *data)
 
     dispatch_move(c, &x, &y);
 
+    popup_coords("X:  %d  Y:  %d", x, y, data->move.final);
+
     frame_frame_gravity(c->frame, &x, &y); /* get where the client should be */
     client_configure(c, Corner_TopLeft, x, y, c->area.width, c->area.height,
                      TRUE, data->move.final);
@@ -640,12 +687,15 @@ void action_resize(union ActionData *data)
     if (!c || c->shaded || !client_normal(c)) return;
 
     dispatch_resize(c, &w, &h, data->resize.corner);
-    
+
     w -= c->frame->size.left + c->frame->size.right;
     h -= c->frame->size.top + c->frame->size.bottom;
     
     client_configure(c, data->resize.corner, c->area.x, c->area.y, w, h,
                      TRUE, data->resize.final);
+
+    popup_coords("W:  %d  H:  %d", c->logical_size.width,
+                 c->logical_size.height, data->move.final);
 }
 
 void action_restart(union ActionData *data)
@@ -666,35 +716,7 @@ void action_showmenu(union ActionData *data)
 
 void action_cycle_windows(union ActionData *data)
 {
-    if (data->cycle.linear) {
-        static Client *first = NULL;
-        static Client *t = NULL;
-
-        if (data->cycle.cancel) {
-            if (first) client_focus(first);
-        } else if (!data->cycle.final) {
-            GList *it, *start;
-
-            t = NULL;
-            first = focus_client;
-            start = it = g_list_find(client_list, data->cycle.c);
-            do {
-                if (data->cycle.forward) {
-                    it = it->next;
-                    if (it == NULL) it = client_list;
-                } else {
-                    it = it->prev;
-                    if (it == NULL) it = g_list_last(client_list);
-                }
-                if (client_focus(it->data)) {
-                    t = it->data;
-                    break;
-                }
-            } while (it != start);
-        } else {
-            if (t) stacking_raise(t);
-        }
-    } else {
-    }
+    focus_cycle(data->cycle.forward, data->cycle.linear, data->cycle.final,
+                data->cycle.cancel);
 }