From: Charles McGarvey <chazmcgarvey@brokenzipper.com>
Date: Thu, 22 Mar 2012 17:03:16 +0000 (-0600)
Subject: partial fix for #69624
X-Git-Url: https://git.dogcows.com/gitweb?p=chaz%2Fp5-DBIx-Class-ResultSet-RecursiveUpdate;a=commitdiff_plain;h=982b1ba172104d6cd67807e78dddbe71b3074394;hp=982b1ba172104d6cd67807e78dddbe71b3074394

partial fix for #69624

This uncomments a call to _delete_empty_auto_increment.  True to its name,
this function removes NULL auto-increments from the column info so that
they are not INSERTed.  The call to this method was commented out in
93ad3243, but I cannot find anyone who remembers why, and re-enabling the
call does not break any other tests on postgres, mysql, or sqlite.

However, this change alone does not cause the test to pass; there are still
issues with databases which enforce foreign constraints (tested on
postgres, mysql, and sqlite with the foreign_keys pragma).  I'm not sure if
the test itself is broken, but maybe it should at least be marked as TODO.
---