From: Alexander Hartmaier <abraxxa@cpan.org>
Date: Sat, 23 Oct 2010 14:41:28 +0000 (+0200)
Subject: carp if value of many-to-many pseudo rel isn't an arrayref or scalar
X-Git-Url: https://git.dogcows.com/gitweb?p=chaz%2Fp5-DBIx-Class-ResultSet-RecursiveUpdate;a=commitdiff_plain;h=0e11e6eb9eb4c5cd9c65ba395fc3f9420715ebbb

carp if value of many-to-many pseudo rel isn't an arrayref or scalar
---

diff --git a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm
index 6626c1c..c3a1356 100644
--- a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm
+++ b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm
@@ -197,19 +197,18 @@ sub recursive_update {
         #warn "update m2m $name\n";
         # TODO: only first pk col is used
         my ($pk) = _get_pk_for_related( $self, $name );
-        my @rows;
+        my @rows = ();
         my $result_source = $object->$name->result_source;
         my @updates;
-        if ( !defined $value ) {
-            #next;
-            @updates = ();
-        }
-        elsif ( ref $value ) {
+        if ( defined $value && ref $value eq 'ARRAY' ) {
             @updates = @{$value};
         }
-        else {
+        elsif ( defined $value && !ref $value ) {
             @updates = ($value);
         }
+        else {
+            carp "value of many-to-many rel '$name' must be an arrayref or scalar";
+        }
         for my $elem (@updates) {
             if ( ref $elem ) {
                 push @rows, $elem;