X-Git-Url: https://git.dogcows.com/gitweb?p=chaz%2Fp5-DBIx-Class-ResultSet-RecursiveUpdate;a=blobdiff_plain;f=t%2Flib%2FRunTests.pm;h=4094bbe7093555047804126c3010228847f3e70d;hp=d2d83bbd0af1be8b09c6dec55f4b13db2dc3e26b;hb=6730d5c6fd5951c2fc78a5bc51dee57fcbb168c7;hpb=c342f7182586afb9b6fdf1842c34c72b5a681cd1

diff --git a/t/lib/RunTests.pm b/t/lib/RunTests.pm
index d2d83bb..4094bbe 100644
--- a/t/lib/RunTests.pm
+++ b/t/lib/RunTests.pm
@@ -11,7 +11,7 @@ use DBIx::Class::ResultSet::RecursiveUpdate;
 sub run_tests {
     my $schema = shift;
 
-    plan tests => 51;
+    plan tests => 55;
 
     my $dvd_rs  = $schema->resultset('Dvd');
     my $user_rs = $schema->resultset('User');
@@ -24,73 +24,100 @@ sub run_tests {
     my $updates;
 
     # pre 0.21 api
-    $dvd_rs->search( { dvd_id => 1 } )->recursive_update( {
-            owner =>  { username => 'aaa'  }
-        },
-        [ 'dvd_id' ]
-    );
+    $dvd_rs->search( { dvd_id => 1 } )
+        ->recursive_update( { owner => { username => 'aaa' } }, ['dvd_id'] );
 
-    my $u = $user_rs->find( $dvd_rs->find( 1 )->owner->id );
+    my $u = $user_rs->find( $dvd_rs->find(1)->owner->id );
     is( $u->username, 'aaa', 'fixed_fields pre 0.21 api ok' );
 
-     # 0.21+ api
-    $dvd_rs->search( { dvd_id => 1 } )->recursive_update( {
-            owner =>  { username => 'bbb'  }
-        },
-        {
-            fixed_fields => [ 'dvd_id' ],
-        }
+    # 0.21+ api
+    $dvd_rs->search( { dvd_id => 1 } )->recursive_update(
+        { owner        => { username => 'bbb' } },
+        { fixed_fields => ['dvd_id'], }
     );
 
-    $u = $user_rs->find( $dvd_rs->find( 1 )->owner->id );
+    $u = $user_rs->find( $dvd_rs->find(1)->owner->id );
     is( $u->username, 'bbb', 'fixed_fields 0.21+ api ok' );
 
-    # try to create with a not existing rel
-    $updates = {
-        name        => 'Test for nonexisting rel',
-        username    => 'nonexisting_rel',
-        password    => 'whatever',
-        nonexisting => { foo => 'bar' },
-    };
+    {
 
-# for future use when we switch from warn to throw_exception
-# eval { $user_rs->recursive_update($updates); };
-# like(
-# $@,
-# qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/,
-# 'nonexisting column, accessor, relationship fails'
-# );
-    warning_like {
-        my $user = $user_rs->recursive_update($updates);
+        # try to create with a not existing rel
+        my $updates = {
+            name        => 'Test for nonexisting rel',
+            username    => 'nonexisting_rel',
+            password    => 'whatever',
+            nonexisting => { foo => 'bar' },
+        };
+
+        warning_like {
+            my $user = $user_rs->recursive_update($updates);
+        }
+        qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/,
+            'nonexisting column, accessor, relationship warns';
+        $expected_user_count++;
+        is( $user_rs->count, $expected_user_count, 'User created' );
+
+        # for future use when we switch from warn to throw_exception
+        # eval { $user_rs->recursive_update($updates); };
+        # like(
+        # $@,
+        # qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/,
+        # 'nonexisting column, accessor, relationship fails'
+        # );
     }
-    qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/,
-        'nonexisting column, accessor, relationship warns';
-    $expected_user_count++;
-    is( $user_rs->count, $expected_user_count, 'User created' );
 
-    # try to create with a not existing rel but suppressed warning
-    $updates = {
-        name        => 'Test for nonexisting rel with suppressed warning',
-        username    => 'suppressed_nonexisting_rel',
-        password    => 'whatever',
-        nonexisting => { foo => 'bar' },
-    };
+    {
 
-    warning_is {
-        my $user =
-            $user_rs->recursive_update( $updates,
-            { unknown_params_ok => 1 } );
+        # try to create with a not existing rel but suppressed warning
+        my $updates = {
+            name        => 'Test for nonexisting rel with suppressed warning',
+            username    => 'suppressed_nonexisting_rel',
+            password    => 'whatever',
+            nonexisting => { foo => 'bar' },
+        };
+
+        warning_is {
+            my $user =
+                $user_rs->recursive_update( $updates,
+                { unknown_params_ok => 1 } );
+        }
+        "",
+            "nonexisting column, accessor, relationship doesn't warn with unknown_params_ok";
+        $expected_user_count++;
+        is( $user_rs->count, $expected_user_count, 'User created' );
+    }
+
+    {
+
+        # try to create with a not existing rel, suppressed warning but storage debugging
+        my $updates = {
+            name        => 'Test for nonexisting rel with suppressed warning but storage debugging',
+            username    => 'suppressed_nonexisting_rel_with_storage_debug',
+            password    => 'whatever',
+            nonexisting => { foo => 'bar' },
+        };
+
+        my $debug = $user_rs->result_source->storage->debug;
+        $user_rs->result_source->storage->debug(1);
+
+        warning_like {
+            my $user =
+                $user_rs->recursive_update( $updates,
+                { unknown_params_ok => 1 } );
+        }
+        qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/,
+            "nonexisting column, accessor, relationship doesn't warn with unknown_params_ok";
+        $expected_user_count++;
+        is( $user_rs->count, $expected_user_count, 'User created' );
+
+        $user_rs->result_source->storage->debug($debug);
     }
-    "",
-        "nonexisting column, accessor, relationship doesn't warn with unknown_params_ok";
-    $expected_user_count++;
-    is( $user_rs->count, $expected_user_count, 'User created' );
 
     # creating new record linked to some old record
     $updates = {
         name     => 'Test name 2',
         viewings => [ { user_id => $owner->id } ],
-        owner    => { id => $another_owner->id },
+        owner => { id => $another_owner->id },
     };
 
     my $new_dvd = $dvd_rs->recursive_update($updates);
@@ -172,7 +199,8 @@ TODO: {
     is( $schema->resultset('User')->count,
         $expected_user_count, "No new user created" );
     is( $dvd_updated->name, undef, 'Dvd name deleted' );
-    is( $dvd_updated->get_column('owner'), $another_owner->id, 'Owner updated' );
+    is( $dvd_updated->get_column('owner'),
+        $another_owner->id, 'Owner updated' );
     is( $dvd_updated->current_borrower->name,
         'new name a', 'Related record modified' );
     is( $dvd_updated->tags->count, 0, 'Tags deleted' );
@@ -181,6 +209,15 @@ TODO: {
         'might_have record changed'
     );
 
+    my $dvd_with_tags =
+        $dvd_rs->recursive_update( { id => $dvd->dvd_id, tags => [ 1, 2 ] } );
+    is_deeply( [ map { $_->id } $dvd_with_tags->tags ], [ 1, 2 ],
+        'Tags set' );
+    my $dvd_without_tags =
+        $dvd_rs->recursive_update( { id => $dvd->dvd_id, tags => undef } );
+    is( $dvd_without_tags->tags->count,
+        0, 'Tags deleted when m2m accessor set to undef' );
+
     $new_dvd->update( { name => 'New Test Name' } );
     $updates = {
         id => $new_dvd->dvd_id,    # id instead of dvd_id