X-Git-Url: https://git.dogcows.com/gitweb?p=chaz%2Fp5-DBIx-Class-ResultSet-RecursiveUpdate;a=blobdiff_plain;f=t%2Flib%2FRunTests.pm;h=204b93ce81140d8d6d594fdab1207051c03e77c8;hp=5fe46f91b14a8b553d0f4851176639bf480d9736;hb=HEAD;hpb=7506524e26fe0caaabab96d354eff58e2d9a1495 diff --git a/t/lib/RunTests.pm b/t/lib/RunTests.pm index 5fe46f9..204b93c 100644 --- a/t/lib/RunTests.pm +++ b/t/lib/RunTests.pm @@ -11,7 +11,7 @@ use DBIx::Class::ResultSet::RecursiveUpdate; sub run_tests { my $schema = shift; - plan tests => 51; + plan tests => 59; my $dvd_rs = $schema->resultset('Dvd'); my $user_rs = $schema->resultset('User'); @@ -24,73 +24,100 @@ sub run_tests { my $updates; # pre 0.21 api - $dvd_rs->search( { dvd_id => 1 } )->recursive_update( { - owner => { username => 'aaa' } - }, - [ 'dvd_id' ] - ); + $dvd_rs->search( { dvd_id => 1 } ) + ->recursive_update( { owner => { username => 'aaa' } }, ['dvd_id'] ); - my $u = $user_rs->find( $dvd_rs->find( 1 )->owner->id ); + my $u = $user_rs->find( $dvd_rs->find(1)->owner->id ); is( $u->username, 'aaa', 'fixed_fields pre 0.21 api ok' ); - # 0.21+ api - $dvd_rs->search( { dvd_id => 1 } )->recursive_update( { - owner => { username => 'bbb' } - }, - { - fixed_fields => [ 'dvd_id' ], - } + # 0.21+ api + $dvd_rs->search( { dvd_id => 1 } )->recursive_update( + { owner => { username => 'bbb' } }, + { fixed_fields => ['dvd_id'], } ); - $u = $user_rs->find( $dvd_rs->find( 1 )->owner->id ); + $u = $user_rs->find( $dvd_rs->find(1)->owner->id ); is( $u->username, 'bbb', 'fixed_fields 0.21+ api ok' ); - # try to create with a not existing rel - $updates = { - name => 'Test for nonexisting rel', - username => 'nonexisting_rel', - password => 'whatever', - nonexisting => { foo => 'bar' }, - }; + { + + # try to create with a not existing rel + my $updates = { + name => 'Test for nonexisting rel', + username => 'nonexisting_rel', + password => 'whatever', + nonexisting => { foo => 'bar' }, + }; -# for future use when we switch from warn to throw_exception -# eval { $user_rs->recursive_update($updates); }; -# like( -# $@, -# qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/, -# 'nonexisting column, accessor, relationship fails' -# ); - warning_like { - my $user = $user_rs->recursive_update($updates); + warning_like { + my $user = $user_rs->recursive_update($updates); + } + qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/, + 'nonexisting column, accessor, relationship warns'; + $expected_user_count++; + is( $user_rs->count, $expected_user_count, 'User created' ); + + # for future use when we switch from warn to throw_exception + # eval { $user_rs->recursive_update($updates); }; + # like( + # $@, + # qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/, + # 'nonexisting column, accessor, relationship fails' + # ); } - qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/, - 'nonexisting column, accessor, relationship warns'; - $expected_user_count++; - is( $user_rs->count, $expected_user_count, 'User created' ); - # try to create with a not existing rel but suppressed warning - $updates = { - name => 'Test for nonexisting rel with suppressed warning', - username => 'suppressed_nonexisting_rel', - password => 'whatever', - nonexisting => { foo => 'bar' }, - }; + { + + # try to create with a not existing rel but suppressed warning + my $updates = { + name => 'Test for nonexisting rel with suppressed warning', + username => 'suppressed_nonexisting_rel', + password => 'whatever', + nonexisting => { foo => 'bar' }, + }; - warning_is { - my $user = - $user_rs->recursive_update( $updates, - { unknown_params_ok => 1 } ); + warning_is { + my $user = + $user_rs->recursive_update( $updates, + { unknown_params_ok => 1 } ); + } + "", + "nonexisting column, accessor, relationship doesn't warn with unknown_params_ok"; + $expected_user_count++; + is( $user_rs->count, $expected_user_count, 'User created' ); + } + + { + + # try to create with a not existing rel, suppressed warning but storage debugging + my $updates = { + name => 'Test for nonexisting rel with suppressed warning but storage debugging', + username => 'suppressed_nonexisting_rel_with_storage_debug', + password => 'whatever', + nonexisting => { foo => 'bar' }, + }; + + my $debug = $user_rs->result_source->storage->debug; + $user_rs->result_source->storage->debug(1); + + warning_like { + my $user = + $user_rs->recursive_update( $updates, + { unknown_params_ok => 1 } ); + } + qr/No such column, relationship, many-to-many helper accessor or generic accessor 'nonexisting'/, + "nonexisting column, accessor, relationship doesn't warn with unknown_params_ok"; + $expected_user_count++; + is( $user_rs->count, $expected_user_count, 'User created' ); + + $user_rs->result_source->storage->debug($debug); } - "", - "nonexisting column, accessor, relationship doesn't warn with unknown_params_ok"; - $expected_user_count++; - is( $user_rs->count, $expected_user_count, 'User created' ); # creating new record linked to some old record $updates = { name => 'Test name 2', viewings => [ { user_id => $owner->id } ], - owner => { id => $another_owner->id }, + owner => { id => $another_owner->id }, }; my $new_dvd = $dvd_rs->recursive_update($updates); @@ -139,7 +166,7 @@ sub run_tests { 'Twokeys created' ); my $onekey = - $schema->resultset('Onekey')->search( name => 'aaaaa' )->first; + $schema->resultset('Onekey')->search({ name => 'aaaaa' })->first; ok( $onekey, 'Onekey created' ); ok( $schema->resultset('Twokeys_belongsto') ->find( { key1 => $onekey->id, key2 => 1 } ), @@ -172,7 +199,8 @@ TODO: { is( $schema->resultset('User')->count, $expected_user_count, "No new user created" ); is( $dvd_updated->name, undef, 'Dvd name deleted' ); - is( $dvd_updated->owner->id, $another_owner->id, 'Owner updated' ); + is( $dvd_updated->get_column('owner'), + $another_owner->id, 'Owner updated' ); is( $dvd_updated->current_borrower->name, 'new name a', 'Related record modified' ); is( $dvd_updated->tags->count, 0, 'Tags deleted' ); @@ -181,6 +209,15 @@ TODO: { 'might_have record changed' ); + my $dvd_with_tags = + $dvd_rs->recursive_update( { id => $dvd->dvd_id, tags => [ 1, 2 ] } ); + is_deeply( [ map { $_->id } $dvd_with_tags->tags ], [ 1, 2 ], + 'Tags set' ); + my $dvd_without_tags = + $dvd_rs->recursive_update( { id => $dvd->dvd_id, tags => undef } ); + is( $dvd_without_tags->tags->count, + 0, 'Tags deleted when m2m accessor set to undef' ); + $new_dvd->update( { name => 'New Test Name' } ); $updates = { id => $new_dvd->dvd_id, # id instead of dvd_id @@ -245,6 +282,8 @@ TODO: { $dvd = $dvd_rs->find(1); is( $dvd->get_column('owner'), $user->id, 'foreign key set' ); + # has_many where foreign cols are nullable + my $available_dvd_rs = $dvd_rs->search({ current_borrower => undef }); $dvd_rs->update( { current_borrower => $user->id } ); ok( $user->borrowed_dvds->count > 1, 'Precond' ); $updates = { @@ -257,21 +296,27 @@ TODO: { updates => $updates, if_not_submitted => 'set_to_null', ); - is( $user->borrowed_dvds->count, 1, 'set_to_null' ); + is( $user->borrowed_dvds->count, 1, 'borrowed_dvds update with if_not_submitted => set_to_null ok' ); + is( $available_dvd_rs->count, 5, "previously borrowed dvds weren't deleted"); + + $dvd_rs->update( { current_borrower => $user->id } ); + $user = + DBIx::Class::ResultSet::RecursiveUpdate::Functions::recursive_update( + resultset => $user_rs, + updates => $updates, + ); + is( $user->borrowed_dvds->count, 1, 'borrowed_dvds update without if_not_submitted ok' ); + is( $available_dvd_rs->count, 5, "previously borrowed dvds weren't deleted"); - # has_many where foreign cols are nullable $dvd_rs->update( { current_borrower => $user->id } ); - $updates = { - id => $user->id, - borrowed_dvds => [ { id => $dvd->id }, ] - }; $user = DBIx::Class::ResultSet::RecursiveUpdate::Functions::recursive_update( resultset => $user_rs, updates => $updates, if_not_submitted => 'delete', ); - is( $user->borrowed_dvds->count, 1, 'if_not_submitted delete' ); + is( $user->borrowed_dvds->count, 1, 'borrowed_dvds update with if_not_submitted => delete ok' ); + is( $dvd_rs->count, 1, 'all dvds except the one borrowed by the user were deleted'); @tags = $schema->resultset('Tag')->all; $dvd_updated =