X-Git-Url: https://git.dogcows.com/gitweb?p=chaz%2Fp5-DBIx-Class-ResultSet-RecursiveUpdate;a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FResultSet%2FRecursiveUpdate.pm;h=8992718ae78e52bbe1af5818093d2b182bce6e8d;hp=1bc5aaee4ea514fe245368b8b559d0765316790f;hb=d5e0c363032486e064fe5cf4fba61153060c65f9;hpb=6239425671e0ed46863cf0e669740abf3cf26fec diff --git a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm index 1bc5aae..8992718 100644 --- a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm +++ b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm @@ -2,7 +2,7 @@ use strict; use warnings; package DBIx::Class::ResultSet::RecursiveUpdate; -use version; our $VERSION = qv('0.004'); +use version; our $VERSION = qv('0.005'); use base qw(DBIx::Class::ResultSet); @@ -30,8 +30,6 @@ sub recursive_update { if ( blessed($updates) && $updates->isa('DBIx::Class::Row') ) { return $updates; } - - # direct column accessors my %columns; @@ -42,6 +40,7 @@ sub recursive_update { # relations that that should be done after the row is inserted into the database # like has_many and might_have my %post_updates; + my %other_methods; my %columns_by_accessor = _get_columns_by_accessor( $self ); for my $name ( keys %$updates ) { @@ -53,6 +52,9 @@ sub recursive_update { $columns{$name} = $updates->{$name}; next; } + if( !( $source->has_relationship($name) && ref( $updates->{$name} ) ) ){ + $other_methods{$name} = $updates->{$name}; + } next if !$source->has_relationship($name); my $info = $source->relationship_info($name); if ( @@ -76,16 +78,18 @@ sub recursive_update { } $object ||= $self->new( {} ); -# first update columns and other accessors - so that later related records can be found + # first update columns and other accessors - so that later related records can be found for my $name ( keys %columns ) { $object->$name( $updates->{$name} ); } + for my $name ( keys %other_methods) { + $object->$name( $updates->{$name} ) if $object->can( $name ); + } for my $name ( keys %pre_updates ) { my $info = $object->result_source->relationship_info($name); _update_relation( $self, $name, $updates, $object, $info ); } # $self->_delete_empty_auto_increment($object); - # don't allow insert to recurse to related objects - we do the recursion ourselves # $object->{_rel_in_storage} = 1; $object->update_or_insert; @@ -151,8 +155,18 @@ sub _update_relation { else { my $sub_updates = $updates->{$name}; $sub_updates = { %$sub_updates, %$resolved } if $resolved && ref( $sub_updates ) eq 'HASH'; - my $sub_object = - recursive_update( resultset => $related_result, updates => $sub_updates ); + my $sub_object; + if( $info->{attrs}{accessor} eq 'single' && defined $object->$name ){ + $sub_object = recursive_update( + resultset => $related_result, + updates => $sub_updates, + object => $object->$name + ); + } + else{ + $sub_object = + recursive_update( resultset => $related_result, updates => $sub_updates ); + } $object->set_from_related( $name, $sub_object ); } }