X-Git-Url: https://git.dogcows.com/gitweb?p=chaz%2Fp5-DBIx-Class-ResultSet-RecursiveUpdate;a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FResultSet%2FRecursiveUpdate.pm;h=8193fb61c0de9a89909efa808cd3f7af0c96652e;hp=dcf370752d16a4fa47ac39fbf3c9d11524eff0ec;hb=4ce61ffeb9482993f7c0fb5c09e39f04ec11dbea;hpb=b7b1b75e38ba3bb4ba50c76c33610b725167ed41 diff --git a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm index dcf3707..8193fb6 100644 --- a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm +++ b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm @@ -2,8 +2,7 @@ use strict; use warnings; package DBIx::Class::ResultSet::RecursiveUpdate; - -our $VERSION = '0.013'; +# ABSTRACT: like update_or_create - but recursive use base qw(DBIx::Class::ResultSet); @@ -20,6 +19,7 @@ sub recursive_update { package DBIx::Class::ResultSet::RecursiveUpdate::Functions; use Carp; use Scalar::Util qw( blessed ); +use List::MoreUtils qw/ any /; sub recursive_update { my %params = @_; @@ -84,28 +84,22 @@ sub recursive_update { && ref( $updates->{$name} ) ) ) { - #warn "$name is a column"; + #warn "$name is a column\n"; $columns{$name} = $updates->{$name}; next; } # relationships if ( $source->has_relationship($name) ) { - my $info = $source->relationship_info($name); - if (_master_relation_cond( - $source, $info->{cond}, - _get_pk_for_related( $self, $name ) - ) - ) - { + if ( _master_relation_cond( $self, $name ) ) { - #warn "$name is a pre-update rel"; + #warn "$name is a pre-update rel\n"; $pre_updates{$name} = $updates->{$name}; next; } else { - #warn "$name is a post-update rel"; + #warn "$name is a post-update rel\n"; $post_updates{$name} = $updates->{$name}; next; } @@ -114,7 +108,7 @@ sub recursive_update { # many-to-many helper accessors if ( is_m2m( $self, $name ) ) { - #warn "$name is a many-to-many helper accessor"; + #warn "$name is a many-to-many helper accessor\n"; $other_methods{$name} = $updates->{$name}; next; } @@ -128,6 +122,8 @@ sub recursive_update { } # unknown + # TODO: don't throw a warning instead of an exception to give users + # time to adapt to the new API $self->throw_exception( "No such column, relationship, many-to-many helper accessor or generic accessor '$name'" ); @@ -138,13 +134,19 @@ sub recursive_update { # first update columns and other accessors # so that later related records can be found for my $name ( keys %columns ) { + + #warn "update col $name\n"; $object->$name( $columns{$name} ); } for my $name ( keys %other_methods ) { + + #warn "update other $name\n"; $object->$name( $updates->{$name} ); } for my $name ( keys %pre_updates ) { - _update_relation( $self, $name, $updates->{$name}, $object, + + #warn "pre_update $name\n"; + _update_relation( $self, $name, $pre_updates{$name}, $object, $if_not_submitted ); } @@ -152,7 +154,10 @@ sub recursive_update { # don't allow insert to recurse to related objects # do the recursion ourselves # $object->{_rel_in_storage} = 1; + #warn "CHANGED: " . $object->is_changed . "\n": + #warn "IN STOR: " . $object->in_storage . "\n"; $object->update_or_insert if $object->is_changed; + $object->discard_changes; # updating many_to_many for my $name ( keys %$updates ) { @@ -160,6 +165,8 @@ sub recursive_update { my $value = $updates->{$name}; if ( is_m2m( $self, $name ) ) { + + #warn "update m2m $name\n"; my ($pk) = _get_pk_for_related( $self, $name ); my @rows; my $result_source = $object->$name->result_source; @@ -191,7 +198,9 @@ sub recursive_update { } } for my $name ( keys %post_updates ) { - _update_relation( $self, $name, $updates->{$name}, $object, + + #warn "post_update $name\n"; + _update_relation( $self, $name, $post_updates{$name}, $object, $if_not_submitted ); } return $object; @@ -210,16 +219,17 @@ sub _get_columns_by_accessor { return %columns; } -# Arguments: $name, $updates, $object, $if_not_submitted - +# Arguments: $rs, $name, $updates, $row, $if_not_submitted sub _update_relation { my ( $self, $name, $updates, $object, $if_not_submitted ) = @_; # this should never happen because we're checking the paramters passed to # recursive_update, but just to be sure... - $object->throw_exception("No such relationship '$name' on ") + $object->throw_exception("No such relationship '$name'") unless $object->has_relationship($name); + #warn "_update_relation $name: OBJ: " . ref($object) . "\n"; + my $info = $object->result_source->relationship_info($name); # get a related resultset without a condition @@ -231,6 +241,10 @@ sub _update_relation { $self->result_source->_resolve_condition( $info->{cond}, $name, $object ); } + else { + $self->throw_exception( + "result_source must support _resolve_condition"); + } # warn "$name resolved: " . Dumper( $resolved ); use Data::Dumper; $resolved = {} @@ -238,54 +252,100 @@ sub _update_relation { && $DBIx::Class::ResultSource::UNRESOLVABLE_CONDITION == $resolved; - my $rel_col_cnt = scalar keys %{ $info->{cond} }; - use Data::Dumper; - warn "RELINFO for $name: " . Dumper($info); - warn "REL_COL_CNT: $rel_col_cnt"; + my @rel_cols = keys %{ $info->{cond} }; + map {s/^foreign\.//} @rel_cols; + + #warn "REL_COLS: " . Dumper(@rel_cols); use Data::Dumper; + #my $rel_col_cnt = scalar @rel_cols; + + # find out if all related columns are nullable + my $all_fks_nullable = 1; + for my $rel_col (@rel_cols) { + $all_fks_nullable = 0 + unless $related_resultset->result_source->column_info($rel_col) + ->{is_nullable}; + } - #warn "REV RELINFO for $name: " . Dumper($revrelinfo); + $if_not_submitted = $all_fks_nullable ? 'nullify' : 'delete' + unless defined $if_not_submitted; + + #warn "\tNULLABLE: $all_fks_nullable ACTION: $if_not_submitted\n"; + + #warn "RELINFO for $name: " . Dumper($info); use Data::Dumper; # the only valid datatype for a has_many rels is an arrayref - if ( $info->{attrs}{accessor} eq 'multi') { - $self->throw_exception( "data for has_many relationship '$name' must be an arrayref") + if ( $info->{attrs}{accessor} eq 'multi' ) { + + # handle undef like empty arrayref + $updates = [] + unless defined $updates; + $self->throw_exception( + "data for has_many relationship '$name' must be an arrayref") unless ref $updates eq 'ARRAY'; - my @updated_ids; + my @updated_objs; + + #warn "\tupdating has_many rel '$name' ($rel_col_cnt columns cols)\n"; for my $sub_updates ( @{$updates} ) { - warn "updating $name"; my $sub_object = recursive_update( resultset => $related_resultset, updates => $sub_updates, resolved => $resolved ); - push @updated_ids, $sub_object->id; + + push @updated_objs, $sub_object; } + + #warn "\tcreated and updated related rows\n"; + my @related_pks = $related_resultset->result_source->primary_columns; - if ( defined $if_not_submitted && $if_not_submitted eq 'delete' ) { - # only handles related result classes with single primary keys - if ( 1 == scalar @related_pks ) { - $object->$name->search( - { $related_pks[0] => { -not_in => \@updated_ids } } ) - ->delete; - } + my $rs_rel_delist = $object->$name; + + # foreign table has a single pk column + if ( scalar @related_pks == 1 ) { + $rs_rel_delist = $rs_rel_delist->search_rs( + { $related_pks[0] => + { -not_in => [ map ( $_->id, @updated_objs ) ] } + } + ); } - elsif ( defined $if_not_submitted - && $if_not_submitted eq 'set_to_null' ) - { - # only handles related result classes with single primary keys - if ( 1 == scalar @related_pks ) { - my @fk = keys %$resolved; - $object->$name->search( - { $related_pks[0] => { -not_in => \@updated_ids } } ) - ->update( { $fk[0] => undef } ); + # foreign table has multiple pk columns + else { + my @cond; + for my $obj (@updated_objs) { + my %cond_for_obj; + for my $col (@related_pks) { + $cond_for_obj{$col} = $obj->get_column($col); + } + push @cond, \%cond_for_obj; + } + # only limit resultset if there are related rows left + if (scalar @cond) { + $rs_rel_delist = $rs_rel_delist->search_rs( { -not => [@cond] } ); } } + + #warn "\tCOND: " . Dumper(\%cond); + #my $rel_delist_cnt = $rs_rel_delist->count; + if ( $if_not_submitted eq 'delete' ) { + + #warn "\tdeleting related rows: $rel_delist_cnt\n"; + $rs_rel_delist->delete; + } + elsif ( $if_not_submitted eq 'set_to_null' ) { + + #warn "\tnullifying related rows: $rel_delist_cnt\n"; + my %update = map { $_ => undef } @rel_cols; + $rs_rel_delist->update( \%update ); + } } elsif ($info->{attrs}{accessor} eq 'single' || $info->{attrs}{accessor} eq 'filter' ) { + + #warn "\tupdating rel '$name': $if_not_submitted\n"; my $sub_object; if ( ref $updates ) { @@ -307,7 +367,7 @@ sub _update_relation { ); } } - elsif ( !ref $updates ) { + else { $sub_object = $related_resultset->find($updates) unless ( !$updates @@ -324,7 +384,9 @@ sub _update_relation { ); } else { - $self->throw_exception( "recursive_update doesn't now how to handle relationship '$name' with accessor " . $info->{attrs}{accessor}); + $self->throw_exception( + "recursive_update doesn't now how to handle relationship '$name' with accessor " + . $info->{attrs}{accessor} ); } } @@ -393,74 +455,97 @@ sub _get_pk_for_related { # after the row is inserted into the database # relationships before: belongs_to # relationships after: has_many, might_have and has_one +# true means before, false after sub _master_relation_cond { - my ( $source, $cond, @foreign_ids ) = @_; - my $foreign_ids_re = join '|', @foreign_ids; - if ( ref $cond eq 'HASH' ) { - for my $f_key ( keys %{$cond} ) { + my ( $self, $name ) = @_; + + my $source = $self->result_source; + my $info = $source->relationship_info($name); + + #warn "INFO: " . Dumper($info) . "\n"; + + # has_many rels are always after + return 0 + if $info->{attrs}->{accessor} eq 'multi'; + + my @foreign_ids = _get_pk_for_related( $self, $name ); + + #warn "IDS: " . join(', ', @foreign_ids) . "\n"; + + my $cond = $info->{cond}; + + sub _inner { + my ( $source, $cond, @foreign_ids ) = @_; + + while ( my ( $f_key, $col ) = each %{$cond} ) { # might_have is not master - my $col = $cond->{$f_key}; - $col =~ s/self\.//; + $col =~ s/^self\.//; + $f_key =~ s/^foreign\.//; if ( $source->column_info($col)->{is_auto_increment} ) { return 0; } - if ( $f_key =~ /^foreign\.$foreign_ids_re/ ) { + if ( any { $_ eq $f_key } @foreign_ids ) { return 1; } } + return 0; } + + if ( ref $cond eq 'HASH' ) { + return _inner( $source, $cond, @foreign_ids ); + } + + # arrayref of hashrefs elsif ( ref $cond eq 'ARRAY' ) { for my $new_cond (@$cond) { - return _master_relation_cond( $source, $new_cond, @foreign_ids ); + return _inner( $source, $new_cond, @foreign_ids ); } } + else { + $source->throw_exception( + "unhandled relation condition " . ref($cond) ); + } return; } 1; # Magic true value required at end of module __END__ -=head1 NAME - -DBIx::Class::ResultSet::RecursiveUpdate - like update_or_create - but recursive - =head1 SYNOPSIS -The functional interface: + # The functional interface: + my $schema = MyDB::Schema->connect(); my $new_item = DBIx::Class::ResultSet::RecursiveUpdate::Functions::recursive_update({ - resultset => $schema->resultset( 'Dvd' ), + resultset => $schema->resultset('User'), updates => { - id => 1, - owned_dvds => [ - { - title => 'One Flew Over the Cuckoo's Nest' - } - ] + id => 1, + owned_dvds => [ + { + title => "One Flew Over the Cuckoo's Nest" + } + ] } }); -As ResultSet subclass: + # As ResultSet subclass: __PACKAGE__->load_namespaces( default_resultset_class => '+DBIx::Class::ResultSet::RecursiveUpdate' ); -in the Schema file (see t/lib/DBSchema.pm). Or appriopriate 'use base' in the ResultSet classes. + # in the Schema file (see t/lib/DBSchema.pm). Or appriopriate 'use base' in the ResultSet classes. -Then: + my $user = $schema->resultset('User')->recursive_update({ + id => 1, + owned_dvds => [ + { + title => "One Flew Over the Cuckoo's Nest" + } + ] + }); - my $user = $user_rs->recursive_update( { - id => 1, - owned_dvds => [ - { - title => 'One Flew Over the Cuckoo's Nest' - } - ] - } - ); - =head1 DESCRIPTION This is still experimental. I've added a functional interface so that it can be used @@ -684,40 +769,3 @@ No bugs have been reported. Please report any bugs or feature requests to C, or through the web interface at L. - - -=head1 AUTHOR - -Zbigniew Lukasiak C<< >> -Influenced by code by Pedro Melo. - -=head1 LICENCE AND COPYRIGHT - -Copyright (c) 2008, Zbigniew Lukasiak C<< >>. All rights reserved. - -This module is free software; you can redistribute it and/or -modify it under the same terms as Perl itself. See L. - - -=head1 DISCLAIMER OF WARRANTY - -BECAUSE THIS SOFTWARE IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY -FOR THE SOFTWARE, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN -OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES -PROVIDE THE SOFTWARE "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER -EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED -WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE -ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE SOFTWARE IS WITH -YOU. SHOULD THE SOFTWARE PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL -NECESSARY SERVICING, REPAIR, OR CORRECTION. - -IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING -WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR -REDISTRIBUTE THE SOFTWARE AS PERMITTED BY THE ABOVE LICENCE, BE -LIABLE TO YOU FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL, -OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE -THE SOFTWARE (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING -RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A -FAILURE OF THE SOFTWARE TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF -SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF -SUCH DAMAGES.