X-Git-Url: https://git.dogcows.com/gitweb?p=chaz%2Fp5-DBIx-Class-ResultSet-RecursiveUpdate;a=blobdiff_plain;f=lib%2FDBIx%2FClass%2FResultSet%2FRecursiveUpdate.pm;h=0997ff3a8bf854ea4412fcfe89487a9ead358fb6;hp=884cf0584d0ebfdef4672ebe30617a1949a2e4da;hb=4bb09f7fc7ffdb7adf715d4c42b9be6624809f7d;hpb=f6641f7ade5a9b4227feef8a538228fcea80a5b2 diff --git a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm index 884cf05..0997ff3 100644 --- a/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm +++ b/lib/DBIx/Class/ResultSet/RecursiveUpdate.pm @@ -30,6 +30,7 @@ sub recursive_update { if ( blessed($updates) && $updates->isa('DBIx::Class::Row') ) { return $updates; } + # warn Dumper( $updates ); use Data::Dumper; # direct column accessors my %columns; @@ -40,8 +41,8 @@ sub recursive_update { # relations that that should be done after the row is inserted into the database # like has_many and might_have my %post_updates; + my %other_methods; my %columns_by_accessor = _get_columns_by_accessor( $self ); - for my $name ( keys %$updates ) { my $source = $self->result_source; if ( $columns_by_accessor{$name} @@ -51,7 +52,10 @@ sub recursive_update { $columns{$name} = $updates->{$name}; next; } - next if !$source->has_relationship($name); + if( !( $source->has_relationship($name) ) ){ + $other_methods{$name} = $updates->{$name}; + next; + } my $info = $source->relationship_info($name); if ( _master_relation_cond( @@ -65,7 +69,7 @@ sub recursive_update { $post_updates{$name} = $updates->{$name}; } } - # warn 'columns: ' . Dumper( \%columns ); use Data::Dumper; + # warn 'other: ' . Dumper( \%other_methods ); use Data::Dumper; my @missing = grep { !exists $columns{$_} && !exists $fixed_fields{$_} } $self->result_source->primary_columns; @@ -78,6 +82,9 @@ sub recursive_update { for my $name ( keys %columns ) { $object->$name( $updates->{$name} ); } + for my $name ( keys %other_methods) { + $object->$name( $updates->{$name} ) if $object->can( $name ); + } for my $name ( keys %pre_updates ) { my $info = $object->result_source->relationship_info($name); _update_relation( $self, $name, $updates, $object, $info ); @@ -147,19 +154,25 @@ sub _update_relation { } else { my $sub_updates = $updates->{$name}; - $sub_updates = { %$sub_updates, %$resolved } if $resolved && ref( $sub_updates ) eq 'HASH'; my $sub_object; - if( $info->{attrs}{accessor} eq 'single' && defined $object->$name ){ - $sub_object = recursive_update( - resultset => $related_result, - updates => $sub_updates, - object => $object->$name - ); + if( ref $sub_updates ){ + $sub_updates = { %$sub_updates, %$resolved } if $resolved && ref( $sub_updates ) eq 'HASH'; + # for might_have relationship + if( $info->{attrs}{accessor} eq 'single' && defined $object->$name ){ + $sub_object = recursive_update( + resultset => $related_result, + updates => $sub_updates, + object => $object->$name + ); + } + else{ + $sub_object = + recursive_update( resultset => $related_result, updates => $sub_updates ); + } + } + elsif( ! ref $sub_updates ){ + $sub_object = $related_result->find( $sub_updates ); } - else{ - $sub_object = - recursive_update( resultset => $related_result, updates => $sub_updates ); - } $object->set_from_related( $name, $sub_object ); } }