package DBIx::Class::ResultSet::RecursiveUpdate::Functions;
use Carp;
use Scalar::Util qw( blessed );
+use List::MoreUtils qw/ any /;
sub recursive_update {
my %params = @_;
# warn 'columns: ' . Dumper( \%columns_by_accessor );
for my $name ( keys %$updates ) {
my $source = $self->result_source;
- if ( $columns_by_accessor{$name}
+
+ # columns
+ if ( exists $columns_by_accessor{$name}
&& !( $source->has_relationship($name)
&& ref( $updates->{$name} ) ) )
{
+
+ #warn "$name is a column\n";
$columns{$name} = $updates->{$name};
next;
}
- if ( !( $source->has_relationship($name) ) ) {
+
+ # relationships
+ if ( $source->has_relationship($name) ) {
+ if ( _master_relation_cond( $self, $name ) ) {
+
+ #warn "$name is a pre-update rel\n";
+ $pre_updates{$name} = $updates->{$name};
+ next;
+ }
+ else {
+
+ #warn "$name is a post-update rel\n";
+ $post_updates{$name} = $updates->{$name};
+ next;
+ }
+ }
+
+ # many-to-many helper accessors
+ if ( is_m2m( $self, $name ) ) {
+
+ #warn "$name is a many-to-many helper accessor\n";
$other_methods{$name} = $updates->{$name};
next;
}
- my $info = $source->relationship_info($name);
- if (_master_relation_cond(
- $source, $info->{cond},
- _get_pk_for_related( $self, $name )
- )
- )
- {
- $pre_updates{$name} = $updates->{$name};
- }
- else {
- $post_updates{$name} = $updates->{$name};
+
+ # accessors
+ if ( $object->can($name) && not $source->has_relationship($name) ) {
+
+ #warn "$name is an accessor";
+ $other_methods{$name} = $updates->{$name};
+ next;
}
+
+ # unknown
+ # TODO: don't throw a warning instead of an exception to give users
+ # time to adapt to the new API
+ $self->throw_exception(
+ "No such column, relationship, many-to-many helper accessor or generic accessor '$name'"
+ );
}
# warn 'other: ' . Dumper( \%other_methods ); use Data::Dumper;
# first update columns and other accessors
# so that later related records can be found
for my $name ( keys %columns ) {
+
+ #warn "update col $name\n";
$object->$name( $columns{$name} );
}
for my $name ( keys %other_methods ) {
- $object->$name( $updates->{$name} ) if $object->can($name);
+
+ #warn "update other $name\n";
+ $object->$name( $updates->{$name} );
}
for my $name ( keys %pre_updates ) {
- my $info = $object->result_source->relationship_info($name);
- _update_relation( $self, $name, $updates->{$name}, $object, $info,
+
+ #warn "pre_update $name\n";
+ _update_relation( $self, $name, $pre_updates{$name}, $object,
$if_not_submitted );
}
# don't allow insert to recurse to related objects
# do the recursion ourselves
# $object->{_rel_in_storage} = 1;
+ #warn "CHANGED: " . $object->is_changed . " IN STOR: " . $object->in_storage . "\n";
$object->update_or_insert if $object->is_changed;
# updating many_to_many
my $value = $updates->{$name};
if ( is_m2m( $self, $name ) ) {
+
+ #warn "update m2m $name\n";
my ($pk) = _get_pk_for_related( $self, $name );
my @rows;
my $result_source = $object->$name->result_source;
}
}
for my $name ( keys %post_updates ) {
- my $info = $object->result_source->relationship_info($name);
- _update_relation( $self, $name, $updates->{$name}, $object, $info,
+
+ #warn "post_update $name\n";
+ _update_relation( $self, $name, $post_updates{$name}, $object,
$if_not_submitted );
}
return $object;
return %columns;
}
-# Arguments: $name, $updates, $object, $info, $if_not_submitted
-
+# Arguments: $rs, $name, $updates, $row, $if_not_submitted
sub _update_relation {
- my ( $self, $name, $updates, $object, $info, $if_not_submitted ) = @_;
+ my ( $self, $name, $updates, $object, $if_not_submitted ) = @_;
+
+ # this should never happen because we're checking the paramters passed to
+ # recursive_update, but just to be sure...
+ $object->throw_exception("No such relationship '$name'")
+ unless $object->has_relationship($name);
+
+ #warn "_update_relation $name: OBJ: " . ref($object) . "\n";
+
+ my $info = $object->result_source->relationship_info($name);
+
# get a related resultset without a condition
my $related_resultset =
$self->related_resultset($name)->result_source->resultset;
$object );
}
else {
- $resolved =
- $self->result_source->resolve_condition( $info->{cond}, $name,
- $object );
+ $self->throw_exception(
+ "result_source must support _resolve_condition");
}
# warn "$name resolved: " . Dumper( $resolved ); use Data::Dumper;
&& $DBIx::Class::ResultSource::UNRESOLVABLE_CONDITION
== $resolved;
- # an arrayref is only valid for has_many rels
- if ( ref $updates eq 'ARRAY' ) {
+ my $rel_col_cnt = scalar keys %{ $info->{cond} };
+ use Data::Dumper;
+ warn "RELINFO for $name: " . Dumper($info);
+ warn "REL_COL_CNT: $rel_col_cnt";
+
+ #warn "REV RELINFO for $name: " . Dumper($revrelinfo);
+
+ # the only valid datatype for a has_many rels is an arrayref
+ if ( $info->{attrs}{accessor} eq 'multi' ) {
+ $self->throw_exception(
+ "data for has_many relationship '$name' must be an arrayref")
+ unless ref $updates eq 'ARRAY';
+
my @updated_ids;
for my $sub_updates ( @{$updates} ) {
my $sub_object = recursive_update(
}
}
}
- else {
+ elsif ($info->{attrs}{accessor} eq 'single'
+ || $info->{attrs}{accessor} eq 'filter' )
+ {
+ #warn "\tupdating rel '$name': $if_not_submitted\n";
my $sub_object;
if ( ref $updates ) {
);
}
}
- elsif ( !ref $updates ) {
+ else {
$sub_object = $related_resultset->find($updates)
unless (
!$updates
&& $info->{attrs}{join_type} eq 'LEFT' )
);
}
+ else {
+ $self->throw_exception(
+ "recursive_update doesn't now how to handle relationship '$name' with accessor "
+ . $info->{attrs}{accessor} );
+ }
}
sub is_m2m {
# after the row is inserted into the database
# relationships before: belongs_to
# relationships after: has_many, might_have and has_one
+# true means before, false after
sub _master_relation_cond {
- my ( $source, $cond, @foreign_ids ) = @_;
- my $foreign_ids_re = join '|', @foreign_ids;
- if ( ref $cond eq 'HASH' ) {
- for my $f_key ( keys %{$cond} ) {
+ my ( $self, $name ) = @_;
+
+ my $source = $self->result_source;
+ my $info = $source->relationship_info($name);
+
+ #warn "INFO: " . Dumper($info) . "\n";
+
+ # has_many rels are always after
+ return 0
+ if $info->{attrs}->{accessor} eq 'multi';
+
+ my @foreign_ids = _get_pk_for_related( $self, $name );
+
+ #warn "IDS: " . join(', ', @foreign_ids) . "\n";
+
+ my $cond = $info->{cond};
+
+ sub _inner {
+ my ( $source, $cond, @foreign_ids ) = @_;
+
+ while ( my ( $f_key, $col ) = each %{$cond} ) {
# might_have is not master
- my $col = $cond->{$f_key};
- $col =~ s/self\.//;
+ $col =~ s/^self\.//;
+ $f_key =~ s/^foreign\.//;
if ( $source->column_info($col)->{is_auto_increment} ) {
return 0;
}
- if ( $f_key =~ /^foreign\.$foreign_ids_re/ ) {
+ if ( any { $_ eq $f_key } @foreign_ids ) {
return 1;
}
}
+ return 0;
+ }
+
+ if ( ref $cond eq 'HASH' ) {
+ return _inner( $source, $cond, @foreign_ids );
}
+
+ # arrayref of hashrefs
elsif ( ref $cond eq 'ARRAY' ) {
for my $new_cond (@$cond) {
- return _master_relation_cond( $source, $new_cond, @foreign_ids );
+ return _inner( $source, $new_cond, @foreign_ids );
}
}
+ else {
+ $source->throw_exception(
+ "unhandled relation condition " . ref($cond) );
+ }
return;
}
projects / chaz / p5-DBIx-Class-ResultSet-RecursiveUpdate / blobdiff