From cea19c78c1d3bccb356fce21cda4a2fc85afce1b Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Sun, 18 May 2003 17:37:03 +0000 Subject: [PATCH] proper check to see if something was raised, the it==NULL would cause it to always return, incorrectly. --- openbox/stacking.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/openbox/stacking.c b/openbox/stacking.c index e205d4b0..d6112469 100644 --- a/openbox/stacking.c +++ b/openbox/stacking.c @@ -112,6 +112,7 @@ void stacking_raise(ObWindow *window) if (WINDOW_IS_CLIENT(window)) { Client *client = WINDOW_AS_CLIENT(window); + /* move up the transient chain as far as possible first */ if (client->transient_for) { if (client->transient_for != TRAN_GROUP) { @@ -119,15 +120,18 @@ void stacking_raise(ObWindow *window) return; } else { GSList *it; + gboolean raised = FALSE; for (it = client->group->members; it; it = it->next) { Client *c = it->data; /* checking transient_for prevents infinate loops! */ - if (c != client && !c->transient_for) + if (c != client && !c->transient_for) { stacking_raise(it->data); + raised = TRUE; + } } - if (it == NULL) return; + if (raised) return; } } } -- 2.44.0