From 82db73cc4344cf4e8a3757fb1ec50be77e3bc9d8 Mon Sep 17 00:00:00 2001 From: Mikael Magnusson Date: Fri, 3 Jul 2009 21:19:54 +0200 Subject: [PATCH] Fix for #3715, app settings applied too late. This caused problems for placing windows with decor turned off, the placement code thought they had it on. --- openbox/client.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/openbox/client.c b/openbox/client.c index 03bbfe48..016a660f 100644 --- a/openbox/client.c +++ b/openbox/client.c @@ -315,6 +315,11 @@ void client_manage(Window window, ObPrompt *prompt) ob_debug("Window group: 0x%x\n", self->group?self->group->leader:0); ob_debug("Window name: %s class: %s\n", self->name, self->class); + /* per-app settings override stuff from client_get_all, and return the + settings for other uses too. the returned settings is a shallow copy, + that needs to be freed with g_free(). */ + settings = client_get_settings_state(self); + /* now we have all of the window's information so we can set this up. do this before creating the frame, so it can tell that we are still mapping and doesn't go applying things right away */ @@ -335,10 +340,6 @@ void client_manage(Window window, ObPrompt *prompt) time now */ grab_server(FALSE); - /* per-app settings override stuff from client_get_all, and return the - settings for other uses too. the returned settings is a shallow copy, - that needs to be freed with g_free(). */ - settings = client_get_settings_state(self); /* the session should get the last say though */ client_restore_session_state(self); -- 2.44.0