From: Paul Eggert Date: Wed, 18 Jan 2012 06:21:52 +0000 (-0800) Subject: tar: port --overwrite symlink test to GNU/Hurd X-Git-Url: https://git.dogcows.com/gitweb?a=commitdiff_plain;h=6689e8db4f53f6a0bed3d1bc4ed12d31eaa3bf51;p=chaz%2Ftar tar: port --overwrite symlink test to GNU/Hurd Problem reported by Pino Toscano in . * gnulib.modules: Add fcntl-h, which defines HAVE_WORKING_O_NOFOLLOW. * src/extract.c (open_output_file): Use HAVE_WORKING_O_NOFOLLOW, not O_NOFOLLOW, when testing whther O_NOFOLLOW works. This file is a placeholder. It will be replaced with the actual ChangeLog by make dist. Run make ChangeLog if you wish to create it earlier. --- diff --git a/gnulib.modules b/gnulib.modules index 49eab65..43c9de1 100644 --- a/gnulib.modules +++ b/gnulib.modules @@ -12,6 +12,7 @@ dirname error exclude exitfail +fcntl-h fdopendir fdutimensat fileblocks diff --git a/src/extract.c b/src/extract.c index 55f3eb8..bd5e7bf 100644 --- a/src/extract.c +++ b/src/extract.c @@ -887,7 +887,8 @@ open_output_file (char const *file_name, int typeflag, mode_t mode, /* If O_NOFOLLOW is needed but does not work, check for a symlink separately. There's a race condition, but that cannot be avoided on hosts lacking O_NOFOLLOW. */ - if (! O_NOFOLLOW && overwriting_old_files && ! dereference_option) + if (! HAVE_WORKING_O_NOFOLLOW + && overwriting_old_files && ! dereference_option) { struct stat st; if (fstatat (chdir_fd, file_name, &st, AT_SYMLINK_NOFOLLOW) == 0