X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=src%2Fclient.cc;h=aef3dcbafe59287545e44203ee20cc35cf502285;hb=143d2df034e1304c1d9672226bd71f01533a1a63;hp=34fcf6fa24d929ee3eb0922da6044c8b2811b9c7;hpb=74cb09bb2cc4832463a57743b1495eef24237d2a;p=chaz%2Fopenbox diff --git a/src/client.cc b/src/client.cc index 34fcf6fa..aef3dcba 100644 --- a/src/client.cc +++ b/src/client.cc @@ -5,6 +5,8 @@ #endif #include "client.hh" +#include "frame.hh" +#include "screen.hh" #include "bbscreen.hh" #include "openbox.hh" #include "otk/display.hh" @@ -29,8 +31,6 @@ OBClient::OBClient(int screen, Window window) assert(screen >= 0); assert(window); - Openbox::instance->registerHandler(_window, this); - ignore_unmaps = 0; // update EVERYTHING the first time!! @@ -374,10 +374,10 @@ void OBClient::updateNormalHints() // defaults _gravity = NorthWestGravity; - _inc_x = _inc_y = 1; - _base_x = _base_y = 0; - _min_x = _min_y = 0; - _max_x = _max_y = INT_MAX; + _size_inc.setPoint(1, 1); + _base_size.setPoint(0, 0); + _min_size.setPoint(0, 0); + _max_size.setPoint(INT_MAX, INT_MAX); // XXX: might want to cancel any interactive resizing of the window at this // point.. @@ -389,25 +389,17 @@ void OBClient::updateNormalHints() if (size.flags & PWinGravity) _gravity = size.win_gravity; - if (size.flags & PMinSize) { - _min_x = size.min_width; - _min_y = size.min_height; - } + if (size.flags & PMinSize) + _min_size.setPoint(size.min_width, size.min_height); - if (size.flags & PMaxSize) { - _max_x = size.max_width; - _max_y = size.max_height; - } + if (size.flags & PMaxSize) + _max_size.setPoint(size.max_width, size.max_height); - if (size.flags & PBaseSize) { - _base_x = size.base_width; - _base_y = size.base_height; - } + if (size.flags & PBaseSize) + _base_size.setPoint(size.base_width, size.base_height); - if (size.flags & PResizeInc) { - _inc_x = size.width_inc; - _inc_y = size.height_inc; - } + if (size.flags & PResizeInc) + _size_inc.setPoint(size.width_inc, size.height_inc); } } @@ -504,6 +496,17 @@ void OBClient::propertyHandler(const XPropertyEvent &e) const otk::OBProperty *property = Openbox::instance->property(); + // compress changes to a single property into a single change + XEvent ce; + while (XCheckTypedEvent(otk::OBDisplay::display, e.type, &ce)) { + // XXX: it would be nice to compress ALL changes to a property, not just + // changes in a row without other props between. + if (ce.xproperty.atom != e.atom) { + XPutBackEvent(otk::OBDisplay::display, &ce); + break; + } + } + if (e.atom == XA_WM_NORMAL_HINTS) updateNormalHints(); else if (e.atom == XA_WM_HINTS) @@ -656,12 +659,44 @@ void OBClient::clientMessageHandler(const XClientMessageEvent &e) const otk::OBProperty *property = Openbox::instance->property(); - if (e.message_type == property->atom(otk::OBProperty::wm_change_state)) - setWMState(e.data.l[0]); - else if (e.message_type == - property->atom(otk::OBProperty::net_wm_desktop)) - setDesktop(e.data.l[0]); + if (e.message_type == property->atom(otk::OBProperty::wm_change_state)) { + // compress changes into a single change + bool compress = false; + XEvent ce; + while (XCheckTypedEvent(otk::OBDisplay::display, e.type, &ce)) { + // XXX: it would be nice to compress ALL messages of a type, not just + // messages in a row without other message types between. + if (ce.xclient.message_type != e.message_type) { + XPutBackEvent(otk::OBDisplay::display, &ce); + break; + } + compress = true; + } + if (compress) + setWMState(ce.xclient.data.l[0]); // use the found event + else + setWMState(e.data.l[0]); // use the original event + } else if (e.message_type == + property->atom(otk::OBProperty::net_wm_desktop)) { + // compress changes into a single change + bool compress = false; + XEvent ce; + while (XCheckTypedEvent(otk::OBDisplay::display, e.type, &ce)) { + // XXX: it would be nice to compress ALL messages of a type, not just + // messages in a row without other message types between. + if (ce.xclient.message_type != e.message_type) { + XPutBackEvent(otk::OBDisplay::display, &ce); + break; + } + compress = true; + } + if (compress) + setDesktop(e.data.l[0]); // use the found event + else + setDesktop(e.data.l[0]); // use the original event + } else if (e.message_type == property->atom(otk::OBProperty::net_wm_state)) + // can't compress these setState((StateAction)e.data.l[0], e.data.l[1], e.data.l[2]); } @@ -676,9 +711,150 @@ void OBClient::shapeHandler(const XShapeEvent &e) #endif -void OBClient::setArea(const otk::Rect &area) +void OBClient::resize(Corner anchor, int w, int h) +{ + w -= _base_size.x(); + h -= _base_size.y(); + + // is the window resizable? if it is not, then don't check its sizes, the + // client can do what it wants and the user can't change it anyhow + if (_min_size.x() <= _max_size.x() && _min_size.y() <= _max_size.y()) { + // smaller than min size or bigger than max size? + if (w < _min_size.x()) w = _min_size.x(); + else if (w > _max_size.x()) w = _max_size.x(); + if (h < _min_size.y()) h = _min_size.y(); + else if (h > _max_size.y()) h = _max_size.y(); + } + + // keep to the increments + w /= _size_inc.x(); + h /= _size_inc.y(); + + // store the logical size + _logical_size.setPoint(w, h); + + w *= _size_inc.x(); + h *= _size_inc.y(); + + w += _base_size.x(); + h += _base_size.y(); + + switch (anchor) { + case TopLeft: + break; + case TopRight: + _area.setX(_area.x() - _area.width() - w); + break; + case BottomLeft: + _area.setY(_area.y() - _area.height() - h); + break; + case BottomRight: + _area.setX(_area.x() - _area.width() - w); + _area.setY(_area.y() - _area.height() - h); + break; + } + + _area.setSize(w, h); + + // resize the frame to match + frame->adjust(); +} + + +void OBClient::move(int x, int y) { - _area = area; + _area.setPos(x, y); + // move the frame to be in the requested position + frame->applyGravity(); } + +void OBClient::configureRequestHandler(const XConfigureRequestEvent &e) +{ + OtkEventHandler::configureRequestHandler(e); + + // XXX: if we are iconic (or shaded? (fvwm does that)) ignore the event + + if (e.value_mask & CWBorderWidth) + _border_width = e.border_width; + + // resize, then move, as specified in the EWMH section 7.7 + if (e.value_mask & (CWWidth | CWHeight)) { + int w = (e.value_mask & CWWidth) ? e.width : _area.width(); + int h = (e.value_mask & CWHeight) ? e.height : _area.height(); + + Corner corner; + switch (_gravity) { + case NorthEastGravity: + case EastGravity: + corner = TopRight; + break; + case SouthWestGravity: + case SouthGravity: + corner = BottomLeft; + break; + case SouthEastGravity: + corner = BottomRight; + break; + default: // NorthWest, Static, etc + corner = TopLeft; + } + + resize(corner, w, h); + } + + if (e.value_mask & (CWX | CWY)) { + int x = (e.value_mask & CWX) ? e.x : _area.x(); + int y = (e.value_mask & CWY) ? e.y : _area.y(); + move(x, y); + } + + if (e.value_mask & CWStackMode) { + switch (e.detail) { + case Below: + case BottomIf: + // XXX: lower the window + break; + + case Above: + case TopIf: + default: + // XXX: raise the window + break; + } + } +} + + +void OBClient::unmapHandler(const XUnmapEvent &e) +{ +#ifdef DEBUG + printf("UnmapNotify for 0x%lx\n", e.window); +#endif // DEBUG + + if (ignore_unmaps) { + ignore_unmaps--; + return; + } + + OtkEventHandler::unmapHandler(e); + + // this deletes us etc + Openbox::instance->screen(_screen)->unmanageWindow(this); +} + + +void OBClient::destroyHandler(const XDestroyWindowEvent &e) +{ +#ifdef DEBUG + printf("DestroyNotify for 0x%lx\n", e.window); +#endif // DEBUG + + OtkEventHandler::destroyHandler(e); + + // this deletes us etc + Openbox::instance->screen(_screen)->unmanageWindow(this); +} + + }