X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=src%2Fclient.cc;h=618277343cc5e6eaa04a10afe130c316f8e17a00;hb=213df2814b002da2c5f324210d44559f9d651e21;hp=2d7c246ae13e77ebf64f21efbf2ec969375f23bf;hpb=29d030cc3ed6ec86b324700ec4d4c2b863154e60;p=chaz%2Fopenbox diff --git a/src/client.cc b/src/client.cc index 2d7c246a..61827734 100644 --- a/src/client.cc +++ b/src/client.cc @@ -708,7 +708,6 @@ void Client::updateIcons() unsigned long num = (unsigned) -1; unsigned long *data; unsigned long w, h, i = 0; - bool freeit = false; for (int j = 0; j < _nicons; ++j) delete [] _icons[j].data; @@ -716,38 +715,32 @@ void Client::updateIcons() delete [] _icons; _nicons = 0; - if (!otk::Property::get(_window, otk::Property::atoms.net_wm_icon, + if (otk::Property::get(_window, otk::Property::atoms.net_wm_icon, otk::Property::atoms.cardinal, &num, &data)) { - // use default icon(s) - num = openbox->screen(_screen)->config().icon_length; - data = openbox->screen(_screen)->config().default_icon; - } else - freeit = true; - - // figure out how man valid icons are in here - while (num - i > 2) { - w = data[i++]; - h = data[i++]; - i += w * h; - if (i > num) break; - ++_nicons; - } - - _icons = new Icon[_nicons]; + // figure out how man valid icons are in here + while (num - i > 2) { + w = data[i++]; + h = data[i++]; + i += w * h; + if (i > num) break; + ++_nicons; + } - // store the icons - i = 0; - for (int j = 0; j < _nicons; ++j) { - w = _icons[j].w = data[i++]; + _icons = new Icon[_nicons]; + + // store the icons + i = 0; + for (int j = 0; j < _nicons; ++j) { + w = _icons[j].w = data[i++]; h = _icons[j].h = data[i++]; _icons[j].data = new unsigned long[w * h]; ::memcpy(_icons[j].data, &data[i], w * h * sizeof(unsigned long)); i += w * h; assert(i <= num); - } + } - if (freeit) delete [] data; + } if (_nicons <= 0) { _nicons = 1; @@ -1717,8 +1710,6 @@ bool Client::focus() // visible on the screen if (!(frame->visible() && (_can_focus || _focus_notify))) return false; - if (_focused) return true; - // do a check to see if the window has already been unmapped or destroyed // do this intelligently while watching out for unmaps we've generated // (ignore_unmaps > 0) @@ -1762,8 +1753,6 @@ bool Client::focus() void Client::unfocus() const { - if (!_focused) return; - assert(openbox->focusedClient() == this); openbox->setFocusedClient(0); }