X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=src%2Fbindings.cc;h=f34b9af3d682e0d521bbe8c1cc2e7b191080119c;hb=a826509b51c03c55363f15356e73046158fe48aa;hp=f007624e07af4833cc5b0d55e056c291ef36e82e;hpb=35c3e996b57adf77b78eb756b20a15646961a74c;p=chaz%2Fopenbox

diff --git a/src/bindings.cc b/src/bindings.cc
index f007624e..f34b9af3 100644
--- a/src/bindings.cc
+++ b/src/bindings.cc
@@ -9,6 +9,9 @@
 
 extern "C" {
 #include <X11/Xlib.h>
+
+#include "gettext.h"
+#define _(str) gettext(str)
 }
 
 namespace ob {
@@ -23,9 +26,7 @@ static void print_branch(BindingTree *first, std::string str)
       print_branch(p->first_child, str + " " + p->text);
     if (!p->chain)
       printf("%d%s\n", p->id, (str + " " + p->text).c_str());
-    BindingTree *s = p->next_sibling;
-    delete p;
-    p = s;
+    p = p->next_sibling;
   }
 }
 
@@ -40,15 +41,13 @@ void OBBindings::display()
 
 bool OBBindings::translate(const std::string &str, Binding &b)
 {
-  unsigned int mods = 0;
-  
   // parse out the base key name
   std::string::size_type keybegin = str.find_last_of('-');
   keybegin = (keybegin == std::string::npos) ? 0 : keybegin + 1;
   std::string key(str, keybegin);
 
-  // XXX: get some modifiers up in the hizzie
   // parse out the requested modifier keys
+  unsigned int mods = 0;
   std::string::size_type begin = 0, end;
   while (begin != keybegin) {
     end = str.find_first_of('-', begin);
@@ -77,9 +76,10 @@ bool OBBindings::translate(const std::string &str, Binding &b)
     } else if (mod == "M5" ||   // mod5
                mod == "Mod5") {
       mods |= Mod5Mask;
+    } else {                    // invalid
+      printf(_("Invalid modifier element in key binding: %s\n"), mod.c_str());
+      return false;
     }
-    printf("got modifier: got modifier: %s\n", mod.c_str());
-    
     begin = end + 1;
   }
   
@@ -122,9 +122,6 @@ BindingTree *OBBindings::buildtree(const StringVect &keylist, int id)
     p->chain = false;
   }
 
-  printf("BUILDING:\n");
-  print_branch(ret, "");
-  
   // successfully built a tree
   return ret;
 }
@@ -153,15 +150,15 @@ void OBBindings::assimilate(BindingTree *node)
 {
   BindingTree *a, *b, *tmp, *last;
 
-  if (!parent->first_child) {
+  if (!_tree.first_child) {
     // there are no nodes at this level yet
-    parent->first_child = node;
+    _tree.first_child = node;
     return;
   } else {
-    a = parent->first_child;
+    a = _tree.first_child;
     last = a;
     b = node;
-    while (a->first_child) {
+    while (a) {
       last = a;
       if (a->binding != b->binding) {
         a = a->next_sibling;
@@ -172,7 +169,10 @@ void OBBindings::assimilate(BindingTree *node)
         a = a->first_child;
       }
     }
-    last->first_child = b->first_child;
+    if (last->binding != b->binding)
+      last->next_sibling = b;
+    else
+      last->first_child = b->first_child;
     delete b;
   }
 }