X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=src%2Factions.cc;h=fba1eaf1f27f3694b177e2a92c5fc1115940d5c4;hb=58cd3958a331e55699b3c1f640c0d2da907cdf22;hp=ffa0a8f05f01feeb6c48b53f9a48832a84c82633;hpb=31e37b3e889daec26784399f6737ec9d8830e366;p=chaz%2Fopenbox diff --git a/src/actions.cc b/src/actions.cc index ffa0a8f0..fba1eaf1 100644 --- a/src/actions.cc +++ b/src/actions.cc @@ -16,7 +16,6 @@ namespace ob { -const unsigned int OBActions::DOUBLECLICKDELAY = 300; const int OBActions::BUTTONS; OBActions::OBActions() @@ -116,7 +115,12 @@ void OBActions::buttonReleaseHandler(const XButtonEvent &e) Openbox::instance->bindings()->fireButton(data); - if (e.time - _release.time < DOUBLECLICKDELAY && + // XXX: dont load this every time!!@* + long dblclick; + if (!python_get_long("double_click_delay", &dblclick)) + dblclick = 300; + + if (e.time - _release.time < (unsigned)dblclick && _release.win == e.window && _release.button == e.button) { // run the DOUBLECLICK python hook @@ -142,12 +146,10 @@ void OBActions::enterHandler(const XCrossingEvent &e) { OtkEventHandler::enterHandler(e); - OBWidget *w = dynamic_cast - (Openbox::instance->findHandler(e.window)); - // run the ENTER python hook - doCallback(Action_EnterWindow, e.window, - (OBWidget::WidgetType)(w ? w->type():-1), e.state, 0, 0, 0, 0); + EventData *data = new_event_data(e.window, EventEnterWindow, e.state); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); } @@ -155,19 +157,16 @@ void OBActions::leaveHandler(const XCrossingEvent &e) { OtkEventHandler::leaveHandler(e); - OBWidget *w = dynamic_cast - (Openbox::instance->findHandler(e.window)); - // run the LEAVE python hook - doCallback(Action_LeaveWindow, e.window, - (OBWidget::WidgetType)(w ? w->type():-1), e.state, 0, 0, 0, 0); + EventData *data = new_event_data(e.window, EventLeaveWindow, e.state); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); } void OBActions::keyPressHandler(const XKeyEvent &e) { -// OBWidget *w = dynamic_cast -// (Openbox::instance->findHandler(e.window)); + OtkEventHandler::keyPressHandler(e); unsigned int state = e.state & (ControlMask | ShiftMask | Mod1Mask | Mod2Mask | Mod3Mask | Mod4Mask | Mod5Mask); @@ -177,6 +176,8 @@ void OBActions::keyPressHandler(const XKeyEvent &e) void OBActions::motionHandler(const XMotionEvent &e) { + OtkEventHandler::motionHandler(e); + if (!e.same_screen) return; // this just gets stupid int x_root = e.x_root, y_root = e.y_root; @@ -211,97 +212,29 @@ void OBActions::motionHandler(const XMotionEvent &e) void OBActions::mapRequestHandler(const XMapRequestEvent &e) { - doCallback(Action_NewWindow, e.window, (OBWidget::WidgetType)-1, - 0, 0, 0, 0, 0); -} + OtkEventHandler::mapRequestHandler(e); -void OBActions::unmapHandler(const XUnmapEvent &e) -{ - (void)e; - doCallback(Action_CloseWindow, e.window, (OBWidget::WidgetType)-1, - 0, 0, 0, 0, 0); -} - -void OBActions::destroyHandler(const XDestroyWindowEvent &e) -{ - (void)e; - doCallback(Action_CloseWindow, e.window, (OBWidget::WidgetType)-1, - 0, 0, 0, 0, 0); -} - -void OBActions::doCallback(ActionType action, Window window, - OBWidget::WidgetType type, unsigned int state, - unsigned int button, int xroot, int yroot, - Time time) -{ - std::pair it_pair = - _callbacks.equal_range(action); - - CallbackMap::iterator it; -// for (it = it_pair.first; it != it_pair.second; ++it) -// python_callback(it->second, action, window, type, state, -// button, xroot, yroot, time); - // XXX do a callback + EventData *data = new_event_data(e.window, EventNewWindow, 0); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); } -bool OBActions::registerCallback(ActionType action, PyObject *func, - bool atfront) +void OBActions::unmapHandler(const XUnmapEvent &e) { - if (action < 0 || action >= OBActions::NUM_ACTIONS) { - return false; - } - if (!func) - return false; - - std::pair it_pair = - _callbacks.equal_range(action); - - CallbackMap::iterator it; - for (it = it_pair.first; it != it_pair.second; ++it) - if (it->second == func) - return true; // already in there - if (atfront) - _callbacks.insert(_callbacks.begin(), CallbackMapPair(action, func)); - else - _callbacks.insert(CallbackMapPair(action, func)); - Py_INCREF(func); - return true; -} + OtkEventHandler::unmapHandler(e); -bool OBActions::unregisterCallback(ActionType action, PyObject *func) -{ - if (action < 0 || action >= OBActions::NUM_ACTIONS) { - return false; - } - if (!func) - return false; - - std::pair it_pair = - _callbacks.equal_range(action); - - CallbackMap::iterator it; - for (it = it_pair.first; it != it_pair.second; ++it) - if (it->second == func) - break; - if (it != it_pair.second) { // its been registered before - Py_DECREF(func); - _callbacks.erase(it); - } - return true; + EventData *data = new_event_data(e.window, EventCloseWindow, 0); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); } -bool OBActions::unregisterAllCallbacks(ActionType action) +void OBActions::destroyHandler(const XDestroyWindowEvent &e) { - if (action < 0 || action >= OBActions::NUM_ACTIONS) { - return false; - } + OtkEventHandler::destroyHandler(e); - while (!_callbacks.empty()) { - CallbackMap::iterator it = _callbacks.begin(); - Py_DECREF(it->second); - _callbacks.erase(it); - } - return true; + EventData *data = new_event_data(e.window, EventCloseWindow, 0); + Openbox::instance->bindings()->fireEvent(data); + Py_DECREF((PyObject*)data); } }