X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=src%2FWorkspace.cc;h=392107437f8c2df0862c3584ef2d43aac2368d56;hb=07281446ea01d1758ed8cd2aa45d0c94ce1d9830;hp=df8133deee7ad5d64c701e74da0168e1baef8cd7;hpb=df9d0c891ad0df9e91397f07fa439fea1e405b2b;p=chaz%2Fopenbox diff --git a/src/Workspace.cc b/src/Workspace.cc index df8133de..39210743 100644 --- a/src/Workspace.cc +++ b/src/Workspace.cc @@ -54,16 +54,17 @@ # include #endif // HAVE_STDLIB_H -#ifdef STDC_HEADERS +#ifdef HAVE_STRING_H # include -#endif // STDC_HEADERS +#endif // HAVE_STRING_H #include +#include typedef vector rectList; Workspace::Workspace(BScreen &scrn, int i) : screen(scrn) { - cascade_x = cascade_y = 32; + cascade_x = cascade_y = 0; id = i; @@ -92,7 +93,7 @@ Workspace::~Workspace(void) { const int Workspace::addWindow(OpenboxWindow *w, Bool place) { if (! w) return -1; - if (place) placeWindow(w); + if (place) placeWindow(*w); w->setWorkspace(id); w->setWindowNumber(windowList->count()); @@ -120,7 +121,7 @@ const int Workspace::removeWindow(OpenboxWindow *w) { if (w->isTransient() && w->getTransientFor() && w->getTransientFor()->isVisible()) { w->getTransientFor()->setInputFocus(); - } else if (screen.isSloppyFocus()) { + } else if (screen.sloppyFocus()) { screen.getOpenbox().setFocusedWindow((OpenboxWindow *) 0); } else { OpenboxWindow *top = stackingList->first(); @@ -321,6 +322,7 @@ void Workspace::setName(char *new_name) { clientmenu->setLabel(name); clientmenu->update(); + screen.saveWorkspaceNames(); } @@ -331,37 +333,37 @@ void Workspace::shutdown(void) { } } -static rectList calcSpace(const OpenboxWindow &win, const rectList &spaces) { +static rectList calcSpace(const Rect &win, const rectList &spaces) { rectList result; rectList::const_iterator siter; for(siter=spaces.begin(); siter!=spaces.end(); ++siter) { - if(win.area().Intersect(*siter)) { + if(win.Intersect(*siter)) { //Check for space to the left of the window - if(win.origin().x() > siter->x()) + if(win.x() > siter->x()) result.push_back(Rect(siter->x(), siter->y(), - win.origin().x() - siter->x() - 1, + win.x() - siter->x() - 1, siter->h())); //Check for space above the window - if(win.origin().y() > siter->y()) + if(win.y() > siter->y()) result.push_back(Rect(siter->x(), siter->y(), siter->w(), - win.origin().y() - siter->y() - 1)); + win.y() - siter->y() - 1)); //Check for space to the right of the window - if((win.origin().x()+win.size().w()) < + if((win.x()+win.w()) < (siter->x()+siter->w())) - result.push_back(Rect(win.origin().x() + win.size().w() + 1, + result.push_back(Rect(win.x() + win.w() + 1, siter->y(), siter->x() + siter->w() - - win.origin().x() - win.size().w() - 1, + win.x() - win.w() - 1, siter->h())); //Check for space below the window - if((win.origin().y()+win.size().h()) < + if((win.y()+win.h()) < (siter->y()+siter->h())) result.push_back(Rect(siter->x(), - win.origin().y() + win.size().h() + 1, + win.y() + win.h() + 1, siter->w(), siter->y() + siter->h()- - win.origin().y() - win.size().h() - 1)); + win.y() - win.h() - 1)); } else @@ -370,11 +372,35 @@ static rectList calcSpace(const OpenboxWindow &win, const rectList &spaces) { return result; } + +bool incWidth(const Rect &first, const Rect &second) { + return first.x() < second.x(); +} + + +bool decWidth(const Rect &first, const Rect &second) { + if (second.x() == first.x()) + return second.w() < first.w(); + return second.x() < first.x(); +} + + +bool incHeight(const Rect &first, const Rect &second) { + return first.y() < second.y(); +} + + +bool decHeight(const Rect &first, const Rect &second) { + if (second.y() == first.y()) + return second.h() < first.h(); + return second.y() < first.y(); +} + + //BestFitPlacement finds the smallest free space that fits the window //to be placed. It currentl ignores whether placement is right to left or top //to bottom. -Point *Workspace::bestFitPlacement(const Size &win_size, const Rect &space) -{ +Point *Workspace::bestFitPlacement(const Size &win_size, const Rect &space) { const Rect *best; rectList spaces; LinkedListIterator it(windowList); @@ -384,57 +410,75 @@ Point *Workspace::bestFitPlacement(const Size &win_size, const Rect &space) //Find Free Spaces for (OpenboxWindow *cur=it.current(); cur!=NULL; it++, cur=it.current()) - spaces = calcSpace(*cur, spaces); + spaces = calcSpace(cur->area().Inflate(screen.getBorderWidth() * 4), + spaces); + //Sort the spaces by placement choice + if (screen.rowPlacementDirection() == BScreen::TopBottom) + sort(spaces.begin(), spaces.end(), decHeight); + else + sort(spaces.begin(), spaces.end(), incHeight); + if (screen.colPlacementDirection() == BScreen::TopBottom) + stable_sort(spaces.begin(), spaces.end(), incHeight); + else + stable_sort(spaces.begin(), spaces.end(), decHeight); + //Find first space that fits the window best = NULL; for (siter=spaces.begin(); siter!=spaces.end(); ++siter) { - if ((siter->w() >= win_size.w()) && - (siter->h() >= win_size.h())) - best = siter; + if ((siter->w() >= win_size.w()) && (siter->h() >= win_size.h())) { + if (best==NULL) + best = siter; + else if(siter->w()*siter->h()h()*best->w()) + best = siter; + } } - - if (best != NULL) - return new Point(best->origin()); - else + if (best != NULL) { + Point *pt = new Point(best->origin()); + if (screen.colPlacementDirection() != BScreen::TopBottom) + pt->setY(pt->y() + (best->h() - win_size.h())); + if (screen.rowPlacementDirection() != BScreen::LeftRight) + pt->setX(pt->x() + (best->w() - win_size.w())); + return pt; + } else return NULL; //fall back to cascade } -inline Point *Workspace::rowSmartPlacement(const Size &win_size, - const Rect &space){ + +Point *Workspace::rowSmartPlacement(const Size &win_size, const Rect &space) { bool placed=false; int test_x, test_y, place_x = 0, place_y = 0; int start_pos = 0; int change_y = - ((screen.getColPlacementDirection() == BScreen::TopBottom) ? 1 : -1); + ((screen.colPlacementDirection() == BScreen::TopBottom) ? 1 : -1); int change_x = - ((screen.getRowPlacementDirection() == BScreen::LeftRight) ? 1 : -1); + ((screen.rowPlacementDirection() == BScreen::LeftRight) ? 1 : -1); int delta_x = 8, delta_y = 8; LinkedListIterator it(windowList); - test_y = (screen.getColPlacementDirection() == BScreen::TopBottom) ? + test_y = (screen.colPlacementDirection() == BScreen::TopBottom) ? start_pos : screen.size().h() - win_size.h() - start_pos; while(!placed && - ((screen.getColPlacementDirection() == BScreen::BottomTop) ? + ((screen.colPlacementDirection() == BScreen::BottomTop) ? test_y > 0 : test_y + win_size.h() < (signed) space.h())) { - test_x = (screen.getRowPlacementDirection() == BScreen::LeftRight) ? + test_x = (screen.rowPlacementDirection() == BScreen::LeftRight) ? start_pos : space.w() - win_size.w() - start_pos; while (!placed && - ((screen.getRowPlacementDirection() == BScreen::RightLeft) ? + ((screen.rowPlacementDirection() == BScreen::RightLeft) ? test_x > 0 : test_x + win_size.w() < (signed) space.w())) { placed = true; it.reset(); for (OpenboxWindow *curr = it.current(); placed && curr; it++, curr = it.current()) { - int curr_w = curr->size().w() + (screen.getBorderWidth() * 4); - int curr_h = curr->size().h() + (screen.getBorderWidth() * 4); + int curr_w = curr->area().w() + (screen.getBorderWidth() * 4); + int curr_h = curr->area().h() + (screen.getBorderWidth() * 4); - if (curr->origin().x() < test_x + win_size.w() && - curr->origin().x() + curr_w > test_x && - curr->origin().y() < test_y + win_size.h() && - curr->origin().y() + curr_h > test_y) { + if (curr->area().x() < test_x + win_size.w() && + curr->area().x() + curr_w > test_x && + curr->area().y() < test_y + win_size.h() && + curr->area().y() + curr_h > test_y) { placed = false; } } @@ -454,157 +498,121 @@ inline Point *Workspace::rowSmartPlacement(const Size &win_size, test_y += (change_y * delta_y); } - return new Point(place_x, place_y); + if (placed) + return new Point(place_x, place_y); + else + return NULL; // fall back to cascade } -void Workspace::placeWindow(OpenboxWindow *win) { - ASSERT(win != NULL); - - Bool placed = False; - - const int win_w = win->size().w() + (screen.getBorderWidth() * 4), - win_h = win->size().h() + (screen.getBorderWidth() * 4), -#ifdef SLIT - slit_x = screen.getSlit()->area().x() - screen.getBorderWidth(), - slit_y = screen.getSlit()->area().y() - screen.getBorderWidth(), - slit_w = screen.getSlit()->area().w() + - (screen.getBorderWidth() * 4), - slit_h = screen.getSlit()->area().h() + - (screen.getBorderWidth() * 4), -#endif // SLIT - toolbar_x = screen.getToolbar()->getX() - screen.getBorderWidth(), - toolbar_y = screen.getToolbar()->getY() - screen.getBorderWidth(), - toolbar_w = screen.getToolbar()->getWidth() + - (screen.getBorderWidth() * 4), - toolbar_h = screen.getToolbar()->getHeight() + - (screen.getBorderWidth() * 4), - start_pos = 0, - change_y = - ((screen.getColPlacementDirection() == BScreen::TopBottom) ? 1 : -1), - change_x = - ((screen.getRowPlacementDirection() == BScreen::LeftRight) ? 1 : -1), - delta_x = 8, delta_y = 8; - - int test_x, test_y, place_x = 0, place_y = 0; +Point *Workspace::colSmartPlacement(const Size &win_size, const Rect &space) { + Point *pt; + bool placed=false; + int test_x, test_y; + int start_pos = 0; + int change_y = + ((screen.colPlacementDirection() == BScreen::TopBottom) ? 1 : -1); + int change_x = + ((screen.rowPlacementDirection() == BScreen::LeftRight) ? 1 : -1); + int delta_x = 8, delta_y = 8; LinkedListIterator it(windowList); - Rect space(0, 0, - screen.size().w(), - screen.size().h() - ); - Size window_size(win_w, win_h); - - switch (screen.getPlacementPolicy()) { - case BScreen::BestFitPlacement: { - Point *spot = bestFitPlacement(window_size, space); - if (spot != NULL) { - place_x=spot->x(); - place_y=spot->y(); - delete spot; - placed=true; - }else - placed=false; - - break; - } - case BScreen::RowSmartPlacement: { - Point *spot=rowSmartPlacement(window_size, space); - if (spot != NULL) { - place_x=spot->x(); - place_y=spot->y(); - delete spot; - placed=true; - } - break; - } + test_x = (screen.rowPlacementDirection() == BScreen::LeftRight) ? + start_pos : screen.size().w() - win_size.w() - start_pos; + + while(!placed && + ((screen.rowPlacementDirection() == BScreen::RightLeft) ? + test_x > 0 : test_x + win_size.w() < (signed) space.w())) { + test_y = (screen.colPlacementDirection() == BScreen::TopBottom) ? + start_pos : screen.size().h() - win_size.h() - start_pos; - case BScreen::ColSmartPlacement: { - test_x = (screen.getRowPlacementDirection() == BScreen::LeftRight) ? - start_pos : screen.size().w() - win_w - start_pos; + while(!placed && + ((screen.colPlacementDirection() == BScreen::BottomTop) ? + test_y > 0 : test_y + win_size.h() < (signed) space.h())){ - while (!placed && - ((screen.getRowPlacementDirection() == BScreen::RightLeft) ? - test_x > 0 : test_x + win_w < (signed) screen.size().w())) { - test_y = (screen.getColPlacementDirection() == BScreen::TopBottom) ? - start_pos : screen.size().h() - win_h - start_pos; - - while (!placed && - ((screen.getColPlacementDirection() == BScreen::BottomTop) ? - test_y > 0 : test_y + win_h < (signed) screen.size().h())) { - placed = True; - - it.reset(); - for (OpenboxWindow *curr = it.current(); placed && curr; - it++, curr = it.current()) { - if (curr->isMaximizedFull()) // fully maximized, ignore it - continue; - int curr_w = curr->size().w() + (screen.getBorderWidth() * 4); - int curr_h = - ((curr->isShaded()) ? curr->getTitleHeight() : curr->size().h()) + - (screen.getBorderWidth() * 4); - - if (curr->origin().x() < test_x + win_w && - curr->origin().x() + curr_w > test_x && - curr->origin().y() < test_y + win_h && - curr->origin().y() + curr_h > test_y) { - placed = False; - } + placed = true; + + it.reset(); + for (OpenboxWindow *curr = it.current(); placed && curr; + it++, curr = it.current()) { + int curr_w = curr->area().w() + (screen.getBorderWidth() * 4); + int curr_h = curr->area().h() + (screen.getBorderWidth() * 4); + + if (curr->area().x() < test_x + win_size.w() && + curr->area().x() + curr_w > test_x && + curr->area().y() < test_y + win_size.h() && + curr->area().y() + curr_h > test_y) { + placed = False; } + } + + // Removed code checking for intersection with Toolbar and Slit + // The space passed to this method should not include either + + if (placed) { + pt= new Point(test_x,test_y); - if (placed && - (toolbar_x < test_x + win_w && - toolbar_x + toolbar_w > test_x && - toolbar_y < test_y + win_h && - toolbar_y + toolbar_h > test_y) -#ifdef SLIT - || - (slit_x < test_x + win_w && - slit_x + slit_w > test_x && - slit_y < test_y + win_h && - slit_y + slit_h > test_y) -#endif // SLIT - ) - placed = False; - - if (placed) { - place_x = test_x; - place_y = test_y; - - break; - } - - test_y += (change_y * delta_y); + break; } - test_x += (change_x * delta_x); + test_y += (change_y * delta_y); } - break; + test_x += (change_x * delta_x); } - } // switch + if (placed) + return pt; + else + return NULL; +} + - if (! placed) { - Point *p = cascade(win); - place_x=p->x(); - place_y=p->y(); - delete p; +Point *const Workspace::cascadePlacement(const OpenboxWindow &win, + const Rect &space) { + if ((cascade_x + win.area().w() + screen.getBorderWidth() * 2 > + (space.x() + space.w())) || + (cascade_y + win.area().h() + screen.getBorderWidth() * 2 > + (space.y() + space.h()))) + cascade_x = cascade_y = 0; + if (cascade_x < space.x() || cascade_y < space.y()) { + cascade_x = space.x(); + cascade_y = space.y(); } - - if (place_x + win_w > (signed) screen.size().w()) - place_x = (((signed) screen.size().w()) - win_w) / 2; - if (place_y + win_h > (signed) screen.size().h()) - place_y = (((signed) screen.size().h()) - win_h) / 2; - win->configure(place_x, place_y, win->size().w(), win->size().h()); + Point *p = new Point(cascade_x, cascade_y); + cascade_x += win.getTitleHeight(); + cascade_y += win.getTitleHeight(); + return p; } -Point *Workspace::cascade(const OpenboxWindow *const win){ - if (((unsigned) cascade_x > (screen.size().w() / 2)) || - ((unsigned) cascade_y > (screen.size().h() / 2))) - cascade_x = cascade_y = 32; - cascade_x += win->getTitleHeight(); - cascade_y += win->getTitleHeight(); +void Workspace::placeWindow(OpenboxWindow &win) { + Rect space = screen.availableArea(); + const Size window_size(win.area().w()+screen.getBorderWidth() * 4, + win.area().h()+screen.getBorderWidth() * 4); + Point *place = NULL; + LinkedListIterator it(windowList); + + switch (screen.placementPolicy()) { + case BScreen::BestFitPlacement: + place = bestFitPlacement(window_size, space); + break; + case BScreen::RowSmartPlacement: + place = rowSmartPlacement(window_size, space); + break; + case BScreen::ColSmartPlacement: + place = colSmartPlacement(window_size, space); + break; + } // switch - return new Point(cascade_x, cascade_y); + if (place == NULL) + place = cascadePlacement(win, space); + + ASSERT(place != NULL); + if (place->x() + window_size.w() > (signed) space.x() + space.w()) + place->setX(((signed) space.x() + space.w() - window_size.w()) / 2); + if (place->y() + window_size.h() > (signed) space.y() + space.h()) + place->setY(((signed) space.y() + space.h() - window_size.h()) / 2); + + win.configure(place->x(), place->y(), win.area().w(), win.area().h()); + delete place; }