X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=src%2FScreen.cc;h=235a04a78c788bd7e377633d607bd816e9f83ef0;hb=bb9a37ec3d10d529f4043ba76e149f0bd510c111;hp=bdae4dac369dc15c9c81ad2b5073e6a13c12ec70;hpb=81cdff06930cb38f2138d7b41187d1e516b9e379;p=chaz%2Fopenbox

diff --git a/src/Screen.cc b/src/Screen.cc
index bdae4dac..235a04a7 100644
--- a/src/Screen.cc
+++ b/src/Screen.cc
@@ -1268,12 +1268,24 @@ void BScreen::changeWorkspaceID(unsigned int id) {
       f = win->setInputFocus();
   }
 
-  // If that fails, and we're doing focus_last, try to focus the last window.  
-  if (! f && resource.focus_last && current_workspace->getLastFocusedWindow())
-    f = current_workspace->getLastFocusedWindow()->setInputFocus();
+  // If that fails, and we're doing focus_last, try to focus the last window.
+  if (! f && resource.focus_last &&
+      (win = current_workspace->getLastFocusedWindow()))
+    f = win->setInputFocus();
 
-  // If that fails, then set focus to nothing.
-  if (! f) blackbox->setFocusedWindow((BlackboxWindow *) 0);
+  /*
+    if we found a focus target, then we set the focused window explicitly
+    because it is possible to switch off this workspace before the x server
+    generates the FocusIn event for the window. if that happens, openbox would
+    lose track of what window was the 'LastFocused' window on the workspace.
+
+    if we did not find a focus target, then set the current focused window to
+    nothing.
+  */
+  if (f)
+    blackbox->setFocusedWindow(win);
+  else
+    blackbox->setFocusedWindow((BlackboxWindow *) 0);
 
   updateNetizenCurrentWorkspace();
 }
@@ -1397,7 +1409,7 @@ void BScreen::manageWindow(Window w) {
 
   if (win->isDesktop()) {
     desktopWindowList.push_back(win->getFrameWindow());
-  } else {
+  } else { // if (win->isNormal()) {
     // don't list desktop windows as managed windows
     windowList.push_back(win);
     updateClientList();
@@ -1448,7 +1460,7 @@ void BScreen::unmanageWindow(BlackboxWindow *w, bool remap) {
         break;
       }
     assert(it != end);  // the window wasnt a desktop window?
-  } else {
+  } else { // if (w->isNormal()) {
     // we don't list desktop windows as managed windows
     windowList.remove(w);
     updateClientList();
@@ -2209,6 +2221,12 @@ void BScreen::shutdown(void) {
   while(! windowList.empty())
     unmanageWindow(windowList.front(), True);
 
+  while(! desktopWindowList.empty()) {
+    BlackboxWindow *win = blackbox->searchWindow(desktopWindowList.front());
+    assert(win);
+    unmanageWindow(win, True);
+  }
+
   slit->shutdown();
 }