X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=otk%2Feventdispatcher.cc;h=0560eec8609e27b21c56233e5f53dad9a96a4e15;hb=8269fc2b3965d12ba308caa554bfa7ee037fba13;hp=ff3b8b64a44a992cf68b49f802bd87ff5cb29ca1;hpb=870f6cca3dc930614e21b747424cd572e869ab16;p=chaz%2Fopenbox diff --git a/otk/eventdispatcher.cc b/otk/eventdispatcher.cc index ff3b8b64..0560eec8 100644 --- a/otk/eventdispatcher.cc +++ b/otk/eventdispatcher.cc @@ -1,11 +1,11 @@ // -*- mode: C++; indent-tabs-mode: nil; c-basic-offset: 2; -*- -#ifdef HAVE_CONFIG_H -# include "../config.h" -#endif +#include "config.h" #include "eventdispatcher.hh" #include "display.hh" + +#include #include namespace otk { @@ -38,8 +38,8 @@ void EventDispatcher::dispatchEvents(void) { XEvent e; - while (XPending(Display::display)) { - XNextEvent(Display::display, &e); + while (XPending(**display)) { + XNextEvent(**display, &e); #if 0//defined(DEBUG) printf("Event %d window %lx\n", e.type, e.xany.window); @@ -71,17 +71,17 @@ void EventDispatcher::dispatchEvents(void) case ButtonPress: case ButtonRelease: _lasttime = e.xbutton.time; - e.xbutton.state &= ~(LockMask | Display::numLockMask() | - Display::scrollLockMask()); + e.xbutton.state &= ~(LockMask | display->numLockMask() | + display->scrollLockMask()); break; case KeyPress: - e.xkey.state &= ~(LockMask | Display::numLockMask() | - Display::scrollLockMask()); + e.xkey.state &= ~(LockMask | display->numLockMask() | + display->scrollLockMask()); break; case MotionNotify: _lasttime = e.xmotion.time; - e.xmotion.state &= ~(LockMask | Display::numLockMask() | - Display::scrollLockMask()); + e.xmotion.state &= ~(LockMask | display->numLockMask() | + display->scrollLockMask()); break; case PropertyNotify: _lasttime = e.xproperty.time; @@ -89,6 +89,8 @@ void EventDispatcher::dispatchEvents(void) case EnterNotify: case LeaveNotify: _lasttime = e.xcrossing.time; + if (e.xcrossing.mode != NotifyNormal) + continue; // skip me! break; } @@ -99,8 +101,15 @@ void EventDispatcher::dispatchEvents(void) void EventDispatcher::dispatchFocus(const XEvent &e) { +// printf("focus %s detail %d -> 0x%lx\n", +// (e.xfocus.type == FocusIn ? "IN" : "OUT"), +// e.xfocus.detail, e.xfocus.window); // ignore focus changes from grabs - if (e.xfocus.mode == NotifyGrab) + if (e.xfocus.mode == NotifyGrab) //|| e.xfocus.mode == NotifyUngrab || + // From Metacity, from WindowMaker, ignore all funky pointer root events + // its commented out cuz I don't think we need this at all. If problems + // arise we can look into it + //e.xfocus.detail > NotifyNonlinearVirtual) return; if (e.type == FocusIn) { @@ -116,7 +125,7 @@ void EventDispatcher::dispatchFocus(const XEvent &e) // FocusOut events just make us look for FocusIn events. They are ignored // otherwise. XEvent fi; - if (XCheckTypedEvent(Display::display, FocusIn, &fi)) { + if (XCheckTypedEvent(**display, FocusIn, &fi)) { //printf("Found FocusIn\n"); dispatchFocus(fi); // dont unfocus the window we just focused! @@ -156,9 +165,17 @@ void EventDispatcher::dispatch(Window win, const XEvent &e) xwc.border_width = e.xconfigurerequest.border_width; xwc.sibling = e.xconfigurerequest.above; xwc.stack_mode = e.xconfigurerequest.detail; - - XConfigureWindow(otk::Display::display, e.xconfigurerequest.window, + +#ifdef DEBUG + printf("Proxying configure event for 0x%lx\n", e.xconfigurerequest.window); +#endif + + // we are not to be held responsible if someone sends us an invalid + // request! + display->setIgnoreErrors(true); + XConfigureWindow(**display, e.xconfigurerequest.window, e.xconfigurerequest.value_mask, &xwc); + display->setIgnoreErrors(false); } else { // grab a falback if it exists handler = _fallback;