X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fprop.c;h=44d0f2bf064c9aae0b76aa6b9702fc98d824e641;hb=75b23047d676056c1626ddaebe4158a80722ab3a;hp=7117a91c95b7b4393921881b3d1aba904d253c94;hpb=12d4c8666c9475f254783fd33d1eb2b47f32e030;p=chaz%2Fopenbox

diff --git a/openbox/prop.c b/openbox/prop.c
index 7117a91c..44d0f2bf 100644
--- a/openbox/prop.c
+++ b/openbox/prop.c
@@ -186,7 +186,7 @@ static gboolean get_prealloc(Window win, Atom prop, Atom type, int size,
 		    ((guint16*)data)[i] = ((guint16*)xdata)[i];
 		    break;
 		case 32:
-		    ((guint32*)data)[i] = ((guint32*)xdata)[i];
+		    ((guint32*)data)[i] = ((gulong*)xdata)[i];
 		    break;
 		default:
 		    g_assert_not_reached(); /* unhandled size */
@@ -225,7 +225,7 @@ static gboolean get_all(Window win, Atom prop, Atom type, int size,
 		    ((guint16*)*data)[i] = ((guint16*)xdata)[i];
 		    break;
 		case 32:
-		    ((guint32*)*data)[i] = ((guint32*)xdata)[i];
+		    ((guint32*)*data)[i] = ((gulong*)xdata)[i];
 		    break;
 		default:
 		    g_assert_not_reached(); /* unhandled size */
@@ -268,9 +268,10 @@ gboolean prop_get_string_locale(Window win, Atom prop, char **ret)
     int nstr;
 
     if (get_stringlist(win, prop, &list, &nstr) && nstr) {
-        *ret = g_locale_to_utf8(list[0], -1, NULL, NULL, NULL);
+        *ret = g_convert(list[0], strlen(list[0]), "UTF-8", "ISO-8859-1",
+                         NULL, NULL, NULL);
         XFreeStringList(list);
-        if (ret) return TRUE;
+        if (*ret) return TRUE;
     }
     return FALSE;
 }
@@ -286,13 +287,14 @@ gboolean prop_get_strings_locale(Window win, Atom prop, char ***ret)
 
         p = raw;
         for (i = 0; i < num; ++i) {
-            (*ret)[i] = g_locale_to_utf8(p, -1, NULL, NULL, NULL);
+            (*ret)[i] = g_convert(p, strlen(p), "UTF-8", "ISO-8859-1",
+                                  NULL, NULL, NULL);
             /* make sure translation did not fail */
             if (!(*ret)[i]) {
                 g_strfreev(*ret); /* free what we did so far */
                 break; /* the force is not strong with us */
             }
-            p = strchr(p, '\0');
+            p += strlen(p) + 1;
         }
 	g_free(raw);
         if (i == num)
@@ -304,12 +306,17 @@ gboolean prop_get_strings_locale(Window win, Atom prop, char ***ret)
 gboolean prop_get_string_utf8(Window win, Atom prop, char **ret)
 {
     char *raw;
+    char *str;
     guint num;
      
     if (get_all(win, prop, prop_atoms.utf8, 8, (guchar**)&raw, &num)) {
-	*ret = g_strndup(raw, num); /* grab the first string from the list */
+	str = g_strndup(raw, num); /* grab the first string from the list */
 	g_free(raw);
-	return TRUE;
+        if (g_utf8_validate(str, -1, NULL)) {
+            *ret = str;
+            return TRUE;
+        }
+        g_free(str);
     }
     return FALSE;
 }
@@ -325,8 +332,11 @@ gboolean prop_get_strings_utf8(Window win, Atom prop, char ***ret)
 
         p = raw;
         for (i = 0; i < num; ++i) {
-            (*ret)[i] = g_strdup(p);
-            p = strchr(p, '\0');
+            if (g_utf8_validate(p, -1, NULL))
+                (*ret)[i] = g_strdup(p);
+            else
+                (*ret)[i] = g_strdup("");
+            p += strlen(p) + 1;
         }
 	g_free(raw);
 	return TRUE;