X-Git-Url: https://git.dogcows.com/gitweb?a=blobdiff_plain;f=openbox%2Fpopup.c;h=a52a23dbe4e67ad5d7c781447aa34c41dad7e043;hb=4e9a3becb48e0dd62723769996c2f8d808d227a6;hp=6099edcb2d237c5000c2e5e9db9b5c9a1aef6181;hpb=8349e4ca6ba679a6a43cd56a282502eacafc580d;p=chaz%2Fopenbox diff --git a/openbox/popup.c b/openbox/popup.c index 6099edcb..a52a23db 100644 --- a/openbox/popup.c +++ b/openbox/popup.c @@ -158,7 +158,13 @@ void popup_delay_show(ObPopup *self, gulong usec, gchar *text) area = screen_physical_area(); - RrMargins(self->a_bg, &l, &t, &r, &b); + /* when there is no icon and the text is not parent relative, then + fill the whole dialog with the text appearance, don't use the bg at all + */ + if (self->hasicon || self->a_text->surface.grad == RR_SURFACE_PARENTREL) + RrMargins(self->a_bg, &l, &t, &r, &b); + else + l = t = r = b = 0; /* set up the textures */ self->a_text->texture[0].data.text.string = text; @@ -179,6 +185,7 @@ void popup_delay_show(ObPopup *self, gulong usec, gchar *text) if (self->textw) textw = self->textw; + else iconx = textx = l + ob_rr_theme->paddingx; @@ -195,6 +202,17 @@ void popup_delay_show(ObPopup *self, gulong usec, gchar *text) texty = (h - texth - emptyy) / 2 + t + ob_rr_theme->paddingy; icony = (h - iconh - emptyy) / 2 + t + ob_rr_theme->paddingy; + /* when there is no icon, then fill the whole dialog with the text + appearance + */ + if (!self->hasicon) + { + textx = texty = 0; + texth += emptyy; + textw += emptyx; + emptyx = emptyy = 0; + } + w = textw + emptyx + iconw; /* cap it at maxw/minw */ if (self->maxw) w = MIN(w, self->maxw); @@ -233,7 +251,11 @@ void popup_delay_show(ObPopup *self, gulong usec, gchar *text) /* set the windows/appearances up */ XMoveResizeWindow(ob_display, self->bg, x, y, w, h); - RrPaint(self->a_bg, self->bg, w, h); + /* when there is no icon and the text is not parent relative, then + fill the whole dialog with the text appearance, don't use the bg at all + */ + if (self->hasicon || self->a_text->surface.grad == RR_SURFACE_PARENTREL) + RrPaint(self->a_bg, self->bg, w, h); if (textw) { self->a_text->surface.parent = self->a_bg;